Skip to contentSkip to conversation

sudo: add fix for non-utmpx toolchains

PATCH New Gustavo Zacarias 3 participants 4 messages Mar 30, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sudo: add fix for non-utmpx toolchains

The utmpx defines for when the target systems lacks utmpx is incomplete, resulting in a build failure, so fix it.
This can be triggered by a uClibc toolchain that lacks UTMPX in the configuration, or an older (<= 0.9.31) uClibc which lacks the functionality.

---
 package/sudo/sudo-1.8.4p4-utmpx.patch |   19 +++++++++++++++++++
 1 files changed, 19 insertions(+), 0 deletions(-)
 create mode 100644 package/sudo/sudo-1.8.4p4-utmpx.patch
package/sudo/sudo-1.8.4p4-utmpx.patch new file +19 -0
new file mode 100644
index 0000000..4e97406
@@ -0,0 +1,19 @@
+Fix incomplete setutxent/endutxent defines for when there's no utmpx
+Upstream bug #551
+
+Signed-off-by: Gustavo Zacarias <[email protected]>
+
+diff -Nura sudo-1.8.4p4.orig/src/utmp.c sudo-1.8.4p4/src/utmp.c
+--- sudo-1.8.4p4.orig/src/utmp.c	2012-03-30 07:10:38.381706315 -0300
++++ sudo-1.8.4p4/src/utmp.c	2012-03-30 07:10:52.605802501 -0300
+@@ -63,8 +63,8 @@
+ #if !defined(HAVE_GETUTXID) && defined(HAVE_GETUTID)
+ # define getutxline(u)	getutline(u)
+ # define pututxline(u)	pututline(u)
+-# define setutxent	setutent(u)
+-# define endutxent	endutent(u)
++# define setutxent(u)	setutent(u)
++# define endutxent(u)	endutent(u)
+ #endif /* !HAVE_GETUTXID && HAVE_GETUTID */
+ 
+ #ifdef HAVE_GETUTXID
Signature · 1 line
1.7.3.4
#1 lore raw

PATCH 1/1 sudo: add fix for non-utmpx toolchains

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Gustavo" == Gustavo Zacarias <[email protected]> writes:

Gustavo> The utmpx defines for when the target systems lacks utmpx is incomplete, Gustavo> resulting in a build failure, so fix it.
Gustavo> This can be triggered by a uClibc toolchain that lacks UTMPX in the Gustavo> configuration, or an older (<= 0.9.31) uClibc which lacks the Gustavo> functionality.

Committed, thanks.

Don't forget to send it upsteam as well.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 sudo: add fix for non-utmpx toolchains

Quoted 3 lines · Peter Korsgaard

Committed, thanks.

Don't forget to send it upsteam as well.

Already did before submitting it here, check inside the patch :) I tend to stick the upstream status inside to make it better for tracking.
Regards.

#3 lore raw

PATCH 1/1 sudo: add fix for non-utmpx toolchains

In reply to Gustavo Zacarias

Le Fri, 30 Mar 2012 07:35:53 -0300,
Gustavo Zacarias <[email protected]> a ?crit :

Quoted 7 lines

The utmpx defines for when the target systems lacks utmpx is incomplete, resulting in a build failure, so fix it.
This can be triggered by a uClibc toolchain that lacks UTMPX in the configuration, or an older (<= 0.9.31) uClibc which lacks the functionality.

Thanks for having fixed this!

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com