Skip to contentSkip to conversation

'source' target should depend on 'dirs'

PATCH New Thomas De Schampheleire 2 participants 2 messages Jul 27, 2011 – Aug 4, 2011 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 'source' target should depend on 'dirs'

In the following command flow:
make distclean
make <board>_defconfig
make source

the dl directory would normally be created by the first wget download. If there are no such downloads, e.g. because you use a local download mirror (e.g. scp, file) or only use git/svn/hg/bzr repositories, the dl directory is not created automatically. This causes e.g. the 'pushd' command in the respective _DOWNLOAD commands to fail.

This patch adds a dependency to the 'dirs' target to 'source', fixing this scenario.

Makefile +1 -1
@@ -486,7 +486,7 @@
 	done
 endif
 
-source: $(TARGETS_SOURCE) $(HOST_SOURCE)
+source: dirs $(TARGETS_SOURCE) $(HOST_SOURCE)
 
 external-deps:
 	@$(MAKE) -Bs DL_MODE=SHOW_EXTERNAL_DEPS $(EXTRAMAKEARGS) source | sort -u
#1 lore raw

PATCH 1/1 'source' target should depend on 'dirs'

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas De Schampheleire <[email protected]> writes:

Thomas> In the following command flow:
Thomas> make distclean
Thomas> make <board>_defconfig
Thomas> make source

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard