Skip to contentSkip to conversation

implement 'wait' instruction

PATCH Zhenyu Wang 2 participants 3 messages Jun 29, 2010 – Jul 2, 2010

lore
Share & tools
lore
#0 lore raw

'Wait' instruction allows EU to stop and wait notification register state clear to continue the execution. And we can clear the notifications through MMIO, so we can track EU execution step by step.

I use below patch for implement 'wait' in mesa, and attach 'intel_eu_cont.c' program to kick EU to continue. This is useful in debugging sandybridge for me.

From 34d96de16228013802ca577bb1007c5877ac5279 Mon Sep 17 00:00:00 2001
From: Zhenyu Wang <[email protected]>
Date: Fri, 25 Jun 2010 16:05:24 +0800
Subject: [PATCH] i965: Add 'wait' instruction support

When EU executes 'wait' instruction, it stalls and sets notification register state. Host can issue MMIO write to clear notification register state to allow EU continue on executing again.

---
 src/mesa/drivers/dri/i965/brw_eu.h      |   16 ++++++++++++++++
 src/mesa/drivers/dri/i965/brw_eu_emit.c |   14 ++++++++++++++
 2 files changed, 30 insertions(+), 0 deletions(-)
src/mesa/drivers/dri/i965/brw_eu.h +16 -0
index a6fcd83..3a01000 100644
@@ -520,6 +520,20 @@ static INLINE struct brw_reg brw_acc_reg( void )
 		       0);
 }
 
+static INLINE struct brw_reg brw_notification_1_reg(void)
+{
+
+   return brw_reg(BRW_ARCHITECTURE_REGISTER_FILE,
+		  BRW_ARF_NOTIFICATION_COUNT,
+		  1,
+		  BRW_REGISTER_TYPE_UD,
+		  BRW_VERTICAL_STRIDE_0,
+		  BRW_WIDTH_1,
+		  BRW_HORIZONTAL_STRIDE_0,
+		  BRW_SWIZZLE_XXXX,
+		  WRITEMASK_X);
+}
+
 
 static INLINE struct brw_reg brw_flag_reg( void )
 {
@@ -919,6 +933,8 @@ void brw_land_fwd_jump(struct brw_compile *p,
 
 void brw_NOP(struct brw_compile *p);
 
+void brw_WAIT(struct brw_compile *p);
+
 /* Special case: there is never a destination, execution size will be
  * taken from src0:
  */
src/mesa/drivers/dri/i965/brw_eu_emit.c +14 -0
index 34dfe10..10e9ebc 100644
@@ -906,6 +906,20 @@ void brw_CMP(struct brw_compile *p,
    }
 }
 
+/* Issue 'wait' instruction for n1, host could program MMIO
+   to wake up thread. */
+void brw_WAIT (struct brw_compile *p)
+{
+   struct brw_instruction *insn = next_insn(p, BRW_OPCODE_WAIT);
+   struct brw_reg src = brw_notification_1_reg();
+
+   brw_set_dest(insn, src);
+   brw_set_src0(insn, src);
+   brw_set_src1(insn, brw_null_reg());
+   insn->header.execution_size = 0; /* must */
+   insn->header.predicate_control = 0;
+   insn->header.compression_control = 0;
+}
 
 
 /***********************************************************************
Signature · 7 lines
1.7.0.4


-- 
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

/*
* Copyright © 2009 Intel Corporation
*
* Permission is hereby granted, free of charge, to any person obtaining a
* copy of this software and associated documentation files (the "Software"),
* to deal in the Software without restriction, including without limitation
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
* and/or sell copies of the Software, and to permit persons to whom the
* Software is furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice (including the next
* paragraph) shall be included in all copies or substantial portions of the
* Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
* DEALINGS IN THE SOFTWARE.
*
* Authors:
* Zhenyu Wang <[email protected]>
*
*/

#define _GNU_SOURCE
#include <unistd.h>
#include <stdlib.h>
#include <stdio.h>
#include <string.h>
#include <err.h>
#include "intel_gpu_tools.h"

static uint32_t devid;

#define EU_ATT_CLR 0x7830
#define EU_ATT_CLR_2 0x7834

int main(int argc, char **argv)

{
	struct pci_device *pci_dev;

	pci_dev = intel_get_pci_device();
	devid = pci_dev->device_id; /* XXX not true when mapping! */

	intel_get_mmio(pci_dev);

	printf("Clear EU wait attention.\n");
	OUTREG(EU_ATT_CLR, 0xffffffff);
	OUTREG(EU_ATT_CLR_2, 0xffffffff);

	OUTREG(EU_ATT_CLR, 0);
	OUTREG(EU_ATT_CLR_2, 0);

	return 0;
}

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#1 lore raw
Quoted 9 lines · Zhenyu Wang

'Wait' instruction allows EU to stop and wait notification register state clear to continue the execution. And we can clear the notifications through MMIO, so we can track EU execution step by step.

I use below patch for implement 'wait' in mesa, and attach 'intel_eu_cont.c' program to kick EU to continue. This is useful in debugging sandybridge for me.

Interesting. So are you able to get any more information out besides "somebody is waiting"? Inspect register state, instruction pointer, anything?

I can see how just getting "somebody is waiting" would be useful, though, so I'd be happy to see these patches land.

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw
Quoted 7 lines · Eric Anholt
Quoted 6 lines · Zhenyu Wang

'Wait' instruction allows EU to stop and wait notification register state clear to continue the execution. And we can clear the notifications through MMIO, so we can track EU execution step by step.

Quoted 7 lines
Quoted 3 lines

I use below patch for implement 'wait' in mesa, and attach 'intel_eu_cont.c' program to kick EU to continue. This is useful in debugging sandybridge for me.

Interesting. So are you able to get any more information out besides "somebody is waiting"? Inspect register state, instruction pointer, anything?

No yet, I believe something else like snapshot debug should be used for that, but some experiment gave me nothing.

'wait' is just handy for me to track thread execution process.

Quoted 2 lines

I can see how just getting "somebody is waiting" would be useful, though, so I'd be happy to see these patches land.

ok, I'll push them later.

thanks.

Signature · 3 lines
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx