Skip to contentSkip to conversation

fix broken path in arm_toolchain_defconfig

PATCH New Chih-Min Chao 3 participants 5 messages May 14, 2010 – May 22, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix broken path in arm_toolchain_defconfig

The path of device_table.txt in arm_toolchain_defconfig is broken.
The patch fix it and use target/generic/device_table.txt as default setting Please see the attached
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20100514/16ccf5a8/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: arm_toolchain_defconfig.patch
Type: text/x-patch
Size: 688 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20100514/16ccf5a8/attachment.bin>

#1 lore raw

PATCH 1/1 fix broken path in arm_toolchain_defconfig

Quoted 2 lines · On Fri, 14 May 2010 16:12:05 +0800 Chih-Min Chao <[email protected]> wrote:

The path of device_table.txt in arm_toolchain_defconfig is broken. The patch fix it and use target/generic/device_table.txt as default setting

You forgot the Signed-off-by line in the commit log, however.

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#2 lore raw

PATCH 1/1 fix broken path in arm_toolchain_defconfig

Quoted 12 lines · Thomas Petazzoni
Quoted 2 lines · On Fri, 14 May 2010 16:12:05 +0800 Chih-Min Chao <[email protected]> wrote:

The path of device_table.txt in arm_toolchain_defconfig is broken. The patch fix it and use target/generic/device_table.txt as default

setting

You forgot the Signed-off-by line in the commit log, however. Thomas

So, should I generate the patch by "git format-patch --signoff revision_range" ??
If the answer is yes, the attached is the reformat patch with sign-off-by information

Quoted 10 lines

--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20100521/43b03fe3/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fix-device_table.txt-path-in-arm_toolchain_defconfig.patch
Type: text/x-patch
Size: 873 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20100521/43b03fe3/attachment.bin>

#3 lore raw

PATCH 1/1 fix broken path in arm_toolchain_defconfig

Quoted 2 lines · On Fri, 21 May 2010 15:12:13 +0800 Chih-Min Chao <[email protected]> wrote:

So, should I generate the patch by "git format-patch --signoff revision_range" ??

It is usually at commit time that the signed-off line is added, by doing :

git commit -s

instead of just

git commit

Typical very basic work-flow :

# Assuming you are on master

# Create a new branch for your work and switch to this branch git checkout -b mywork

# Hack hack hack

# Commit your work (supposing you want to all changes in a single # commit, which may or may not be appropriate)
git commit -a -s

# Format the patch (or patches)
git format-patch master

# Send the patch
git send-email --to buildroot at uclibc.org *.patch

Regards,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#4 lore raw

PATCH 1/1 fix broken path in arm_toolchain_defconfig

In reply to Chih-Min Chao
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Chih-Min" == Chih-Min Chao <[email protected]> writes:

Chih-Min> So, should I generate the patch by "git format-patch --signoff? revision_range" Chih-Min> ??
Chih-Min> If the answer is yes, the attached is the reformat patch with sign-off-by Chih-Min> information

Committed, thanks!

Signature · 1 line
Bye, Peter Korsgaard