Add the DTV_ISDB_TS_ID property for ISDB-S

PATCH In review [email protected] 2 participants 3 messages May 7, 2009 – Jul 7, 2009 Media (V4L/DVB)

Share & tools

[email protected]

author

2009-05-07 15:24 UTC #0 lore raw

PATCH 1/1 Add the DTV_ISDB_TS_ID property for ISDB-S

# HG changeset patch
# User HIRANO Takahito <[email protected]> # Date 1235532786 -32400
# Node ID 5e6932c1b659d6bfea781a81d06098e85c6ff203 # Parent fe524e0a64126791bdf3dd94a50bdcdb0592ef7f Add the DTV_ISDB_TS_ID property for ISDB-S

In ISDB-S, time-devision duplex is used to multiplexing several waves in the same frequency. Each wave is identified by its own transport stream ID, or TS ID. We need to provide some way to specify this ID from user applications to handle ISDB-S frontends.

This code has been tested with Earthsoft PT1 driver, which is under development at:
http://bitbucket.org/hiranotaka/dvb-pt1/

Signed-off-by HIRANO Takahito <[email protected]>

linux/drivers/media/dvb/dvb-core/dvb_frontend.c +11 -0

diff -r fe524e0a6412 -r 5e6932c1b659 linux/drivers/media/dvb/dvb-core/dvb_frontend.c
@@ -946,6 +946,11 @@
 		.cmd	= DTV_TRANSMISSION_MODE,
 		.set	= 1,
 	},
+	[DTV_ISDB_TS_ID] = {
+		.name	= "DTV_ISDB_TS_ID",
+		.cmd	= DTV_ISDB_TS_ID,
+		.set	= 1,
+	},
 	/* Get */
 	[DTV_DISEQC_SLAVE_REPLY] = {
 		.name	= "DTV_DISEQC_SLAVE_REPLY",

@@ -1354,6 +1359,9 @@
 	case DTV_HIERARCHY:
 		tvp->u.data = fe->dtv_property_cache.hierarchy;
 		break;
+	case DTV_ISDB_TS_ID:
+		tvp->u.data = fe->dtv_property_cache.isdb_ts_id;
+		break;
 	default:
 		r = -1;
 	}

@@ -1460,6 +1468,9 @@
 	case DTV_HIERARCHY:
 		fe->dtv_property_cache.hierarchy = tvp->u.data;
 		break;
+	case DTV_ISDB_TS_ID:
+		fe->dtv_property_cache.isdb_ts_id = tvp->u.data;
+		break;
 	default:
 		r = -1;
 	}

linux/drivers/media/dvb/dvb-core/dvb_frontend.h +1 -0

diff -r fe524e0a6412 -r 5e6932c1b659 linux/drivers/media/dvb/dvb-core/dvb_frontend.h
@@ -355,6 +355,7 @@
 	fe_modulation_t		isdb_layerc_modulation;
 	u32			isdb_layerc_segment_width;
 #endif
+	u32			isdb_ts_id;
 };
 
 struct dvb_frontend {

linux/include/linux/dvb/frontend.h +3 -1

diff -r fe524e0a6412 -r 5e6932c1b659 linux/include/linux/dvb/frontend.h
@@ -307,7 +307,9 @@
 #define DTV_TRANSMISSION_MODE			39
 #define DTV_HIERARCHY				40
 
-#define DTV_MAX_COMMAND				DTV_HIERARCHY
+#define DTV_ISDB_TS_ID				41
+
+#define DTV_MAX_COMMAND				DTV_ISDB_TS_ID
 
 typedef enum fe_pilot {
 	PILOT_ON,

Mauro Carvalho Chehab

2009-06-16 11:56 UTC #1 lore raw

Hi Hirano,

Em Fri, 08 May 2009 00:24:11 +0900
[email protected] escreveu:

Quoted 7 lines

# HG changeset patch
# User HIRANO Takahito <[email protected]> # Date 1235532786 -32400
# Node ID 5e6932c1b659d6bfea781a81d06098e85c6ff203 # Parent fe524e0a64126791bdf3dd94a50bdcdb0592ef7f Add the DTV_ISDB_TS_ID property for ISDB-S

Quoted 8 lines

In ISDB-S, time-devision duplex is used to multiplexing several waves in the same frequency. Each wave is identified by its own transport stream ID, or TS ID. We need to provide some way to specify this ID from user applications to handle ISDB-S frontends.
This code has been tested with Earthsoft PT1 driver, which is under development at:
http://bitbucket.org/hiranotaka/dvb-pt1/

API changes should be submitted together with the driver. This allows us to better understand driver needs.

So, please re-submit this when you'll be ready to submit your driver.

Thanks,
Mauro.

Quoted 64 lines

Signed-off-by HIRANO Takahito <[email protected]>

diff -r fe524e0a6412 -r 5e6932c1b659 linux/drivers/media/dvb/dvb-core/dvb_frontend.c

linux/drivers/media/dvb/dvb-core/dvb_frontend.c +11 -0

@@ -946,6 +946,11 @@
 		.cmd	= DTV_TRANSMISSION_MODE,
 		.set	= 1,
 	},
+	[DTV_ISDB_TS_ID] = {
+		.name	= "DTV_ISDB_TS_ID",
+		.cmd	= DTV_ISDB_TS_ID,
+		.set	= 1,
+	},
 	/* Get */
 	[DTV_DISEQC_SLAVE_REPLY] = {
 		.name	= "DTV_DISEQC_SLAVE_REPLY",

@@ -1354,6 +1359,9 @@
 	case DTV_HIERARCHY:
 		tvp->u.data = fe->dtv_property_cache.hierarchy;
 		break;
+	case DTV_ISDB_TS_ID:
+		tvp->u.data = fe->dtv_property_cache.isdb_ts_id;
+		break;
 	default:
 		r = -1;
 	}

@@ -1460,6 +1468,9 @@
 	case DTV_HIERARCHY:
 		fe->dtv_property_cache.hierarchy = tvp->u.data;
 		break;
+	case DTV_ISDB_TS_ID:
+		fe->dtv_property_cache.isdb_ts_id = tvp->u.data;
+		break;
 	default:
 		r = -1;
 	}

diff -r fe524e0a6412 -r 5e6932c1b659 linux/drivers/media/dvb/dvb-core/dvb_frontend.h

linux/drivers/media/dvb/dvb-core/dvb_frontend.h +1 -0

@@ -355,6 +355,7 @@
 	fe_modulation_t		isdb_layerc_modulation;
 	u32			isdb_layerc_segment_width;
 #endif
+	u32			isdb_ts_id;
 };
 
 struct dvb_frontend {

diff -r fe524e0a6412 -r 5e6932c1b659 linux/include/linux/dvb/frontend.h

linux/include/linux/dvb/frontend.h +3 -2

@@ -307,7 +307,9 @@
 #define DTV_TRANSMISSION_MODE			39
 #define DTV_HIERARCHY				40
 
-#define DTV_MAX_COMMAND				DTV_HIERARCHY
+#define DTV_ISDB_TS_ID				41
+
+#define DTV_MAX_COMMAND				DTV_ISDB_TS_ID
 
 typedef enum fe_pilot {
 	PILOT_ON,
--

Quoted 3 lines

To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Cheers,
Mauro

HIRANO Takahito

author

2009-07-07 07:51 UTC #2 lore raw

Hi,

Thank you for your comment!
Unfortunately, the vendor ended the sale of this device, so it became a bit meaningless to merge this to the mainline.

Best Regards,
HIRANO Takahito

2009/6/16 Mauro Carvalho Chehab <[email protected]>:

Quoted 103 lines

Hi Hirano,
Em Fri, 08 May 2009 00:24:11 +0900
[email protected] escreveu:
Quoted 7 lines
# HG changeset patch
# User HIRANO Takahito <[email protected]> # Date 1235532786 -32400
# Node ID 5e6932c1b659d6bfea781a81d06098e85c6ff203 # Parent fe524e0a64126791bdf3dd94a50bdcdb0592ef7f Add the DTV_ISDB_TS_ID property for ISDB-S
Quoted 8 lines
In ISDB-S, time-devision duplex is used to multiplexing several waves in the same frequency. Each wave is identified by its own transport stream ID, or TS ID. We need to provide some way to specify this ID from user applications to handle ISDB-S frontends.
This code has been tested with Earthsoft PT1 driver, which is under development at:
http://bitbucket.org/hiranotaka/dvb-pt1/
API changes should be submitted together with the driver. This allows us to better understand driver needs.
So, please re-submit this when you'll be ready to submit your driver.
Thanks,
Mauro.
Quoted 64 lines
Signed-off-by HIRANO Takahito <[email protected]>
diff -r fe524e0a6412 -r 5e6932c1b659 linux/drivers/media/dvb/dvb-core/dvb_frontend.c
linux/drivers/media/dvb/dvb-core/dvb_frontend.c Wed Feb 25 12:33:06 2009 +0900 renamed from linux/drivers/media/dvb/dvb-core/dvb_frontend.c Tue May 05 08:50:54 2009 -0300 +5 -0
@@ -946,6 +946,11 @@
               .cmd    = DTV_TRANSMISSION_MODE,
               .set    = 1,
       },
+     [DTV_ISDB_TS_ID] = {
+             .name   = "DTV_ISDB_TS_ID",
+             .cmd    = DTV_ISDB_TS_ID,
+             .set    = 1,
+     },
       /* Get */
       [DTV_DISEQC_SLAVE_REPLY] = {
               .name   = "DTV_DISEQC_SLAVE_REPLY",
@@ -1354,6 +1359,9 @@
case DTV_HIERARCHY:
tvp->u.data = fe->dtv_property_cache.hierarchy; break;
+ case DTV_ISDB_TS_ID:
+ tvp->u.data = fe->dtv_property_cache.isdb_ts_id;
+ break;
default:
r = -1;
}
linux/drivers/media/dvb/dvb-core/dvb_frontend.c Wed Feb 25 12:33:06 2009 +0900 renamed from linux/drivers/media/dvb/dvb-core/dvb_frontend.c Tue May 05 08:50:54 2009 -0300 +0 -0
@@ -1460,6 +1468,9 @@
case DTV_HIERARCHY:
fe->dtv_property_cache.hierarchy = tvp->u.data;
break;
+ case DTV_ISDB_TS_ID:
+ fe->dtv_property_cache.isdb_ts_id = tvp->u.data;
+ break;
default:
r = -1;
}
diff -r fe524e0a6412 -r 5e6932c1b659 linux/drivers/media/dvb/dvb-core/dvb_frontend.h
linux/drivers/media/dvb/dvb-core/dvb_frontend.h Wed Feb 25 12:33:06 2009 +0900 renamed from linux/drivers/media/dvb/dvb-core/dvb_frontend.h Tue May 05 08:50:54 2009 -0300 +1 -0
@@ -355,6 +355,7 @@
       fe_modulation_t         isdb_layerc_modulation;
       u32                     isdb_layerc_segment_width;
  #endif
+     u32                     isdb_ts_id;
  };
 
  struct dvb_frontend {
diff -r fe524e0a6412 -r 5e6932c1b659 linux/include/linux/dvb/frontend.h
linux/include/linux/dvb/frontend.h Wed Feb 25 12:33:06 2009 +0900 renamed from linux/include/linux/dvb/frontend.h Tue May 05 08:50:54 2009 -0300 +3 -2
@@ -307,7 +307,9 @@
  #define DTV_TRANSMISSION_MODE                        39
  #define DTV_HIERARCHY                                40
 
-#define DTV_MAX_COMMAND                              DTV_HIERARCHY
+#define DTV_ISDB_TS_ID                               41
+
+#define DTV_MAX_COMMAND                              DTV_ISDB_TS_ID
 
  typedef enum fe_pilot {
       PILOT_ON,
--
Quoted 3 lines
To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Cheers,
Mauro