Skip to contentSkip to conversation

genirq: Add the entropy pool function to the PPI interrupt handler

PATCH In review Enlin Mu 3 participants 3 messages Jun 16 – Jun 17 IRQ

lore
Share & tools
lore

Enlin Mu

author
#0 lore raw

PATCH v2 1/1 genirq: Add the entropy pool function to the PPI interrupt handler

Accelerate the entropy pool initialization process.
The function handle_irq_event_percpu adds entropy pool initialization, but this logic is missing in the PPI interrupt handler. I think this was simply an accidental omission.

---
v2:updated the commit message

---
 kernel/irq/chip.c | 1 +
 1 file changed, 1 insertion(+)
kernel/irq/chip.c +1 -0
index de754db414d1..cbbd7e7d1156 100644
@@ -926,6 +926,7 @@ void handle_percpu_devid_irq(struct irq_desc *desc)
 		trace_irq_handler_entry(irq, action);
 		res = action->handler(irq, raw_cpu_ptr(action->percpu_dev_id));
 		trace_irq_handler_exit(irq, action, res);
+		add_interrupt_randomness(irq);
 	} else {
 		bool enabled = cpumask_test_cpu(cpu, desc->percpu_enabled);
 
Signature · 1 line
2.39.5
#1 lore raw

From: Enlin Mu <[email protected]> Sent: Tuesday, June 16, 2026 3:02 AM

Quoted 5 lines

Accelerate the entropy pool initialization process.
The function handle_irq_event_percpu adds entropy pool initialization, but this logic is missing in the PPI interrupt handler. I think this was simply an accidental omission.

This change has already been made via a patch I submitted. The change is in the 7.1 release. See commit fd7400cfcbaa and a follow-on fix in commit 512718bbc51b.

Michael

Quoted 23 lines

---
v2:updated the commit message

---
 kernel/irq/chip.c | 1 +
 1 file changed, 1 insertion(+)
kernel/irq/chip.c +1 -1
index de754db414d1..cbbd7e7d1156 100644
@@ -926,6 +926,7 @@ void handle_percpu_devid_irq(struct irq_desc *desc)
 		trace_irq_handler_entry(irq, action);
 		res = action->handler(irq, raw_cpu_ptr(action->percpu_dev_id));
 		trace_irq_handler_exit(irq, action, res);
+		add_interrupt_randomness(irq);
 	} else {
 		bool enabled = cpumask_test_cpu(cpu, desc->percpu_enabled);
 
--

2.39.5

maintainer
#2 lore raw
Quoted 10 lines · Michael Kelley

From: Enlin Mu <[email protected]> Sent: Tuesday, June 16, 2026 3:02 AM

Quoted 5 lines

Accelerate the entropy pool initialization process.
The function handle_irq_event_percpu adds entropy pool initialization, but this logic is missing in the PPI interrupt handler. I think this was simply an accidental omission.

This change has already been made via a patch I submitted. The change is in the 7.1 release. See commit fd7400cfcbaa and a follow-on fix in commit 512718bbc51b.

You beat me to it.

Reading and following the documented process seems to be overrated....