hmp-commands-info.hx: Move definition of "info accel"
PATCH 1/1 hmp-commands-info.hx: Move definition of "info accel"
Commit c10eb740108 (accel/system: Add 'info accel' on human monitor) inserted "info accel" in the middle of "info sync-profile". Move it behind "info sync-profile".
--- hmp-commands-info.hx | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-)
hmp-commands-info.hx +12 -12
@@ -267,18 +267,6 @@ ERST .cmd = hmp_info_sync_profile, }, - { - .name = "accel", - .args_type = "", - .params = "", - .help = "show accelerator statistics", - }, - -SRST - ``info accel`` - Show accelerator statistics. -ERST - SRST ``info sync-profile [-m|-n]`` [*max*] Show synchronization profiling info, up to *max* entries (default: 10),
@@ -294,6 +282,18 @@ SRST being coalesced. ERST + { + .name = "accel", + .args_type = "", + .params = "", + .help = "show accelerator statistics", + }, + +SRST + ``info accel`` + Show accelerator statistics. +ERST + { .name = "kvm", .args_type = "",
Signature · 1 line
2.52.0
Quoted 3 lines · Markus Armbruster
Commit
c10eb740108(accel/system: Add 'info accel' on human monitor) inserted "info accel" in the middle of "info sync-profile". Move it behind "info sync-profile".
Opps, we have this kind of mistake over & over again. The .hx format is really horrible and easy to make this mistake with, and makes me rather wish we could eliminate it :-(
Quoted 5 lines
Signed-off-by Markus Armbruster <[email protected]>--- hmp-commands-info.hx | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-)
Quoted 47 lines
hmp-commands-info.hx +12
-12@@ -267,18 +267,6 @@ ERST .cmd = hmp_info_sync_profile, }, - { - .name = "accel", - .args_type = "", - .params = "", - .help = "show accelerator statistics", - }, - -SRST - ``info accel`` - Show accelerator statistics. -ERST - SRST ``info sync-profile [-m|-n]`` [*max*] Show synchronization profiling info, up to *max* entries (default: 10),@@ -294,6 +282,18 @@ SRST being coalesced. ERST + { + .name = "accel", + .args_type = "", + .params = "", + .help = "show accelerator statistics", + }, + +SRST + ``info accel`` + Show accelerator statistics. +ERST + { .name = "kvm", .args_type = "",Signature · 1 line
2.52.0
With regards,
Daniel
Signature · 3 lines
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
Quoted 8 lines · Daniel P. Berrangé
Quoted 3 lines · Markus Armbruster
Commit
c10eb740108(accel/system: Add 'info accel' on human monitor) inserted "info accel" in the middle of "info sync-profile". Move it behind "info sync-profile".Opps, we have this kind of mistake over & over again. The .hx format is really horrible and easy to make this mistake with, and makes me rather wish we could eliminate it :-(
True.
$ git-ls-files \*.hx
hmp-commands-info.hx
hmp-commands.hx
hw/audio/pl041.hx
qemu-img-cmds.hx
qemu-options.hxQuoted 6 lines
Quoted 4 lines
Signed-off-by Markus Armbruster <[email protected]>--- hmp-commands-info.hx | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-)Reviewed-by Daniel P. Berrangé <[email protected]>
Thanks!
Quoted 8 lines · * Daniel P. Berrangé ([email protected]) wrote:
Quoted 3 lines · Markus Armbruster
Commit
c10eb740108(accel/system: Add 'info accel' on human monitor) inserted "info accel" in the middle of "info sync-profile". Move it behind "info sync-profile".Opps, we have this kind of mistake over & over again. The .hx format is really horrible and easy to make this mistake with, and makes me rather wish we could eliminate it :-(
Yeh; would the tools need any change at all if we were to change it
from: --------------->
{
.name = "accel",
.args_type = "",
.params = "",
.help = "show accelerator statistics",
},SRST
``info accel``
Show accelerator statistics.
ERST
to: --------------->
{
.name = "accel",
.args_type = "",
.params = "",
.help = "show accelerator statistics",SRST
``info accel``
Show accelerator statistics.
ERST
},
--------------------
which might stop them separating from each other?
I can also imagine we could pretty easily add a check for a definition that's missing an SRST/ERST section or an SRST/ERST section that's missing a .name entry.
It also feels like it wouldn't be that hard to do:
s/SRST/#ifdef SRST/
s/ERST/#endif/
s@HXCOMM@//@
and then we can just #include the .hx files directly as headers and fix up the docs script.
Dave
Quoted 65 lines
Quoted 7 lines
Signed-off-by Markus Armbruster <[email protected]>--- hmp-commands-info.hx | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-)Reviewed-by Daniel P. Berrangé <[email protected]>Quoted 47 lines
hmp-commands-info.hx +12
-12@@ -267,18 +267,6 @@ ERST .cmd = hmp_info_sync_profile, }, - { - .name = "accel", - .args_type = "", - .params = "", - .help = "show accelerator statistics", - }, - -SRST - ``info accel`` - Show accelerator statistics. -ERST - SRST ``info sync-profile [-m|-n]`` [*max*] Show synchronization profiling info, up to *max* entries (default: 10),@@ -294,6 +282,18 @@ SRST being coalesced. ERST + { + .name = "accel", + .args_type = "", + .params = "", + .help = "show accelerator statistics", + }, + +SRST + ``info accel`` + Show accelerator statistics. +ERST + { .name = "kvm", .args_type = "",Signature · 1 line
2.52.0With regards,
DanielSignature · 3 lines
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
Signature · 4 lines
-----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/
Quoted 5 lines · * Markus Armbruster ([email protected]) wrote:
Commit
c10eb740108(accel/system: Add 'info accel' on human monitor) inserted "info accel" in the middle of "info sync-profile". Move it behind "info sync-profile".Signed-off-by Markus Armbruster <[email protected]>
Thanks!
Quoted 49 lines
--- hmp-commands-info.hx | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-)hmp-commands-info.hx +12
-12@@ -267,18 +267,6 @@ ERST .cmd = hmp_info_sync_profile, }, - { - .name = "accel", - .args_type = "", - .params = "", - .help = "show accelerator statistics", - }, - -SRST - ``info accel`` - Show accelerator statistics. -ERST - SRST ``info sync-profile [-m|-n]`` [*max*] Show synchronization profiling info, up to *max* entries (default: 10),@@ -294,6 +282,18 @@ SRST being coalesced. ERST + { + .name = "accel", + .args_type = "", + .params = "", + .help = "show accelerator statistics", + }, + +SRST + ``info accel`` + Show accelerator statistics. +ERST + { .name = "kvm", .args_type = "",Signature · 1 line
2.52.0
Signature · 4 lines
-----Open up your eyes, open up your mind, open up your code ------- / Dr. David Alan Gilbert | Running GNU/Linux | Happy \ \ dave @ treblig.org | | In Hex / \ _________________________|_____ http://www.treblig.org |_______/