Skip to contentSkip to conversation

net: usb: qmi_wwan: Set DTR quirk for MR400

PATCH In review Filip Moc 3 participants 3 messages Nov 17, 2020 – Nov 18, 2020

Subsystems (5)
lore
Share & tools
lore

Filip Moc

author
#0 lore raw

PATCH 1/1 net: usb: qmi_wwan: Set DTR quirk for MR400

LTE module MR400 embedded in TL-MR6400 v4 requires DTR to be set.

---
 drivers/net/usb/qmi_wwan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/usb/qmi_wwan.c +1 -1
index afeb09b9624e..d166c321ee9b 100644
@@ -1047,7 +1047,7 @@ static const struct usb_device_id products[] = {
 	{QMI_FIXED_INTF(0x05c6, 0x9011, 4)},
 	{QMI_FIXED_INTF(0x05c6, 0x9021, 1)},
 	{QMI_FIXED_INTF(0x05c6, 0x9022, 2)},
-	{QMI_FIXED_INTF(0x05c6, 0x9025, 4)},	/* Alcatel-sbell ASB TL131 TDD LTE  (China Mobile) */
+	{QMI_QUIRK_SET_DTR(0x05c6, 0x9025, 4)},	/* Alcatel-sbell ASB TL131 TDD LTE (China Mobile) */
 	{QMI_FIXED_INTF(0x05c6, 0x9026, 3)},
 	{QMI_FIXED_INTF(0x05c6, 0x902e, 5)},
 	{QMI_FIXED_INTF(0x05c6, 0x9031, 5)},
Signature · 1 line
2.28.0
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 12 lines · Filip Moc

LTE module MR400 embedded in TL-MR6400 v4 requires DTR to be set.

---
 drivers/net/usb/qmi_wwan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/usb/qmi_wwan.c +0 -0
index afeb09b9624e..d166c321ee9b 100644

drivers/net/usb/qmi_wwan.c static const struct usb_device_id products[] = { · line 1053

Quoted 8 lines
drivers/net/usb/qmi_wwan.c +1 -1
@@ -1047,7 +1047,7 @@ static const struct usb_device_id products[] = {
 	{QMI_FIXED_INTF(0x05c6, 0x9011, 4)},
 	{QMI_FIXED_INTF(0x05c6, 0x9021, 1)},
 	{QMI_FIXED_INTF(0x05c6, 0x9022, 2)},
-	{QMI_FIXED_INTF(0x05c6, 0x9025, 4)},	/* Alcatel-sbell ASB TL131 TDD LTE  (China Mobile) */
+	{QMI_QUIRK_SET_DTR(0x05c6, 0x9025, 4)},	/* Alcatel-sbell ASB TL131 TDD LTE (China Mobile) */
 	{QMI_FIXED_INTF(0x05c6, 0x9026, 3)},
 	{QMI_FIXED_INTF(0x05c6, 0x902e, 5)},
 	{QMI_FIXED_INTF(0x05c6, 0x9031, 5)},

This fix should probably go to net+stable.

Thanks,
Bjørn

maintainer
#2 lore raw
Quoted 25 lines · On Tue, 17 Nov 2020 20:22:03 +0100 Bjørn Mork wrote:
Quoted 12 lines · Filip Moc

LTE module MR400 embedded in TL-MR6400 v4 requires DTR to be set.

---
 drivers/net/usb/qmi_wwan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/usb/qmi_wwan.c +0 -0
index afeb09b9624e..d166c321ee9b 100644

drivers/net/usb/qmi_wwan.c static const struct usb_device_id products[] = { · line 1053

Quoted 8 lines
drivers/net/usb/qmi_wwan.c +1 -1
@@ -1047,7 +1047,7 @@ static const struct usb_device_id products[] = {
 	{QMI_FIXED_INTF(0x05c6, 0x9011, 4)},
 	{QMI_FIXED_INTF(0x05c6, 0x9021, 1)},
 	{QMI_FIXED_INTF(0x05c6, 0x9022, 2)},
-	{QMI_FIXED_INTF(0x05c6, 0x9025, 4)},	/* Alcatel-sbell ASB TL131 TDD LTE  (China Mobile) */
+	{QMI_QUIRK_SET_DTR(0x05c6, 0x9025, 4)},	/* Alcatel-sbell ASB TL131 TDD LTE (China Mobile) */
 	{QMI_FIXED_INTF(0x05c6, 0x9026, 3)},
 	{QMI_FIXED_INTF(0x05c6, 0x902e, 5)},
 	{QMI_FIXED_INTF(0x05c6, 0x9031, 5)},  
Quoted 1 line

This fix should probably go to net+stable.

Done, thanks!