drm/i915: Make define for lrc state offset
Subsystems (2)
PATCH 1/5 drm/i915: Make define for lrc state offset
More often than not, we need a byte offset into lrc register state from the start of the hw state. Make it so.
--- drivers/gpu/drm/i915/gt/intel_context_sseu.c | 3 +-- drivers/gpu/drm/i915/gt/intel_lrc.c | 8 ++++---- drivers/gpu/drm/i915/gt/intel_lrc.h | 1 + drivers/gpu/drm/i915/gt/selftest_lrc.c | 14 +++++++------- drivers/gpu/drm/i915/i915_perf.c | 2 +- 5 files changed, 14 insertions(+), 14 deletions(-)
drivers/gpu/drm/i915/gt/intel_context_sseu.c +1 -2
@@ -25,8 +25,7 @@ static int gen8_emit_rpcs_config(struct i915_request *rq,return PTR_ERR (cs); offset =i915_ggtt_offset (ce->state) + -LRC_STATE_PN *PAGE_SIZE + -CTX_R_PWR_CLK_STATE *4 ; +LRC_STATE_OFFSET +CTX_R_PWR_CLK_STATE *4 ; *cs++ =MI_STORE_DWORD_IMM_GEN4 |MI_USE_GGTT ; *cs++ =lower_32_bits (offset);
drivers/gpu/drm/i915/gt/intel_lrc.c +4 -4
@@ -1161,7 +1161,7 @@ static void restore_default_state(struct intel_context *ce,if (engine->pinned_default_state)memcpy (regs,/* skip restoring the vanilla PPHWSP */ - engine->pinned_default_state +LRC_STATE_PN *PAGE_SIZE , + engine->pinned_default_state +LRC_STATE_OFFSET , engine->context_size -PAGE_SIZE );execlists_init_reg_state (regs, ce, engine, ce->ring, false);
@@ -3136,7 +3136,7 @@ check_redzone(const void *vaddr, const struct intel_engine_cs *engine)static void execlists_context_unpin (struct intel_context *ce) { -check_redzone ((void *)ce->lrc_reg_state -LRC_STATE_PN *PAGE_SIZE , +check_redzone ((void *)ce->lrc_reg_state -LRC_STATE_OFFSET , ce->engine);i915_gem_object_unpin_map (ce->state->obj);
@@ -3183,7 +3183,7 @@ __execlists_context_pin(struct intel_context *ce,return PTR_ERR (vaddr); ce->lrc_desc =lrc_descriptor (ce, engine) |CTX_DESC_FORCE_RESTORE ; - ce->lrc_reg_state = vaddr +LRC_STATE_PN *PAGE_SIZE ; + ce->lrc_reg_state = vaddr +LRC_STATE_OFFSET ;__execlists_update_reg_state (ce, engine, ce->ring->tail);return 0 ;
@@ -4846,7 +4846,7 @@ populate_lr_context(struct intel_context *ce,* The second page of the context object contains some registers which * must be set up prior to the first execution. */ -execlists_init_reg_state (vaddr +LRC_STATE_PN *PAGE_SIZE , +execlists_init_reg_state (vaddr +LRC_STATE_OFFSET , ce, engine, ring, inhibit); ret =0 ;
drivers/gpu/drm/i915/gt/intel_lrc.h +1 -0
@@ -90,6 +90,7 @@ int intel_execlists_submission_setup(struct intel_engine_cs *engine);#define LRC_PPHWSP_SZ (1)/* After the PPHWSP we have the logical state for the context */ #define LRC_STATE_PN (LRC_PPHWSP_PN + LRC_PPHWSP_SZ) +#define LRC_STATE_OFFSET (LRC_STATE_PN * PAGE_SIZE)/* Space within PPHWSP reserved to be used as scratch */ #define LRC_PPHWSP_SCRATCH 0x34
drivers/gpu/drm/i915/gt/selftest_lrc.c +7 -7
@@ -4131,7 +4131,7 @@ static int live_lrc_layout(void *arg) err =PTR_ERR (hw);break ; } - hw +=LRC_STATE_PN *PAGE_SIZE /sizeof (*hw); + hw +=LRC_STATE_OFFSET /sizeof (*hw); execlists_init_reg_state(memset(lrc, POISON_INUSE, PAGE_SIZE), engine->kernel_context,
@@ -4284,7 +4284,7 @@ static int live_lrc_fixed(void *arg) err =PTR_ERR (hw);break ; } - hw +=LRC_STATE_PN *PAGE_SIZE /sizeof (*hw); + hw +=LRC_STATE_OFFSET /sizeof (*hw);for (t = tbl; t->name; t++) {int dw =find_offset (hw, t->reg);
@@ -4870,7 +4870,7 @@ store_context(struct intel_context *ce, struct i915_vma *scratch) x =0 ; dw =0 ; hw = ce->engine->pinned_default_state; - hw +=LRC_STATE_PN *PAGE_SIZE /sizeof (*hw); + hw +=LRC_STATE_OFFSET /sizeof (*hw); do { u32 len = hw[dw] & 0x7f;
@@ -5023,7 +5023,7 @@ static struct i915_vma *load_context(struct intel_context *ce, u32 poison) dw =0 ; hw = ce->engine->pinned_default_state; - hw +=LRC_STATE_PN *PAGE_SIZE /sizeof (*hw); + hw +=LRC_STATE_OFFSET /sizeof (*hw); do { u32 len = hw[dw] & 0x7f;
@@ -5147,12 +5147,12 @@ static int compare_isolation(struct intel_engine_cs *engine, err =PTR_ERR (lrc); goto err_B1; } - lrc +=LRC_STATE_PN *PAGE_SIZE /sizeof (*hw); + lrc +=LRC_STATE_OFFSET /sizeof (*hw); x =0 ; dw =0 ; hw = engine->pinned_default_state; - hw +=LRC_STATE_PN *PAGE_SIZE /sizeof (*hw); + hw +=LRC_STATE_OFFSET /sizeof (*hw); do { u32 len = hw[dw] & 0x7f;
@@ -5394,7 +5394,7 @@ static struct i915_request *garbage(struct intel_context *ce,prandom_bytes_state (prng, ce->lrc_reg_state, ce->engine->context_size - -LRC_STATE_PN *PAGE_SIZE ); +LRC_STATE_OFFSET ); rq =intel_context_create_request (ce);if (IS_ERR (rq)) {
drivers/gpu/drm/i915/i915_perf.c +1 -1
@@ -2098,7 +2098,7 @@ gen8_store_flex(struct i915_request *rq,if (IS_ERR (cs))return PTR_ERR (cs); - offset =i915_ggtt_offset (ce->state) +LRC_STATE_PN *PAGE_SIZE ; + offset =i915_ggtt_offset (ce->state) +LRC_STATE_OFFSET ; do { *cs++ = MI_STORE_DWORD_IMM_GEN4 | MI_USE_GGTT; *cs++ = offset + flex->offset * sizeof(u32);
Signature · 6 lines
2.17.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/5 drm/i915: Add per ctx batchbuffer wa for timestamp
Restoration of a previous timestamp can collide with updating the timestamp, causing a value corruption.
Combat this issue by using indirect ctx bb to modify the context image during restoring process.
For render engine, we can preload value into scratch register. From which we then do the actual write with LRR. LRR is faster and thus less error prone. For other engines, no scratch is available so we must do a more complex sequence of sync and async LRMs. As the LRM is slower, the probablity of racy write raises and thus we still see corruption sometimes.
v2: tidying (Chris)
References: HSDES#16010904313
Testcase: igt/i915_selftest/gt_lrc
--- drivers/gpu/drm/i915/gt/intel_context_types.h | 3 + drivers/gpu/drm/i915/gt/intel_gpu_commands.h | 3 +- drivers/gpu/drm/i915/gt/intel_lrc.c | 205 ++++++++++++++---- drivers/gpu/drm/i915/gt/intel_lrc_reg.h | 1 + 4 files changed, 174 insertions(+), 38 deletions(-)
drivers/gpu/drm/i915/gt/intel_context_types.h +3 -0
@@ -70,6 +70,9 @@ struct intel_context {u32 *lrc_reg_state;u64 lrc_desc; + +u32 ctx_bb_offset; +u32 tag;/* cookie passed to HW to track this context on submission */ /* Time on GPU as tracked by the hw. */
drivers/gpu/drm/i915/gt/intel_gpu_commands.h +2 -1
@@ -138,7 +138,7 @@*/ #define MI_LOAD_REGISTER_IMM (x) MI_INSTR(0x22, 2*(x)-1)/* Gen11+. addr = base + (ctx_restore ? offset & GENMASK(12,2) : offset) */ -#define MI_LRI_CS_MMIO (1<<19) +#define MI_LRI_LRM_CS_MMIO (1<<19)#define MI_LRI_FORCE_POSTED (1<<12)#define MI_LOAD_REGISTER_IMM_MAX_REGS (126)#define MI_STORE_REGISTER_MEM MI_INSTR(0x24, 1)
@@ -155,6 +155,7 @@#define MI_FLUSH_DW_USE_PPGTT (0<<2)#define MI_LOAD_REGISTER_MEM MI_INSTR(0x29, 1)#define MI_LOAD_REGISTER_MEM_GEN8 MI_INSTR(0x29, 2) +#define MI_LRM_ASYNC (1<<21)#define MI_LOAD_REGISTER_REG MI_INSTR(0x2A, 1)#define MI_BATCH_BUFFER MI_INSTR(0x30, 1)#define MI_BATCH_NON_SECURE (1)
drivers/gpu/drm/i915/gt/intel_lrc.c +168 -37
242 lines not on this page · raw message
drivers/gpu/drm/i915/gt/intel_lrc_reg.h +1 -0
@@ -32,6 +32,7 @@/* GEN12+ Reg State Context */ #define GEN12_CTX_BB_PER_CTX_PTR (0x12 + 1) +#define CTX_BB_PER_CTX_PTR_VALID BIT(0)#define ASSIGN_CTX_PDP (ppgtt, reg_state, n) do { \ u32 *reg_state__ = (reg_state); \
Signature · 6 lines
2.17.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 2/5] drm/i915: Add per ctx batchbuffer wa for timestamp
Quoting Mika Kuoppala (2020-04-21 14:16:30)
Quoted 14 lines
Restoration of a previous timestamp can collide with updating the timestamp, causing a value corruption.
Combat this issue by using indirect ctx bb to modify the context image during restoring process.
For render engine, we can preload value into scratch register. From which we then do the actual write with LRR. LRR is faster and thus less error prone. For other engines, no scratch is available so we must do a more complex sequence of sync and async LRMs. As the LRM is slower, the probablity of racy write raises and thus we still see corruption sometimes.
Quoted 7 lines
v2: tidying (Chris)
References: HSDES#16010904313
Testcase: igt/i915_selftest/gt_lrcSuggested-by Joseph Koston <[email protected]>Cc Chris Wilson <[email protected]>Signed-off-by Mika Kuoppala <[email protected]>
It's antagonising checkpatch for no good reason.
The only thing we have no feeling for is the impact of using this mechanism on context switch times.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
kbuild test robot
build botRe: [Intel-gfx] [PATCH 2/5] drm/i915: Add per ctx batchbuffer wa for timestamp
In reply to Mika KuoppalaThank you for the patch! Yet something to improve:
Hi Mika,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip v5.7-rc2 next-20200423] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Mika-Kuoppala/drm-i915-Make-define-for-lrc-state-offset/20200423-064959 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: i386-randconfig-f003-20200421 (attached as .config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 reproduce: # save the attached .config to linux build tree make ARCH=i386
If you fix the issue, kindly add following tag as appropriate
All errors (new ones prefixed by >>):
drivers/gpu/drm/i915/gt/intel_lrc.c: In function 'execlists_emit_ctx_bb':
>> drivers/gpu/drm/i915/gt/intel_lrc.c:3251:20: error: unused variable 'batch_start' [-Werror=unused-variable]
const u32 * const batch_start = cs;
^~~~~~~~~~~cc1: all warnings being treated as errors
vim +/batch_start +3251 drivers/gpu/drm/i915/gt/intel_lrc.c
3245
3246 static u32 *
3247 execlists_emit_ctx_bb(struct intel_context *ce,
3248 u32 *(*emit)(struct intel_context *, u32 *))
3249 {
3250 u32 *cs = context_indirect_bb(ce);
> 3251 const u32 * const batch_start = cs;
3252
3253 cs = emit(ce, cs);
3254
3255 GEM_DEBUG_BUG_ON(cs - batch_start >
3256 (I915_GTT_PAGE_SIZE - 4)/sizeof(*cs));
3257
3258 return cs;
3259 }
3260
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
PATCH 3/5 drm/i915: Add live selftests for indirect ctx batchbuffers
In reply to Mika KuoppalaIndirect ctx batchbuffers are a hw feature of which batch can be run, by hardware, during context restoration stage. Driver can setup a batchbuffer and also an offset into the context image. When context image is marshalled from memory to registers, and when the offset from the start of context register state is equal of what driver pre-determined, batch will run. So one can manipulate context restoration process at any granularity of one lri, given some limitations, as you need to have rudimentaries in place before you can run a batch.
Add selftest which will write the ring start register to a canary spot. This will test that hardware will run a batchbuffer for the context in question.
--- drivers/gpu/drm/i915/gt/selftest_lrc.c | 156 ++++++++++++++++++++++++- 1 file changed, 155 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/gt/selftest_lrc.c +155 -1
@@ -5363,6 +5363,159 @@ static int live_lrc_isolation(void *arg)return err; } +static int ctx_bb_submit_req (struct intel_context *ce) +{ +struct i915_request *rq; +int err; + + rq =intel_context_create_request (ce); +if (IS_ERR (rq)) +return PTR_ERR (rq); + +i915_request_get (rq); +i915_request_add (rq); + + err =i915_request_wait (rq,0 ,HZ /5 ); +if (err <0 ) +pr_err ("%s: request not completed!\n" , rq->engine->name); + +i915_request_put (rq); + +return 0 ; +} + +#define CTX_BB_CANARY_OFFSET (3*1024) +#define CTX_BB_CANARY_INDEX (CTX_BB_CANARY_OFFSET/sizeof(u32)) + +static u32 * +emit_ctx_bb_canary (struct intel_context *ce,u32 *cs) +{ +const u32 ring_start_reg =i915_mmio_reg_offset (RING_START (0 )); +const u32 srm =MI_STORE_REGISTER_MEM_GEN8 | +MI_SRM_LRM_GLOBAL_GTT |MI_LRI_LRM_CS_MMIO ; + + *cs++ = srm; + *cs++ = ring_start_reg; + *cs++ =i915_ggtt_offset (ce->state) + + ce->ctx_bb_offset +CTX_BB_CANARY_OFFSET ; + *cs++ =0 ; + +return cs; +} + +static void +ctx_bb_setup (struct intel_context *ce) +{ +u32 *cs =context_indirect_bb (ce); + + cs[CTX_BB_CANARY_INDEX ] =0xdeadf00d ; + +setup_indirect_ctx_bb (ce, emit_ctx_bb_canary); +} + +static bool check_ring_start (struct intel_context *ce) +{ +const u32 *const ctx_bb = (void *)(ce->lrc_reg_state) - +LRC_STATE_PN *PAGE_SIZE + ce->ctx_bb_offset; + +if (ctx_bb[CTX_BB_CANARY_INDEX ] == ce->lrc_reg_state[CTX_RING_START ]) +return true; + +pr_err ("ring start mismatch: canary 0x%08x vs state 0x%08x\n" , + ctx_bb[CTX_BB_CANARY_INDEX ], + ce->lrc_reg_state[CTX_RING_START ]); + +return false; +} + +static int ctx_bb_check (struct intel_context *ce) +{ +int err; + + err =ctx_bb_submit_req (ce); +if (err) +return err; + +if (!check_ring_start (ce)) +return -EINVAL ; + +return 0 ; +} + +static int __per_ctx_bb (struct intel_engine_cs *engine) +{ +struct intel_context *ce1, *ce2; +int err =0 ; + + ce1 =intel_context_create (engine); + ce2 =intel_context_create (engine); + + err =intel_context_pin (ce1); +if (err) +return err; + + err =intel_context_pin (ce2); +if (err) { +intel_context_put (ce1); +return err; + } + +/* We use the already reserved extra page in context state */ +if (!ce1->ctx_bb_offset) { +GEM_BUG_ON (ce2->ctx_bb_offset); +GEM_BUG_ON (INTEL_GEN (engine->i915) ==12 ); + goto out; + } + +/* In order to test that our per context bb is truly per context, +* and executes at the intended spot on context restoring process, +* make the batch store the ring start value to memory. +* As ring start is restored apriori of starting the indirect ctx bb and +* as it will be different for each context, it fits to this purpose. +*/ +ctx_bb_setup (ce1); +ctx_bb_setup (ce2); + + err =ctx_bb_check (ce1); +if (err) + goto out; + + err =ctx_bb_check (ce2); +out: +intel_context_unpin (ce2); +intel_context_put (ce2); + +intel_context_unpin (ce1); +intel_context_put (ce1); + +return err; +} + +static int live_lrc_indirect_ctx_bb (void *arg) +{ +struct intel_gt *gt = arg; +struct intel_engine_cs *engine; +enum intel_engine_id id; +int err =0 ; + +for_each_engine (engine, gt, id) { + +intel_engine_pm_get (engine); + err =__per_ctx_bb (engine); +intel_engine_pm_put (engine); + +if (err) +break ; + +if (igt_flush_test (gt->i915)) { + err = -EIO ; +break ; + } + } + +return err; +} +static void garbage_reset (struct intel_engine_cs *engine,struct i915_request *rq) {
@@ -5594,10 +5747,11 @@ int intel_lrc_live_selftests(struct drm_i915_private *i915)SUBTEST (live_lrc_fixed),SUBTEST (live_lrc_state),SUBTEST (live_lrc_gpr), -SUBTEST (live_lrc_isolation), +SUBTEST (live_lrc_indirect_ctx_bb),SUBTEST (live_lrc_timestamp),SUBTEST (live_lrc_garbage),SUBTEST (live_pphwsp_runtime), + SUBTEST(live_lrc_isolation), };if (!HAS_LOGICAL_RING_CONTEXTS (i915))
Signature · 6 lines
2.17.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 3/5] drm/i915: Add live selftests for indirect ctx batchbuffers
Quoted 8 lines · Mika Kuoppala
Indirect ctx batchbuffers are a hw feature of which batch can be run, by hardware, during context restoration stage. Driver can setup a batchbuffer and also an offset into the context image. When context image is marshalled from memory to registers, and when the offset from the start of context register state is equal of what driver pre-determined, batch will run. So one can manipulate context restoration process at any granularity of one lri, given some
This is wrong, it is granularity of cacheline.
-Mika
Quoted 191 lines
limitations, as you need to have rudimentaries in place before you can run a batch.
Add selftest which will write the ring start register to a canary spot. This will test that hardware will run a batchbuffer for the context in question.
Signed-off-by Mika Kuoppala <[email protected]>--- drivers/gpu/drm/i915/gt/selftest_lrc.c | 156 ++++++++++++++++++++++++- 1 file changed, 155 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/gt/selftest_lrc.c +155
-1@@ -5363,6 +5363,159 @@ static int live_lrc_isolation(void *arg)return err; } +static int ctx_bb_submit_req (struct intel_context *ce) +{ +struct i915_request *rq; +int err; + + rq =intel_context_create_request (ce); +if (IS_ERR (rq)) +return PTR_ERR (rq); + +i915_request_get (rq); +i915_request_add (rq); + + err =i915_request_wait (rq,0 ,HZ /5 ); +if (err <0 ) +pr_err ("%s: request not completed!\n" , rq->engine->name); + +i915_request_put (rq); + +return 0 ; +} + +#define CTX_BB_CANARY_OFFSET (3*1024) +#define CTX_BB_CANARY_INDEX (CTX_BB_CANARY_OFFSET/sizeof(u32)) + +static u32 * +emit_ctx_bb_canary (struct intel_context *ce,u32 *cs) +{ +const u32 ring_start_reg =i915_mmio_reg_offset (RING_START (0 )); +const u32 srm =MI_STORE_REGISTER_MEM_GEN8 | +MI_SRM_LRM_GLOBAL_GTT |MI_LRI_LRM_CS_MMIO ; + + *cs++ = srm; + *cs++ = ring_start_reg; + *cs++ =i915_ggtt_offset (ce->state) + + ce->ctx_bb_offset +CTX_BB_CANARY_OFFSET ; + *cs++ =0 ; + +return cs; +} + +static void +ctx_bb_setup (struct intel_context *ce) +{ +u32 *cs =context_indirect_bb (ce); + + cs[CTX_BB_CANARY_INDEX ] =0xdeadf00d ; + +setup_indirect_ctx_bb (ce, emit_ctx_bb_canary); +} + +static bool check_ring_start (struct intel_context *ce) +{ +const u32 *const ctx_bb = (void *)(ce->lrc_reg_state) - +LRC_STATE_PN *PAGE_SIZE + ce->ctx_bb_offset; + +if (ctx_bb[CTX_BB_CANARY_INDEX ] == ce->lrc_reg_state[CTX_RING_START ]) +return true; + +pr_err ("ring start mismatch: canary 0x%08x vs state 0x%08x\n" , + ctx_bb[CTX_BB_CANARY_INDEX ], + ce->lrc_reg_state[CTX_RING_START ]); + +return false; +} + +static int ctx_bb_check (struct intel_context *ce) +{ +int err; + + err =ctx_bb_submit_req (ce); +if (err) +return err; + +if (!check_ring_start (ce)) +return -EINVAL ; + +return 0 ; +} + +static int __per_ctx_bb (struct intel_engine_cs *engine) +{ +struct intel_context *ce1, *ce2; +int err =0 ; + + ce1 =intel_context_create (engine); + ce2 =intel_context_create (engine); + + err =intel_context_pin (ce1); +if (err) +return err; + + err =intel_context_pin (ce2); +if (err) { +intel_context_put (ce1); +return err; + } + +/* We use the already reserved extra page in context state */ +if (!ce1->ctx_bb_offset) { +GEM_BUG_ON (ce2->ctx_bb_offset); +GEM_BUG_ON (INTEL_GEN (engine->i915) ==12 ); + goto out; + } + +/* In order to test that our per context bb is truly per context, +* and executes at the intended spot on context restoring process, +* make the batch store the ring start value to memory. +* As ring start is restored apriori of starting the indirect ctx bb and +* as it will be different for each context, it fits to this purpose. +*/ +ctx_bb_setup (ce1); +ctx_bb_setup (ce2); + + err =ctx_bb_check (ce1); +if (err) + goto out; + + err =ctx_bb_check (ce2); +out: +intel_context_unpin (ce2); +intel_context_put (ce2); + +intel_context_unpin (ce1); +intel_context_put (ce1); + +return err; +} + +static int live_lrc_indirect_ctx_bb (void *arg) +{ +struct intel_gt *gt = arg; +struct intel_engine_cs *engine; +enum intel_engine_id id; +int err =0 ; + +for_each_engine (engine, gt, id) { + +intel_engine_pm_get (engine); + err =__per_ctx_bb (engine); +intel_engine_pm_put (engine); + +if (err) +break ; + +if (igt_flush_test (gt->i915)) { + err = -EIO ; +break ; + } + } + +return err; +} +static void garbage_reset (struct intel_engine_cs *engine,struct i915_request *rq) {@@ -5594,10 +5747,11 @@ int intel_lrc_live_selftests(struct drm_i915_private *i915)SUBTEST (live_lrc_fixed),SUBTEST (live_lrc_state),SUBTEST (live_lrc_gpr), -SUBTEST (live_lrc_isolation), +SUBTEST (live_lrc_indirect_ctx_bb),SUBTEST (live_lrc_timestamp),SUBTEST (live_lrc_garbage),SUBTEST (live_pphwsp_runtime), + SUBTEST(live_lrc_isolation), };if (!HAS_LOGICAL_RING_CONTEXTS (i915))Signature · 1 line
2.17.1
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 3/5] drm/i915: Add live selftests for indirect ctx batchbuffers
In reply to Mika KuoppalaQuoting Mika Kuoppala (2020-04-21 14:16:31)
Quoted 37 lines
Indirect ctx batchbuffers are a hw feature of which batch can be run, by hardware, during context restoration stage. Driver can setup a batchbuffer and also an offset into the context image. When context image is marshalled from memory to registers, and when the offset from the start of context register state is equal of what driver pre-determined, batch will run. So one can manipulate context restoration process at any granularity of one lri, given some limitations, as you need to have rudimentaries in place before you can run a batch.
Add selftest which will write the ring start register to a canary spot. This will test that hardware will run a batchbuffer for the context in question.
Signed-off-by Mika Kuoppala <[email protected]>--- drivers/gpu/drm/i915/gt/selftest_lrc.c | 156 ++++++++++++++++++++++++- 1 file changed, 155 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/gt/selftest_lrc.c +9
-0@@ -5363,6 +5363,159 @@ static int live_lrc_isolation(void *arg)return err; } +static int ctx_bb_submit_req (struct intel_context *ce) +{ +struct i915_request *rq; +int err; + + rq =intel_context_create_request (ce); +if (IS_ERR (rq)) +return PTR_ERR (rq); +
drivers/gpu/drm/i915/gt/selftest_lrc.c static int live_lrc_isolation(void *arg) · line 5384
Quoted 10 lines
drivers/gpu/drm/i915/gt/selftest_lrc.c +10
-0+i915_request_get (rq); +i915_request_add (rq); + + err =i915_request_wait (rq,0 ,HZ /5 ); +if (err <0 ) +pr_err ("%s: request not completed!\n" , rq->engine->name); + +i915_request_put (rq); + +return 0 ;
if (i915_request_wait() < 0)
err = -ETIME;
return err;
Quoted 25 lines
drivers/gpu/drm/i915/gt/selftest_lrc.c +25
-0+} + +#define CTX_BB_CANARY_OFFSET (3*1024) +#define CTX_BB_CANARY_INDEX (CTX_BB_CANARY_OFFSET/sizeof(u32)) + +static u32 * +emit_ctx_bb_canary (struct intel_context *ce,u32 *cs) +{ +const u32 ring_start_reg =i915_mmio_reg_offset (RING_START (0 )); +const u32 srm =MI_STORE_REGISTER_MEM_GEN8 | +MI_SRM_LRM_GLOBAL_GTT |MI_LRI_LRM_CS_MMIO ; + + *cs++ = srm; + *cs++ = ring_start_reg; + *cs++ =i915_ggtt_offset (ce->state) + + ce->ctx_bb_offset +CTX_BB_CANARY_OFFSET ; + *cs++ =0 ; + +return cs; +} + +static void +ctx_bb_setup (struct intel_context *ce) +{ +u32 *cs =context_indirect_bb (ce);
drivers/gpu/drm/i915/gt/selftest_lrc.c static int live_lrc_isolation(void *arg) · line 5419
Quoted 10 lines
drivers/gpu/drm/i915/gt/selftest_lrc.c +10
-0+ + cs[CTX_BB_CANARY_INDEX ] =0xdeadf00d ; + +setup_indirect_ctx_bb (ce, emit_ctx_bb_canary); +} + +static bool check_ring_start (struct intel_context *ce) +{ +const u32 *const ctx_bb = (void *)(ce->lrc_reg_state) - +LRC_STATE_PN *PAGE_SIZE + ce->ctx_bb_offset;
_OFFSET or did this get updated?
Quoted 18 lines
drivers/gpu/drm/i915/gt/selftest_lrc.c +18
-0+ +if (ctx_bb[CTX_BB_CANARY_INDEX ] == ce->lrc_reg_state[CTX_RING_START ]) +return true; + +pr_err ("ring start mismatch: canary 0x%08x vs state 0x%08x\n" , + ctx_bb[CTX_BB_CANARY_INDEX ], + ce->lrc_reg_state[CTX_RING_START ]); + +return false; +} + +static int ctx_bb_check (struct intel_context *ce) +{ +int err; + + err =ctx_bb_submit_req (ce); +if (err) +return err;
drivers/gpu/drm/i915/gt/selftest_lrc.c static int live_lrc_isolation(void *arg) · line 5447
Quoted 10 lines
drivers/gpu/drm/i915/gt/selftest_lrc.c +10
-0+ +if (!check_ring_start (ce)) +return -EINVAL ; + +return 0 ; +} + +static int __per_ctx_bb (struct intel_engine_cs *engine) +{ +struct intel_context *ce1, *ce2;
I'd vote for a, b; a greater %% of unique characters for ease of the reader.
Quoted 56 lines
drivers/gpu/drm/i915/gt/selftest_lrc.c +56
-0+int err =0 ; + + ce1 =intel_context_create (engine); + ce2 =intel_context_create (engine); + + err =intel_context_pin (ce1); +if (err) +return err; + + err =intel_context_pin (ce2); +if (err) { +intel_context_put (ce1); +return err; + } + +/* We use the already reserved extra page in context state */ +if (!ce1->ctx_bb_offset) { +GEM_BUG_ON (ce2->ctx_bb_offset); +GEM_BUG_ON (INTEL_GEN (engine->i915) ==12 ); + goto out; + } + +/* In order to test that our per context bb is truly per context, +* and executes at the intended spot on context restoring process, +* make the batch store the ring start value to memory. +* As ring start is restored apriori of starting the indirect ctx bb and +* as it will be different for each context, it fits to this purpose. +*/ +ctx_bb_setup (ce1); +ctx_bb_setup (ce2); + + err =ctx_bb_check (ce1); +if (err) + goto out; + + err =ctx_bb_check (ce2); +out: +intel_context_unpin (ce2); +intel_context_put (ce2); + +intel_context_unpin (ce1); +intel_context_put (ce1); + +return err; +} + +static int live_lrc_indirect_ctx_bb (void *arg) +{ +struct intel_gt *gt = arg; +struct intel_engine_cs *engine; +enum intel_engine_id id; +int err =0 ; + +for_each_engine (engine, gt, id) { + +intel_engine_pm_get (engine);
drivers/gpu/drm/i915/gt/selftest_lrc.c static int live_lrc_isolation(void *arg) · line 5513
Quoted 10 lines
drivers/gpu/drm/i915/gt/selftest_lrc.c +10
-0+ err =__per_ctx_bb (engine); +intel_engine_pm_put (engine); + +if (err) +break ; + +if (igt_flush_test (gt->i915)) { + err = -EIO ; +break ; + }
for_each_engine() {
intel_engine_pm_get()
err = __per_ctx_bb();
intel_engine_pm_put();
if (igt_flush_test())
err = -EIO;
if (err)
break;__per_ctx_bb is a bit confusing, no?
Should it be __live_lrc_indirect_ctx_bb or __lrc_indirect_ctx_bb? -Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 3/5] drm/i915: Add live selftests for indirect ctx batchbuffers
Quoted 201 lines · Chris Wilson
Quoting Mika Kuoppala (2020-04-21 14:16:31)
Quoted 37 lines
Indirect ctx batchbuffers are a hw feature of which batch can be run, by hardware, during context restoration stage. Driver can setup a batchbuffer and also an offset into the context image. When context image is marshalled from memory to registers, and when the offset from the start of context register state is equal of what driver pre-determined, batch will run. So one can manipulate context restoration process at any granularity of one lri, given some limitations, as you need to have rudimentaries in place before you can run a batch.
Add selftest which will write the ring start register to a canary spot. This will test that hardware will run a batchbuffer for the context in question.
Signed-off-by Mika Kuoppala <[email protected]>--- drivers/gpu/drm/i915/gt/selftest_lrc.c | 156 ++++++++++++++++++++++++- 1 file changed, 155 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/gt/selftest_lrc.c +9
-0@@ -5363,6 +5363,159 @@ static int live_lrc_isolation(void *arg)return err; } +static int ctx_bb_submit_req (struct intel_context *ce) +{ +struct i915_request *rq; +int err; + + rq =intel_context_create_request (ce); +if (IS_ERR (rq)) +return PTR_ERR (rq); +drivers/gpu/drm/i915/gt/selftest_lrc.c static int live_lrc_isolation(void *arg) · line 5384
Quoted 10 lines
drivers/gpu/drm/i915/gt/selftest_lrc.c +10
-0+i915_request_get (rq); +i915_request_add (rq); + + err =i915_request_wait (rq,0 ,HZ /5 ); +if (err <0 ) +pr_err ("%s: request not completed!\n" , rq->engine->name); + +i915_request_put (rq); + +return 0 ;if (
i915_request_wait()< 0)err = -ETIME;return err;
Quoted 25 lines
drivers/gpu/drm/i915/gt/selftest_lrc.c +25
-0+} + +#define CTX_BB_CANARY_OFFSET (3*1024) +#define CTX_BB_CANARY_INDEX (CTX_BB_CANARY_OFFSET/sizeof(u32)) + +static u32 * +emit_ctx_bb_canary (struct intel_context *ce,u32 *cs) +{ +const u32 ring_start_reg =i915_mmio_reg_offset (RING_START (0 )); +const u32 srm =MI_STORE_REGISTER_MEM_GEN8 | +MI_SRM_LRM_GLOBAL_GTT |MI_LRI_LRM_CS_MMIO ; + + *cs++ = srm; + *cs++ = ring_start_reg; + *cs++ =i915_ggtt_offset (ce->state) + + ce->ctx_bb_offset +CTX_BB_CANARY_OFFSET ; + *cs++ =0 ; + +return cs; +} + +static void +ctx_bb_setup (struct intel_context *ce) +{ +u32 *cs =context_indirect_bb (ce);drivers/gpu/drm/i915/gt/selftest_lrc.c static int live_lrc_isolation(void *arg) · line 5419
Quoted 10 lines
drivers/gpu/drm/i915/gt/selftest_lrc.c +10
-0+ + cs[CTX_BB_CANARY_INDEX ] =0xdeadf00d ; + +setup_indirect_ctx_bb (ce, emit_ctx_bb_canary); +} + +static bool check_ring_start (struct intel_context *ce) +{ +const u32 *const ctx_bb = (void *)(ce->lrc_reg_state) - +LRC_STATE_PN *PAGE_SIZE + ce->ctx_bb_offset;
_OFFSETor did this get updated?Quoted 18 lines
drivers/gpu/drm/i915/gt/selftest_lrc.c +18
-0+ +if (ctx_bb[CTX_BB_CANARY_INDEX ] == ce->lrc_reg_state[CTX_RING_START ]) +return true; + +pr_err ("ring start mismatch: canary 0x%08x vs state 0x%08x\n" , + ctx_bb[CTX_BB_CANARY_INDEX ], + ce->lrc_reg_state[CTX_RING_START ]); + +return false; +} + +static int ctx_bb_check (struct intel_context *ce) +{ +int err; + + err =ctx_bb_submit_req (ce); +if (err) +return err;drivers/gpu/drm/i915/gt/selftest_lrc.c static int live_lrc_isolation(void *arg) · line 5447
Quoted 10 lines
drivers/gpu/drm/i915/gt/selftest_lrc.c +10
-0+ +if (!check_ring_start (ce)) +return -EINVAL ; + +return 0 ; +} + +static int __per_ctx_bb (struct intel_engine_cs *engine) +{ +struct intel_context *ce1, *ce2;I'd vote for a, b; a greater %% of unique characters for ease of the reader.
Quoted 56 lines
drivers/gpu/drm/i915/gt/selftest_lrc.c +56
-0+int err =0 ; + + ce1 =intel_context_create (engine); + ce2 =intel_context_create (engine); + + err =intel_context_pin (ce1); +if (err) +return err; + + err =intel_context_pin (ce2); +if (err) { +intel_context_put (ce1); +return err; + } + +/* We use the already reserved extra page in context state */ +if (!ce1->ctx_bb_offset) { +GEM_BUG_ON (ce2->ctx_bb_offset); +GEM_BUG_ON (INTEL_GEN (engine->i915) ==12 ); + goto out; + } + +/* In order to test that our per context bb is truly per context, +* and executes at the intended spot on context restoring process, +* make the batch store the ring start value to memory. +* As ring start is restored apriori of starting the indirect ctx bb and +* as it will be different for each context, it fits to this purpose. +*/ +ctx_bb_setup (ce1); +ctx_bb_setup (ce2); + + err =ctx_bb_check (ce1); +if (err) + goto out; + + err =ctx_bb_check (ce2); +out: +intel_context_unpin (ce2); +intel_context_put (ce2); + +intel_context_unpin (ce1); +intel_context_put (ce1); + +return err; +} + +static int live_lrc_indirect_ctx_bb (void *arg) +{ +struct intel_gt *gt = arg; +struct intel_engine_cs *engine; +enum intel_engine_id id; +int err =0 ; + +for_each_engine (engine, gt, id) { + +intel_engine_pm_get (engine);drivers/gpu/drm/i915/gt/selftest_lrc.c static int live_lrc_isolation(void *arg) · line 5513
Quoted 10 lines
drivers/gpu/drm/i915/gt/selftest_lrc.c +10
-0+ err =__per_ctx_bb (engine); +intel_engine_pm_put (engine); + +if (err) +break ; + +if (igt_flush_test (gt->i915)) { + err = -EIO ; +break ; + }for_each_engine() { intel_engine_pm_get() err = __per_ctx_bb(); intel_engine_pm_put(); if (igt_flush_test()) err = -EIO; if (err) break;
Quoted 1 line
__per_ctx_bbis a bit confusing, no?
It is, remnants of when this test did both indirect and per ctx. But that is for future work if we ever need it.
Quoted 2 lines
Should it be
__live_lrc_indirect_ctx_bbor__lrc_indirect_ctx_bb?
Both are better, I will try to see what fits.
-Mika
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 4/5 drm/i915: Use indirect ctx bb to mend CMD_BUF_CCTL
In reply to Mika KuoppalaUse indirect ctx bb to load cmd buffer control value from context image to avoid corruption.
v2: add to lrc layout (Chris)
Testcase: igt/i915_selftest/gt_lrc
--- drivers/gpu/drm/i915/gt/intel_lrc.c | 73 +++++++++++++++++++++++-- drivers/gpu/drm/i915/gt/intel_lrc_reg.h | 1 + drivers/gpu/drm/i915/i915_reg.h | 1 + 3 files changed, 71 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/gt/intel_lrc.c +69 -4
@@ -514,7 +514,7 @@ static void set_offsets(u32 *regs,#define REG16 (x) \ (((x) >> 9) | BIT(7) | BUILD_BUG_ON_ZERO(x >= 0x10000)), \ (((x) >> 2) & 0x7f) -#define END (x) 0, (x) +#define END (total_state_size) 0, (total_state_size) {const u32 base = engine->mmio_base;
@@ -922,8 +922,63 @@ static const u8 gen12_rcs_offsets[] = {NOP (6 ),LRI (1 ,0 ),REG (0x0c8 ), +NOP (3 +9 +1 ), + +LRI (51 ,POSTED ), +REG16 (0x588 ), +REG16 (0x588 ), +REG16 (0x588 ), +REG16 (0x588 ), +REG16 (0x588 ), +REG16 (0x588 ), +REG (0x028 ), +REG (0x09c ), +REG (0x0c0 ), +REG (0x178 ), +REG (0x17c ), +REG16 (0x358 ), +REG (0x170 ), +REG (0x150 ), +REG (0x154 ), +REG (0x158 ), +REG16 (0x41c ), +REG16 (0x600 ), +REG16 (0x604 ), +REG16 (0x608 ), +REG16 (0x60c ), +REG16 (0x610 ), +REG16 (0x614 ), +REG16 (0x618 ), +REG16 (0x61c ), +REG16 (0x620 ), +REG16 (0x624 ), +REG16 (0x628 ), +REG16 (0x62c ), +REG16 (0x630 ), +REG16 (0x634 ), +REG16 (0x638 ), +REG16 (0x63c ), +REG16 (0x640 ), +REG16 (0x644 ), +REG16 (0x648 ), +REG16 (0x64c ), +REG16 (0x650 ), +REG16 (0x654 ), +REG16 (0x658 ), +REG16 (0x65c ), +REG16 (0x660 ), +REG16 (0x664 ), +REG16 (0x668 ), +REG16 (0x66c ), +REG16 (0x670 ), +REG16 (0x674 ), +REG16 (0x678 ), +REG16 (0x67c ), +REG (0x068 ), +REG (0x084 ), +NOP (1 ), - END(80) +END (185 ) };#undef END
@@ -3207,7 +3262,7 @@ gen12_emit_timestamp_wa_lrm(struct intel_context *ce, u32 *cs) }static u32 * -gen12_emit_timestamp_wa_lrr (struct intel_context *ce,u32 *cs) +gen12_emit_render_ctx_wa (struct intel_context *ce,u32 *cs) {const u32 lrc_offset =i915_ggtt_offset (ce->state) +LRC_STATE_OFFSET ;
@@ -3227,6 +3282,16 @@ gen12_emit_timestamp_wa_lrr(struct intel_context *ce, u32 *cs) *cs++ = scratch_reg; *cs++ =i915_mmio_reg_offset (RING_CTX_TIMESTAMP (0 )); + *cs++ =MI_LOAD_REGISTER_MEM_GEN8 | +MI_SRM_LRM_GLOBAL_GTT |MI_LRI_LRM_CS_MMIO ; + *cs++ = scratch_reg; + *cs++ = lrc_offset +CTX_CMD_BUF_CCTL *sizeof (u32); + *cs++ =0 ; + + *cs++ =MI_LOAD_REGISTER_REG |MI_LRI_LRM_CS_MMIO ; + *cs++ = scratch_reg; + *cs++ =i915_mmio_reg_offset (RING_CMD_BUF_CCTL (0 )); +return cs; }
@@ -3290,7 +3355,7 @@ gen12_setup_timestamp_ctx_wa(struct intel_context *ce) fn = gen12_emit_timestamp_wa_lrm;if (ce->engine->class ==RENDER_CLASS ) - fn = gen12_emit_timestamp_wa_lrr; + fn = gen12_emit_render_ctx_wa;setup_indirect_ctx_bb (ce, fn); }
drivers/gpu/drm/i915/gt/intel_lrc_reg.h +1 -0
@@ -27,6 +27,7 @@#define CTX_PDP0_UDW (0x30 + 1)#define CTX_PDP0_LDW (0x32 + 1)#define CTX_R_PWR_CLK_STATE (0x42 + 1) +#define CTX_CMD_BUF_CCTL (0xB6 + 1)#define GEN9_CTX_RING_MI_MODE 0x54
drivers/gpu/drm/i915/i915_reg.h +1 -0
@@ -2657,6 +2657,7 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)#define RING_DMA_FADD_UDW (base) _MMIO((base) + 0x60)/* gen8+ */ #define RING_INSTPM (base) _MMIO((base) + 0xc0)#define RING_MI_MODE (base) _MMIO((base) + 0x9c) +#define RING_CMD_BUF_CCTL (base) _MMIO((base) + 0x84)#define INSTPS _MMIO(0x2070)/* 965+ only */ #define GEN4_INSTDONE1 _MMIO(0x207c)/* 965+ only, aka INSTDONE_2 on SNB */ #define ACTHD_I965 _MMIO(0x2074)
Signature · 6 lines
2.17.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 4/5] drm/i915: Use indirect ctx bb to mend CMD_BUF_CCTL
Quoting Mika Kuoppala (2020-04-21 14:16:32)
drivers/gpu/drm/i915/gt/intel_lrc.c static const u8 gen12_rcs_offsets[] = { · line 981
Quoted 2 lines
drivers/gpu/drm/i915/gt/intel_lrc.c +1
-1-END (80 ) +END (185 )
Round up to the next cacheline(192) for safety paranoia. -Chris
_______________________________________________
Intel-gfx mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 4/5 drm/i915: Use indirect ctx bb to mend CMD_BUF_CCTL
Use indirect ctx bb to load cmd buffer control value from context image to avoid corruption.
v2: add to lrc layout (Chris)
v3: end to a cacheline (Chris)
Testcase: igt/i915_selftest/gt_lrc
--- drivers/gpu/drm/i915/gt/intel_lrc.c | 73 +++++++++++++++++++++++-- drivers/gpu/drm/i915/gt/intel_lrc_reg.h | 1 + drivers/gpu/drm/i915/i915_reg.h | 1 + 3 files changed, 71 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/gt/intel_lrc.c +69 -4
@@ -514,7 +514,7 @@ static void set_offsets(u32 *regs,#define REG16 (x) \ (((x) >> 9) | BIT(7) | BUILD_BUG_ON_ZERO(x >= 0x10000)), \ (((x) >> 2) & 0x7f) -#define END (x) 0, (x) +#define END (total_state_size) 0, (total_state_size) {const u32 base = engine->mmio_base;
@@ -922,8 +922,63 @@ static const u8 gen12_rcs_offsets[] = {NOP (6 ),LRI (1 ,0 ),REG (0x0c8 ), +NOP (3 +9 +1 ), + +LRI (51 ,POSTED ), +REG16 (0x588 ), +REG16 (0x588 ), +REG16 (0x588 ), +REG16 (0x588 ), +REG16 (0x588 ), +REG16 (0x588 ), +REG (0x028 ), +REG (0x09c ), +REG (0x0c0 ), +REG (0x178 ), +REG (0x17c ), +REG16 (0x358 ), +REG (0x170 ), +REG (0x150 ), +REG (0x154 ), +REG (0x158 ), +REG16 (0x41c ), +REG16 (0x600 ), +REG16 (0x604 ), +REG16 (0x608 ), +REG16 (0x60c ), +REG16 (0x610 ), +REG16 (0x614 ), +REG16 (0x618 ), +REG16 (0x61c ), +REG16 (0x620 ), +REG16 (0x624 ), +REG16 (0x628 ), +REG16 (0x62c ), +REG16 (0x630 ), +REG16 (0x634 ), +REG16 (0x638 ), +REG16 (0x63c ), +REG16 (0x640 ), +REG16 (0x644 ), +REG16 (0x648 ), +REG16 (0x64c ), +REG16 (0x650 ), +REG16 (0x654 ), +REG16 (0x658 ), +REG16 (0x65c ), +REG16 (0x660 ), +REG16 (0x664 ), +REG16 (0x668 ), +REG16 (0x66c ), +REG16 (0x670 ), +REG16 (0x674 ), +REG16 (0x678 ), +REG16 (0x67c ), +REG (0x068 ), +REG (0x084 ), +NOP (1 ), - END(80) +END (192 ) };#undef END
@@ -3207,7 +3262,7 @@ gen12_emit_timestamp_wa_lrm(struct intel_context *ce, u32 *cs) }static u32 * -gen12_emit_timestamp_wa_lrr (struct intel_context *ce,u32 *cs) +gen12_emit_render_ctx_wa (struct intel_context *ce,u32 *cs) {const u32 lrc_offset =i915_ggtt_offset (ce->state) +LRC_STATE_OFFSET ;
@@ -3227,6 +3282,16 @@ gen12_emit_timestamp_wa_lrr(struct intel_context *ce, u32 *cs) *cs++ = scratch_reg; *cs++ =i915_mmio_reg_offset (RING_CTX_TIMESTAMP (0 )); + *cs++ =MI_LOAD_REGISTER_MEM_GEN8 | +MI_SRM_LRM_GLOBAL_GTT |MI_LRI_LRM_CS_MMIO ; + *cs++ = scratch_reg; + *cs++ = lrc_offset +CTX_CMD_BUF_CCTL *sizeof (u32); + *cs++ =0 ; + + *cs++ =MI_LOAD_REGISTER_REG |MI_LRI_LRM_CS_MMIO ; + *cs++ = scratch_reg; + *cs++ =i915_mmio_reg_offset (RING_CMD_BUF_CCTL (0 )); +return cs; }
@@ -3290,7 +3355,7 @@ gen12_setup_timestamp_ctx_wa(struct intel_context *ce) fn = gen12_emit_timestamp_wa_lrm;if (ce->engine->class ==RENDER_CLASS ) - fn = gen12_emit_timestamp_wa_lrr; + fn = gen12_emit_render_ctx_wa;setup_indirect_ctx_bb (ce, fn); }
drivers/gpu/drm/i915/gt/intel_lrc_reg.h +1 -0
@@ -27,6 +27,7 @@#define CTX_PDP0_UDW (0x30 + 1)#define CTX_PDP0_LDW (0x32 + 1)#define CTX_R_PWR_CLK_STATE (0x42 + 1) +#define CTX_CMD_BUF_CCTL (0xB6 + 1)#define GEN9_CTX_RING_MI_MODE 0x54
drivers/gpu/drm/i915/i915_reg.h +1 -0
@@ -2657,6 +2657,7 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)#define RING_DMA_FADD_UDW (base) _MMIO((base) + 0x60)/* gen8+ */ #define RING_INSTPM (base) _MMIO((base) + 0xc0)#define RING_MI_MODE (base) _MMIO((base) + 0x9c) +#define RING_CMD_BUF_CCTL (base) _MMIO((base) + 0x84)#define INSTPS _MMIO(0x2070)/* 965+ only */ #define GEN4_INSTDONE1 _MMIO(0x207c)/* 965+ only, aka INSTDONE_2 on SNB */ #define ACTHD_I965 _MMIO(0x2074)
Signature · 6 lines
2.17.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 4/5] drm/i915: Use indirect ctx bb to mend CMD_BUF_CCTL
In reply to Mika KuoppalaQuoting Mika Kuoppala (2020-04-21 14:16:32)
drivers/gpu/drm/i915/gt/intel_lrc.c gen12_setup_timestamp_ctx_wa(struct intel_context *ce) · line 3358
Quoted 6 lines
drivers/gpu/drm/i915/gt/intel_lrc.c +1
-1@@ -3290,7 +3355,7 @@ gen12_setup_timestamp_ctx_wa(struct intel_context *ce) fn = gen12_emit_timestamp_wa_lrm;if (ce->engine->class ==RENDER_CLASS ) - fn = gen12_emit_timestamp_wa_lrr; + fn = gen12_emit_render_ctx_wa;
Ugh, render. 'rcs' to be consistent, usually as a suffix. -Chris
_______________________________________________
Intel-gfx mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 5/5 drm/i915: Split ctx timestamp selftest into two
In reply to Mika KuoppalaWe use different workarounds for render engine than for other engines. Split the selftest according to these types so that we get error rates per workaround.
--- drivers/gpu/drm/i915/gt/selftest_lrc.c | 26 +++++++++++++++++++++++--- 1 file changed, 23 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/gt/selftest_lrc.c +23 -3
@@ -4749,10 +4749,9 @@ static int __lrc_timestamp(const struct lrc_timestamp *arg, bool preempt)return err; } -static int live_lrc_timestamp (void *arg) +static int __live_lrc_timestamp (struct intel_gt *gt,bool rcs) {struct lrc_timestamp data = {}; -struct intel_gt *gt = arg;enum intel_engine_id id;const u32 poison[] = {0 ,
@@ -4774,6 +4773,12 @@ static int live_lrc_timestamp(void *arg)unsigned long heartbeat;int i, err =0 ; +if (rcs && data.engine->class !=RENDER_CLASS ) +continue ; + +if (!rcs && data.engine->class ==RENDER_CLASS ) +continue ; +engine_heartbeat_disable (data.engine, &heartbeat);for (i =0 ; i <ARRAY_SIZE (data.ce); i++) {
@@ -4825,6 +4830,20 @@ static int live_lrc_timestamp(void *arg)return 0 ; } +static int live_lrc_timestamp_rcs (void *arg) +{ +struct intel_gt *gt = arg; + +return __live_lrc_timestamp (gt, true); +} + +static int live_lrc_timestamp_xcs (void *arg) +{ +struct intel_gt *gt = arg; + +return __live_lrc_timestamp (gt, false); +} +static struct i915_vma *create_user_vma (struct i915_address_space *vm,unsigned long size) {
@@ -5748,7 +5767,8 @@ int intel_lrc_live_selftests(struct drm_i915_private *i915)SUBTEST (live_lrc_state),SUBTEST (live_lrc_gpr),SUBTEST (live_lrc_indirect_ctx_bb), -SUBTEST (live_lrc_timestamp), +SUBTEST (live_lrc_timestamp_rcs), +SUBTEST (live_lrc_timestamp_xcs),SUBTEST (live_lrc_garbage),SUBTEST (live_pphwsp_runtime), SUBTEST(live_lrc_isolation),
Signature · 6 lines
2.17.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 5/5] drm/i915: Split ctx timestamp selftest into two
Quoting Mika Kuoppala (2020-04-21 14:16:33)
drivers/gpu/drm/i915/gt/selftest_lrc.c static int live_lrc_timestamp(void *arg) · line 4780
Quoted 9 lines
drivers/gpu/drm/i915/gt/selftest_lrc.c +5
-0@@ -4774,6 +4773,12 @@ static int live_lrc_timestamp(void *arg)unsigned long heartbeat;int i, err =0 ; +if (rcs && data.engine->class !=RENDER_CLASS ) +continue ; + +if (!rcs && data.engine->class ==RENDER_CLASS ) +continue ;
At least have a bit of finesse and do
if (!(class & BIT(data.engine->engine->class)))
continue;
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 5/5] drm/i915: Split ctx timestamp selftest into two
Quoted 5 lines · Chris Wilson
Quoting Mika Kuoppala (2020-04-21 14:16:33)
Quoted 4 lines
drivers/gpu/drm/i915/gt/selftest_lrc.c +0
-0@@ -4774,6 +4773,12 @@ static int live_lrc_timestamp(void *arg)unsigned long heartbeat;int i, err =0 ;
Quoted 8 lines
drivers/gpu/drm/i915/gt/selftest_lrc.c static int live_lrc_timestamp(void *arg) · line 4780
Quoted 5 lines
drivers/gpu/drm/i915/gt/selftest_lrc.c +5
-0+if (rcs && data.engine->class !=RENDER_CLASS ) +continue ; + +if (!rcs && data.engine->class ==RENDER_CLASS ) +continue ;At least have a bit of finesse and do
if (!(class &BIT(data.engine->engine->class)))
I looked at the engine mask and I knew there must be a better way. -Mika
Quoted 1 line
continue;
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 5/5 drm/i915: Split ctx timestamp selftest into two
In reply to Chris WilsonWe use different workarounds for render engine than for other engines. Split the selftest according to these types so that we get error rates per workaround.
--- drivers/gpu/drm/i915/gt/selftest_lrc.c | 23 ++++++++++++++++++++--- 1 file changed, 20 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/gt/selftest_lrc.c +20 -3
@@ -4749,10 +4749,9 @@ static int __lrc_timestamp(const struct lrc_timestamp *arg, bool preempt)return err; } -static int live_lrc_timestamp (void *arg) +static int __live_lrc_timestamp (struct intel_gt *gt,unsigned long class_filter) {struct lrc_timestamp data = {}; -struct intel_gt *gt = arg;enum intel_engine_id id;const u32 poison[] = {0 ,
@@ -4774,6 +4773,9 @@ static int live_lrc_timestamp(void *arg)unsigned long heartbeat;int i, err =0 ; +if (!(class_filter &BIT (data.engine->class))) +continue ; +engine_heartbeat_disable (data.engine, &heartbeat);for (i =0 ; i <ARRAY_SIZE (data.ce); i++) {
@@ -4825,6 +4827,20 @@ static int live_lrc_timestamp(void *arg)return 0 ; } +static int live_lrc_timestamp_rcs (void *arg) +{ +struct intel_gt *gt = arg; + +return __live_lrc_timestamp (gt,BIT (RENDER_CLASS )); +} + +static int live_lrc_timestamp_xcs (void *arg) +{ +struct intel_gt *gt = arg; + +return __live_lrc_timestamp (gt, ~BIT (RENDER_CLASS )); +} +static struct i915_vma *create_user_vma (struct i915_address_space *vm,unsigned long size) {
@@ -5748,7 +5764,8 @@ int intel_lrc_live_selftests(struct drm_i915_private *i915)SUBTEST (live_lrc_state),SUBTEST (live_lrc_gpr),SUBTEST (live_lrc_indirect_ctx_bb), -SUBTEST (live_lrc_timestamp), +SUBTEST (live_lrc_timestamp_rcs), +SUBTEST (live_lrc_timestamp_xcs),SUBTEST (live_lrc_garbage),SUBTEST (live_pphwsp_runtime), SUBTEST(live_lrc_isolation),
Signature · 6 lines
2.17.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 5/5] drm/i915: Split ctx timestamp selftest into two
Quoting Mika Kuoppala (2020-04-21 15:29:32)
Quoted 5 lines
We use different workarounds for render engine than for other engines. Split the selftest according to these types so that we get error rates per workaround.
Signed-off-by Mika Kuoppala <[email protected]>
~o~
If you think it's useful,
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm/i915: Make define for lrc state offset
In reply to Mika Kuoppala== Series Details ==
== Series Details ==
Series: series starting with [1/5] drm/i915: Make define for lrc state offset
URL : https://patchwork.freedesktop.org/series/76262/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
52efd944a36d drm/i915: Make define for lrc state offset
c968fc0ee7cf drm/i915: Add per ctx batchbuffer wa for timestamp
-:51: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#51: FILE: drivers/gpu/drm/i915/gt/intel_gpu_commands.h:141:
+#define MI_LRI_LRM_CS_MMIO (1<<19)
^-:59: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #59: FILE: drivers/gpu/drm/i915/gt/intel_gpu_commands.h:158:
+#define MI_LRM_ASYNC (1<<21)
^
-:200: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #200: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:3256:
+ (I915_GTT_PAGE_SIZE - 4)/sizeof(*cs));
^
-:253: CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #253: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:3321:
+
+ }
total: 0 errors, 0 warnings, 4 checks, 273 lines checked 2f150abce7d5 drm/i915: Add live selftests for indirect ctx batchbuffers -:52: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV) #52: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:5387:
+#define CTX_BB_CANARY_OFFSET (3*1024)
^
-:53: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #53: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:5388:
+#define CTX_BB_CANARY_INDEX (CTX_BB_CANARY_OFFSET/sizeof(u32))
^
-:167: CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #167: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:5502:
+ for_each_engine(engine, gt, id) {
+
total: 0 errors, 0 warnings, 3 checks, 171 lines checked7a108f5f4ddb drm/i915: Use indirect ctx bb to mend CMD_BUF_CCTL
-:23: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #23: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:517:
+#define END(total_state_size) 0, (total_state_size)
-:31: CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #31: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:925:
+ NOP(3+9+1),
^
-:31: CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #31: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:925:
+ NOP(3+9+1),
^
total: 1 errors, 0 warnings, 2 checks, 118 lines checked c99d6bd66f5b drm/i915: Split ctx timestamp selftest into two
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/5] drm/i915: Make define for lrc state offset
In reply to Mika Kuoppala== Series Details ==
== Series Details ==
Series: series starting with [1/5] drm/i915: Make define for lrc state offset
URL : https://patchwork.freedesktop.org/series/76262/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8343 -> Patchwork_17405
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_17405 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_17405, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17405/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_17405:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@workarounds:
- fi-byt-j1900: [PASS][1] -> [FAIL][2] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/fi-byt-j1900/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17405/fi-byt-j1900/igt@i915_selftest@[email protected]
Known issues
------------
Here are the changes found in Patchwork_17405 that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@i915_selftest@live@gt_pm:
- fi-apl-guc: [DMESG-FAIL][3] ([i915#1751]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/fi-apl-guc/igt@i915_selftest@live@gt_pm.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17405/fi-apl-guc/igt@i915_selftest@live@gt_pm.html
* igt@kms_chamelium@dp-edid-read:
- fi-kbl-7500u: [FAIL][5] ([i915#976]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/fi-kbl-7500u/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17405/fi-kbl-7500u/igt@[email protected]
#### Warnings ####
* igt@i915_pm_rpm@module-reload:
- fi-kbl-x1275: [FAIL][7] ([i915#62]) -> [SKIP][8] ([fdo#109271])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/fi-kbl-x1275/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17405/fi-kbl-x1275/igt@[email protected]
* igt@i915_selftest@live@gt_pm:
- fi-icl-u2: [DMESG-FAIL][9] -> [DMESG-FAIL][10] ([i915#1754])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/fi-icl-u2/igt@i915_selftest@live@gt_pm.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17405/fi-icl-u2/igt@i915_selftest@live@gt_pm.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1751]: https://gitlab.freedesktop.org/drm/intel/issues/1751
[i915#1754]: https://gitlab.freedesktop.org/drm/intel/issues/1754
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#976]: https://gitlab.freedesktop.org/drm/intel/issues/976
Participating hosts (48 -> 43)
------------------------------
Additional (2): fi-kbl-7560u fi-bwr-2160
Missing (7): fi-cml-u2 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8343 -> Patchwork_17405
CI-20190529: 20190529
CI_DRM_8343: a5f7098d36b9370b08717c04d894d01c7cb4320b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5602: a8fcccd15dcc2dd409edd23785a2d6f6e85fb682 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17405: c99d6bd66f5b1b45e20e46b04c1b35b38aaf7af3 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
c99d6bd66f5b drm/i915: Split ctx timestamp selftest into two 7a108f5f4ddb drm/i915: Use indirect ctx bb to mend CMD_BUF_CCTL 2f150abce7d5 drm/i915: Add live selftests for indirect ctx batchbuffers c968fc0ee7cf drm/i915: Add per ctx batchbuffer wa for timestamp 52efd944a36d drm/i915: Make define for lrc state offset
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17405/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm/i915: Make define for lrc state offset (rev3)
In reply to Mika Kuoppala== Series Details ==
== Series Details ==
Series: series starting with [1/5] drm/i915: Make define for lrc state offset (rev3)
URL : https://patchwork.freedesktop.org/series/76262/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
ebd226e97eaa drm/i915: Make define for lrc state offset
91d36088a541 drm/i915: Add per ctx batchbuffer wa for timestamp
-:51: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#51: FILE: drivers/gpu/drm/i915/gt/intel_gpu_commands.h:141:
+#define MI_LRI_LRM_CS_MMIO (1<<19)
^-:59: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #59: FILE: drivers/gpu/drm/i915/gt/intel_gpu_commands.h:158:
+#define MI_LRM_ASYNC (1<<21)
^
-:200: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #200: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:3256:
+ (I915_GTT_PAGE_SIZE - 4)/sizeof(*cs));
^
-:253: CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #253: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:3321:
+
+ }
total: 0 errors, 0 warnings, 4 checks, 273 lines checked 4dde93b94a27 drm/i915: Add live selftests for indirect ctx batchbuffers -:52: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV) #52: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:5387:
+#define CTX_BB_CANARY_OFFSET (3*1024)
^
-:53: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #53: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:5388:
+#define CTX_BB_CANARY_INDEX (CTX_BB_CANARY_OFFSET/sizeof(u32))
^
-:167: CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #167: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:5502:
+ for_each_engine(engine, gt, id) {
+
total: 0 errors, 0 warnings, 3 checks, 171 lines checked3eb707784988 drm/i915: Use indirect ctx bb to mend CMD_BUF_CCTL
-:24: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #24: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:517:
+#define END(total_state_size) 0, (total_state_size)
-:32: CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #32: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:925:
+ NOP(3+9+1),
^
-:32: CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #32: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:925:
+ NOP(3+9+1),
^
total: 1 errors, 0 warnings, 2 checks, 118 lines checked 43625946de06 drm/i915: Split ctx timestamp selftest into two
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/5] drm/i915: Make define for lrc state offset (rev3)
In reply to Mika Kuoppala== Series Details ==
== Series Details ==
Series: series starting with [1/5] drm/i915: Make define for lrc state offset (rev3)
URL : https://patchwork.freedesktop.org/series/76262/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8343 -> Patchwork_17408
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17408/index.html
Known issues
------------
Here are the changes found in Patchwork_17408 that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@i915_selftest@live@gt_pm:
- fi-skl-6600u: [DMESG-FAIL][1] ([i915#1751]) -> [PASS][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/fi-skl-6600u/igt@i915_selftest@live@gt_pm.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17408/fi-skl-6600u/igt@i915_selftest@live@gt_pm.html
- fi-apl-guc: [DMESG-FAIL][3] ([i915#1751]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/fi-apl-guc/igt@i915_selftest@live@gt_pm.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17408/fi-apl-guc/igt@i915_selftest@live@gt_pm.html
* igt@kms_chamelium@dp-edid-read:
- fi-kbl-7500u: [FAIL][5] ([i915#976]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/fi-kbl-7500u/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17408/fi-kbl-7500u/igt@[email protected]
#### Warnings ####
* igt@i915_pm_rpm@module-reload:
- fi-kbl-x1275: [FAIL][7] ([i915#62]) -> [SKIP][8] ([fdo#109271])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/fi-kbl-x1275/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17408/fi-kbl-x1275/igt@[email protected]
* igt@i915_selftest@live@gt_pm:
- fi-icl-u2: [DMESG-FAIL][9] -> [DMESG-FAIL][10] ([i915#1754])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/fi-icl-u2/igt@i915_selftest@live@gt_pm.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17408/fi-icl-u2/igt@i915_selftest@live@gt_pm.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1751]: https://gitlab.freedesktop.org/drm/intel/issues/1751
[i915#1754]: https://gitlab.freedesktop.org/drm/intel/issues/1754
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#976]: https://gitlab.freedesktop.org/drm/intel/issues/976
Participating hosts (48 -> 43)
------------------------------
Additional (2): fi-kbl-7560u fi-bwr-2160
Missing (7): fi-cml-u2 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8343 -> Patchwork_17408
CI-20190529: 20190529
CI_DRM_8343: a5f7098d36b9370b08717c04d894d01c7cb4320b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5602: a8fcccd15dcc2dd409edd23785a2d6f6e85fb682 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17408: 43625946de06535afeec704d936fb3829de49ded @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
43625946de06 drm/i915: Split ctx timestamp selftest into two 3eb707784988 drm/i915: Use indirect ctx bb to mend CMD_BUF_CCTL 4dde93b94a27 drm/i915: Add live selftests for indirect ctx batchbuffers 91d36088a541 drm/i915: Add per ctx batchbuffer wa for timestamp ebd226e97eaa drm/i915: Make define for lrc state offset
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17408/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/5] drm/i915: Make define for lrc state offset (rev3)
In reply to Mika Kuoppala== Series Details ==
== Series Details ==
Series: series starting with [1/5] drm/i915: Make define for lrc state offset (rev3)
URL : https://patchwork.freedesktop.org/series/76262/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8343_full -> Patchwork_17408_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_17408_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_softpin@softpin:
- shard-snb: [PASS][1] -> [INCOMPLETE][2] ([i915#82])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/shard-snb2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17408/shard-snb6/igt@[email protected]
* igt@i915_selftest@live@uncore:
- shard-snb: [PASS][3] -> [FAIL][4] ([i915#1763])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/shard-snb2/igt@i915_selftest@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17408/shard-snb6/igt@i915_selftest@[email protected]
* igt@kms_big_fb@linear-32bpp-rotate-0:
- shard-kbl: [PASS][5] -> [FAIL][6] ([i915#1119] / [i915#93] / [i915#95])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/shard-kbl1/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17408/shard-kbl7/igt@[email protected]
- shard-apl: [PASS][7] -> [FAIL][8] ([i915#1119] / [i915#95])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/shard-apl6/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17408/shard-apl8/igt@[email protected]
* igt@kms_draw_crc@draw-method-rgb565-mmap-gtt-ytiled:
- shard-glk: [PASS][9] -> [FAIL][10] ([i915#52] / [i915#54]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/shard-glk6/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17408/shard-glk1/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [PASS][11] -> [FAIL][12] ([fdo#108145] / [i915#265])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/shard-skl9/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17408/shard-skl8/igt@[email protected]
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][13] -> [SKIP][14] ([fdo#109642] / [fdo#111068])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/shard-iclb2/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17408/shard-iclb5/igt@[email protected]
* igt@kms_psr@no_drrs:
- shard-iclb: [PASS][15] -> [FAIL][16] ([i915#173])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/shard-iclb3/igt@kms_psr@no_drrs.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17408/shard-iclb1/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#109441]) +2 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17408/shard-iclb3/igt@kms_psr@psr2_cursor_blt.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [PASS][19] -> [DMESG-WARN][20] ([i915#180]) +2 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/shard-kbl3/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17408/shard-kbl4/igt@[email protected]
#### Possible fixes ####
* {igt@gem_ctx_isolation@preservation-s3@vecs0}:
- shard-kbl: [DMESG-WARN][21] ([i915#180]) -> [PASS][22] +3 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/shard-kbl7/igt@gem_ctx_isolation@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17408/shard-kbl2/igt@gem_ctx_isolation@[email protected]
* igt@gem_exec_params@invalid-bsd-ring:
- shard-iclb: [SKIP][23] ([fdo#109276]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/shard-iclb8/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17408/shard-iclb1/igt@[email protected]
* igt@i915_module_load@reload-with-fault-injection:
- shard-kbl: [INCOMPLETE][25] ([i915#1373]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/shard-kbl3/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17408/shard-kbl3/igt@[email protected]
* igt@i915_selftest@live@requests:
- shard-tglb: [INCOMPLETE][27] ([i915#1531] / [i915#1658]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/shard-tglb8/igt@i915_selftest@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17408/shard-tglb1/igt@i915_selftest@[email protected]
* igt@i915_selftest@perf@engine_cs:
- shard-snb: [FAIL][29] -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/shard-snb5/igt@i915_selftest@perf@engine_cs.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17408/shard-snb5/igt@i915_selftest@perf@engine_cs.html
* igt@kms_cursor_legacy@cursor-vs-flip-legacy:
- shard-hsw: [INCOMPLETE][31] ([i915#61]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/shard-hsw7/igt@[email protected]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17408/shard-hsw4/igt@[email protected]
* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- shard-hsw: [FAIL][33] ([i915#57]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/shard-hsw6/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17408/shard-hsw1/igt@[email protected]
* igt@kms_draw_crc@draw-method-rgb565-blt-xtiled:
- shard-glk: [FAIL][35] ([i915#52] / [i915#54]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/shard-glk7/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17408/shard-glk7/igt@[email protected]
* {igt@kms_flip@2x-flip-vs-expired-vblank-interruptible@bc-hdmi-a1-hdmi-a2}:
- shard-glk: [FAIL][37] ([i915#79]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/shard-glk7/igt@kms_flip@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17408/shard-glk5/igt@kms_flip@[email protected]
* {igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1}:
- shard-skl: [FAIL][39] ([i915#79]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/shard-skl9/igt@kms_flip@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17408/shard-skl7/igt@kms_flip@[email protected]
* {igt@kms_flip@flip-vs-expired-vblank@a-dp1}:
- shard-kbl: [FAIL][41] ([i915#79]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/shard-kbl4/igt@kms_flip@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17408/shard-kbl6/igt@kms_flip@[email protected]
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [FAIL][43] ([i915#1188]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/shard-skl10/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17408/shard-skl5/igt@[email protected]
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-apl: [DMESG-WARN][45] ([i915#180]) -> [PASS][46] +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/shard-apl6/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17408/shard-apl8/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [FAIL][47] ([fdo#108145] / [i915#265]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/shard-skl9/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17408/shard-skl7/igt@[email protected]
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-glk: [FAIL][49] ([i915#899]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/shard-glk8/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17408/shard-glk4/igt@[email protected]
* igt@kms_psr@psr2_suspend:
- shard-iclb: [SKIP][51] ([fdo#109441]) -> [PASS][52] +2 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/shard-iclb7/igt@kms_psr@psr2_suspend.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17408/shard-iclb2/igt@kms_psr@psr2_suspend.html
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-skl: [INCOMPLETE][53] ([i915#69]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/shard-skl7/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17408/shard-skl10/igt@[email protected]
#### Warnings ####
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][55] ([i915#658]) -> [SKIP][56] ([i915#588])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/shard-iclb7/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17408/shard-iclb2/igt@[email protected]
* igt@i915_pm_rpm@sysfs-read:
- shard-snb: [INCOMPLETE][57] ([i915#82]) -> [SKIP][58] ([fdo#109271])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/shard-snb6/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17408/shard-snb1/igt@[email protected]
* igt@i915_pm_rpm@system-suspend-devices:
- shard-snb: [SKIP][59] ([fdo#109271]) -> [INCOMPLETE][60] ([i915#82])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/shard-snb2/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17408/shard-snb4/igt@[email protected]
* igt@kms_psr2_su@page_flip:
- shard-iclb: [SKIP][61] ([fdo#109642] / [fdo#111068]) -> [FAIL][62] ([i915#608])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8343/shard-iclb6/igt@kms_psr2_su@page_flip.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17408/shard-iclb2/igt@kms_psr2_su@page_flip.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[i915#1119]: https://gitlab.freedesktop.org/drm/intel/issues/1119
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1373]: https://gitlab.freedesktop.org/drm/intel/issues/1373
[i915#1531]: https://gitlab.freedesktop.org/drm/intel/issues/1531
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#1658]: https://gitlab.freedesktop.org/drm/intel/issues/1658
[i915#173]: https://gitlab.freedesktop.org/drm/intel/issues/173
[i915#1763]: https://gitlab.freedesktop.org/drm/intel/issues/1763
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#52]: https://gitlab.freedesktop.org/drm/intel/issues/52
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#57]: https://gitlab.freedesktop.org/drm/intel/issues/57
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#608]: https://gitlab.freedesktop.org/drm/intel/issues/608
[i915#61]: https://gitlab.freedesktop.org/drm/intel/issues/61
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
[i915#899]: https://gitlab.freedesktop.org/drm/intel/issues/899
[i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8343 -> Patchwork_17408
CI-20190529: 20190529
CI_DRM_8343: a5f7098d36b9370b08717c04d894d01c7cb4320b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5602: a8fcccd15dcc2dd409edd23785a2d6f6e85fb682 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17408: 43625946de06535afeec704d936fb3829de49ded @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17408/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm/i915: Make define for lrc state offset (rev4)
In reply to Mika Kuoppala== Series Details ==
== Series Details ==
Series: series starting with [1/5] drm/i915: Make define for lrc state offset (rev4)
URL : https://patchwork.freedesktop.org/series/76262/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
c89bc59fae80 drm/i915: Make define for lrc state offset
47e9e54a1306 drm/i915: Add per ctx batchbuffer wa for timestamp
-:51: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#51: FILE: drivers/gpu/drm/i915/gt/intel_gpu_commands.h:141:
+#define MI_LRI_LRM_CS_MMIO (1<<19)
^-:59: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #59: FILE: drivers/gpu/drm/i915/gt/intel_gpu_commands.h:158:
+#define MI_LRM_ASYNC (1<<21)
^
-:200: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #200: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:3237:
+ (I915_GTT_PAGE_SIZE - 4)/sizeof(*cs));
^
-:253: CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #253: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:3302:
+
+ }
total: 0 errors, 0 warnings, 4 checks, 273 lines checked 8d954c6be360 drm/i915: Add live selftests for indirect ctx batchbuffers -:52: CHECK:SPACING: spaces preferred around that '*' (ctx:VxV) #52: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:5714:
+#define CTX_BB_CANARY_OFFSET (3*1024)
^
-:53: CHECK:SPACING: spaces preferred around that '/' (ctx:VxV) #53: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:5715:
+#define CTX_BB_CANARY_INDEX (CTX_BB_CANARY_OFFSET/sizeof(u32))
^
-:167: CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #167: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:5829:
+ for_each_engine(engine, gt, id) {
+
total: 0 errors, 0 warnings, 3 checks, 171 lines checked1e6c4b4767e2 drm/i915: Use indirect ctx bb to mend CMD_BUF_CCTL
-:24: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #24: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:517:
+#define END(total_state_size) 0, (total_state_size)
-:32: CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #32: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:925:
+ NOP(3+9+1),
^
-:32: CHECK:SPACING: spaces preferred around that '+' (ctx:VxV) #32: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:925:
+ NOP(3+9+1),
^
total: 1 errors, 0 warnings, 2 checks, 118 lines checked 59f9b8f7d812 drm/i915: Split ctx timestamp selftest into two
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/5] drm/i915: Make define for lrc state offset (rev4)
In reply to Mika Kuoppala== Series Details ==
== Series Details ==
Series: series starting with [1/5] drm/i915: Make define for lrc state offset (rev4)
URL : https://patchwork.freedesktop.org/series/76262/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8350 -> Patchwork_17427
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17427/index.html
Known issues
------------
Here are the changes found in Patchwork_17427 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@vma:
- fi-ivb-3770: [PASS][1] -> [FAIL][2] ([i915#1763])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8350/fi-ivb-3770/igt@i915_selftest@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17427/fi-ivb-3770/igt@i915_selftest@[email protected]
#### Warnings ####
* igt@i915_pm_rpm@module-reload:
- fi-kbl-x1275: [FAIL][3] ([i915#62]) -> [SKIP][4] ([fdo#109271])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8350/fi-kbl-x1275/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17427/fi-kbl-x1275/igt@[email protected]
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1763]: https://gitlab.freedesktop.org/drm/intel/issues/1763
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
Participating hosts (48 -> 42)
------------------------------
Additional (1): fi-icl-dsi
Missing (7): fi-cml-u2 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-kbl-7500u fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8350 -> Patchwork_17427
CI-20190529: 20190529
CI_DRM_8350: 018bab6d1c4ac37bff9306384383fab59750e140 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5606: 678afb3954bec6227c8762756a0ad6d9946d49b2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17427: 59f9b8f7d8123fa150ece73377ff7a47999086fa @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
59f9b8f7d812 drm/i915: Split ctx timestamp selftest into two 1e6c4b4767e2 drm/i915: Use indirect ctx bb to mend CMD_BUF_CCTL 8d954c6be360 drm/i915: Add live selftests for indirect ctx batchbuffers 47e9e54a1306 drm/i915: Add per ctx batchbuffer wa for timestamp c89bc59fae80 drm/i915: Make define for lrc state offset
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17427/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoting Mika Kuoppala (2020-04-21 14:16:29)
Quoted 4 lines
More often than not, we need a byte offset into lrc register state from the start of the hw state. Make it so.
Signed-off-by Mika Kuoppala <[email protected]>
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/5] drm/i915: Make define for lrc state offset (rev4)
In reply to Mika Kuoppala== Series Details ==
== Series Details ==
Series: series starting with [1/5] drm/i915: Make define for lrc state offset (rev4)
URL : https://patchwork.freedesktop.org/series/76262/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8350_full -> Patchwork_17427_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_17427_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_eio@in-flight-suspend:
- shard-skl: [PASS][1] -> [INCOMPLETE][2] ([i915#69])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8350/shard-skl9/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17427/shard-skl1/igt@[email protected]
* igt@gem_workarounds@suspend-resume-context:
- shard-glk: [PASS][3] -> [INCOMPLETE][4] ([i915#58] / [k.org#198133])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8350/shard-glk8/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17427/shard-glk2/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [PASS][5] -> [DMESG-WARN][6] ([i915#180] / [i915#93] / [i915#95]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8350/shard-kbl3/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17427/shard-kbl3/igt@[email protected]
* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][7] -> [FAIL][8] ([i915#1188])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8350/shard-skl1/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17427/shard-skl5/igt@[email protected]
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-apl: [PASS][9] -> [DMESG-WARN][10] ([i915#180]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8350/shard-apl3/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17427/shard-apl1/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][11] -> [FAIL][12] ([fdo#108145] / [i915#265]) +3 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8350/shard-skl6/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17427/shard-skl1/igt@[email protected]
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][13] -> [SKIP][14] ([fdo#109642] / [fdo#111068])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8350/shard-iclb2/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17427/shard-iclb1/igt@[email protected]
* igt@kms_psr@no_drrs:
- shard-iclb: [PASS][15] -> [FAIL][16] ([i915#173])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8350/shard-iclb2/igt@kms_psr@no_drrs.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17427/shard-iclb1/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [PASS][17] -> [SKIP][18] ([fdo#109441])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8350/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17427/shard-iclb7/igt@kms_psr@psr2_primary_mmap_cpu.html
#### Possible fixes ####
* igt@gem_workarounds@suspend-resume-context:
- shard-kbl: [INCOMPLETE][19] ([i915#155] / [i915#1687]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8350/shard-kbl7/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17427/shard-kbl2/igt@[email protected]
* igt@i915_pm_rpm@system-suspend:
- shard-skl: [INCOMPLETE][21] ([i915#151] / [i915#69]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8350/shard-skl10/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17427/shard-skl10/igt@[email protected]
* {igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1}:
- shard-skl: [FAIL][23] ([i915#79]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8350/shard-skl1/igt@kms_flip@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17427/shard-skl5/igt@kms_flip@[email protected]
* {igt@kms_flip@flip-vs-suspend-interruptible@a-dp1}:
- shard-kbl: [DMESG-WARN][25] ([i915#180]) -> [PASS][26] +5 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8350/shard-kbl6/igt@kms_flip@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17427/shard-kbl7/igt@kms_flip@[email protected]
* {igt@kms_flip@flip-vs-suspend-interruptible@b-edp1}:
- shard-skl: [INCOMPLETE][27] ([i915#198]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8350/shard-skl3/igt@kms_flip@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17427/shard-skl6/igt@kms_flip@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [FAIL][29] ([fdo#108145] / [i915#265]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8350/shard-skl10/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17427/shard-skl4/igt@[email protected]
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [SKIP][31] ([fdo#109441]) -> [PASS][32] +3 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8350/shard-iclb8/igt@kms_psr@psr2_sprite_plane_move.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17427/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
* {igt@perf@blocking-parameterized}:
- shard-iclb: [FAIL][33] ([i915#1542]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8350/shard-iclb8/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17427/shard-iclb2/igt@[email protected]
* {igt@perf@polling-small-buf}:
- shard-iclb: [FAIL][35] ([i915#1722]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8350/shard-iclb2/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17427/shard-iclb1/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#151]: https://gitlab.freedesktop.org/drm/intel/issues/151
[i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#1687]: https://gitlab.freedesktop.org/drm/intel/issues/1687
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#173]: https://gitlab.freedesktop.org/drm/intel/issues/173
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#46]: https://gitlab.freedesktop.org/drm/intel/issues/46
[i915#58]: https://gitlab.freedesktop.org/drm/intel/issues/58
[i915#69]: https://gitlab.freedesktop.org/drm/intel/issues/69
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_8350 -> Patchwork_17427
CI-20190529: 20190529
CI_DRM_8350: 018bab6d1c4ac37bff9306384383fab59750e140 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5606: 678afb3954bec6227c8762756a0ad6d9946d49b2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_17427: 59f9b8f7d8123fa150ece73377ff7a47999086fa @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_17427/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx