Skip to contentSkip to conversation

package/bzip2: cve-2019-12900 fix for bzip2 1.0.6

PATCH New jared.bents at rockwellcollins.com 2 participants 3 messages Jun 26, 2019 – Jul 7, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/bzip2: cve-2019-12900 fix for bzip2 1.0.6

From: Jared Bents <[email protected]>

Patch to resolve cve-2019-12900 which affects bzip2 versions 1.0.6 and older

More information can be found at
https://nvd.nist.gov/vuln/detail/CVE-2019-12900

This applies to both master and 2019.02

---
 ...-sure-nSelectors-is-not-out-of-range.patch | 33 +++++++++++++++++++
 1 file changed, 33 insertions(+)
 create mode 100644 package/bzip2/0003-Make-sure-nSelectors-is-not-out-of-range.patch
package/bzip2/0003-Make-sure-nSelectors-is-not-out-of-range.patch new file +33 -0
new file mode 100644
index 0000000000..77a500d46d
@@ -0,0 +1,33 @@
+From 74de1e2e6ffc9d51ef9824db71a8ffee5962cdbc Mon Sep 17 00:00:00 2001
+From: Albert Astals Cid <[email protected]>
+Date: Tue, 28 May 2019 19:35:18 +0200
+Subject: [PATCH] Make sure nSelectors is not out of range
+
+nSelectors is used in a loop from 0 to nSelectors to access selectorMtf
+which is
+	UChar    selectorMtf[BZ_MAX_SELECTORS];
+so if nSelectors is bigger than BZ_MAX_SELECTORS it'll do an invalid memory
+access
+
+Fixes out of bounds access discovered while fuzzying karchive
+
+Signed-off-by: Albert Astals Cid <[email protected]>
+---
+ decompress.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/decompress.c b/decompress.c
+index ab6a624..f3db91d 100644
+--- a/decompress.c
++++ b/decompress.c
+@@ -287,7 +287,7 @@ Int32 BZ2_decompress ( DState* s )
+       GET_BITS(BZ_X_SELECTOR_1, nGroups, 3);
+       if (nGroups < 2 || nGroups > 6) RETURN(BZ_DATA_ERROR);
+       GET_BITS(BZ_X_SELECTOR_2, nSelectors, 15);
+-      if (nSelectors < 1) RETURN(BZ_DATA_ERROR);
++      if (nSelectors < 1 || nSelectors > BZ_MAX_SELECTORS) RETURN(BZ_DATA_ERROR);
+       for (i = 0; i < nSelectors; i++) {
+          j = 0;
+          while (True) {
+-- 
+2.21.0
Signature · 1 line
2.18.0
#1 lore raw

PATCH 1/1 package/bzip2: cve-2019-12900 fix for bzip2 1.0.6

Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"jared" == jared bents <[email protected]> writes:

From: Jared Bents <[email protected]> Patch to resolve cve-2019-12900 which affects bzip2 versions 1.0.6 and older

More information can be found at
https://nvd.nist.gov/vuln/detail/CVE-2019-12900

This applies to both master and 2019.02

This information should not be part of the commit message, so it should go after the "---" line.

Committed with that fixed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 package/bzip2: cve-2019-12900 fix for bzip2 1.0.6

In reply to jared.bents at rockwellcollins.com
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"jared" == jared bents <[email protected]> writes:

From: Jared Bents <[email protected]> Patch to resolve cve-2019-12900 which affects bzip2 versions 1.0.6 and older

Quoted 6 lines

More information can be found at
https://nvd.nist.gov/vuln/detail/CVE-2019-12900

This applies to both master and 2019.02

Committed to 2019.02.x and 2019.05.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard