package/libvncserver: fix homepage
PATCH 1/2 package/libvncserver: fix homepage
libvncserver homepage is https://libvnc.github.io/, last version on sourceforge is 0.9.9 (seven years ago)
--- package/libvncserver/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/libvncserver/Config.in +1 -1
@@ -6,7 +6,7 @@ config BR2_PACKAGE_LIBVNCSERVER help libvncserver is a VNC server/client library. - http://libvncserver.sourceforge.net/ + https://libvnc.github.io/ if BR2_PACKAGE_LIBVNCSERVER
Signature · 1 line
2.20.1
PATCH 2/2 package/libvncserver: bump to version 0.9.12
- Remove patch (already in version)
- autotools is no more available, switch to cmake
- Disable ffmpeg (used for example)
- Add LZO dependency (to avoid using internal LZO) through the new WITH_LZO option added by
https://github.com/LibVNC/libvncserver/commit/139da17b6ed0ccd1acd824a87972182834671f92
- Add hash for license file
--- ...Limit-client-cut-text-length-to-1-MB.patch | 65 ------------------- package/libvncserver/Config.in | 1 + package/libvncserver/libvncserver.hash | 3 +- package/libvncserver/libvncserver.mk | 45 ++++++------- 4 files changed, 26 insertions(+), 88 deletions(-) delete mode 100644 package/libvncserver/0001-Limit-client-cut-text-length-to-1-MB.patch
package/libvncserver/0001-Limit-client-cut-text-length-to-1-MB.patch deleted +0 -65
@@ -1,65 +0,0 @@ -From 28afb6c537dc82ba04d5f245b15ca7205c6dbb9c Mon Sep 17 00:00:00 2001 -From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <[email protected]> -Date: Mon, 26 Feb 2018 13:48:00 +0100 -Subject: [PATCH] Limit client cut text length to 1 MB - -This patch constrains a client cut text length to 1 MB. Otherwise -a client could make server allocate 2 GB of memory and that seems to -be to much to classify it as a denial of service. - -The limit also prevents from an integer overflow followed by copying -an uninitilized memory when processing msg.cct.length value larger -than SIZE_MAX or INT_MAX - sz_rfbClientCutTextMsg. - -This patch also corrects accepting length value of zero (malloc(0) is -interpreted on differnet systems differently). - -CVE-2018-7225 -<https://github.com/LibVNC/libvncserver/issues/218> - -Signed-off-by: Peter Korsgaard <[email protected]> ---- - libvncserver/rfbserver.c | 20 +++++++++++++++++++- - 1 file changed, 19 insertions(+), 1 deletion(-) - -diff --git a/libvncserver/rfbserver.c b/libvncserver/rfbserver.c -index 116c488..4fc4d9d 100644 ---- a/libvncserver/rfbserver.c -+++ b/libvncserver/rfbserver.c -@@ -88,6 +88,8 @@ - #include <errno.h> - /* strftime() */ - #include <time.h> -+/* PRIu32 */ -+#include <inttypes.h> - - #ifdef LIBVNCSERVER_WITH_WEBSOCKETS - #include "rfbssl.h" -@@ -2575,7 +2577,23 @@ rfbProcessClientNormalMessage(rfbClientPtr cl) - - msg.cct.length = Swap32IfLE(msg.cct.length); - -- str = (char *)malloc(msg.cct.length); -+ /* uint32_t input is passed to malloc()'s size_t argument, -+ * to rfbReadExact()'s int argument, to rfbStatRecordMessageRcvd()'s int -+ * argument increased of sz_rfbClientCutTextMsg, and to setXCutText()'s int -+ * argument. Here we impose a limit of 1 MB so that the value fits -+ * into all of the types to prevent from misinterpretation and thus -+ * from accessing uninitialized memory (CVE-2018-7225) and also to -+ * prevent from a denial-of-service by allocating to much memory in -+ * the server. */ -+ if (msg.cct.length > 1<<20) { -+ rfbLog("rfbClientCutText: too big cut text length requested: %" PRIu32 "\n", -+ msg.cct.length); -+ rfbCloseClient(cl); -+ return; -+ } -+ -+ /* Allow zero-length client cut text. */ -+ str = (char *)calloc(msg.cct.length ? msg.cct.length : 1, 1); - if (str == NULL) { - rfbLogPerror("rfbProcessClientNormalMessage: not enough memory"); - rfbCloseClient(cl); --- -2.11.0 -
package/libvncserver/Config.in +1 -0
@@ -3,6 +3,7 @@ config BR2_PACKAGE_LIBVNCSERVER depends on BR2_USE_MMU # VNCommand.c uses fork() # binutils issue (bad expression) depends on !BR2_nios2 + select BR2_PACKAGE_LZO help libvncserver is a VNC server/client library.
package/libvncserver/libvncserver.hash +2 -1
@@ -1,2 +1,3 @@ # Locally computed: -sha256 193d630372722a532136fd25c5326b2ca1a636cbb8bf9bb115ef869c804d2894 LibVNCServer-0.9.11.tar.gz +sha256 33cbbb4e15bb390f723c311b323cef4a43bcf781984f92d92adda3243a116136 LibVNCServer-0.9.12.tar.gz +sha256 4d23c8c814e5baf007d854f01d8502e77dc56a41144934e003fb32c4e052d20f COPYING
package/libvncserver/libvncserver.mk +23 -22
89 lines not on this page · raw message
Signature · 1 line
2.20.1
PATCH 1/2 package/libvncserver: fix homepage
In reply to Fabrice FontaineQuoted 7 lines · On Sat, 22 Jun 2019 15:33:09 +0200 Fabrice Fontaine…
libvncserver homepage is https://libvnc.github.io/, last version on sourceforge is 0.9.9 (seven years ago)
Signed-off-by Fabrice Fontaine <[email protected]>--- package/libvncserver/Config.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Both applied to master, thanks.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH 1/2 package/libvncserver: fix homepage
In reply to Fabrice FontaineQuoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Fabrice" == Fabrice Fontaine <[email protected]> writes:
libvncserver homepage is https://libvnc.github.io/, last version on sourceforge is 0.9.9 (seven years ago)
Signed-off-by Fabrice Fontaine <[email protected]>
Committed to 2019.02.x and 2019.05.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard