Skip to contentSkip to conversation

linux-tools/perf: Add dependency on 32-bit atomics

PATCH New Alexey Brodkin 3 participants 3 messages Apr 18, 2019 – Apr 24, 2019

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 linux-tools/perf: Add dependency on 32-bit atomics

Atomic ops are strictly required by perf utility as it uses atomic_xxx() functions.

Otherwise building fails like that:

|.../output/host/opt/ext-toolchain/bin/../lib/gcc/arc-snps-linux-uclibc/8.2.1/../../../../arc-snps-linux-uclibc/bin/ld:
|.../output/build/linux-5.0.7/tools/perf/libperf.a(libperf-in.o): in function `atomic_cmpxchg':
|.../output/build/linux-5.0.7/tools/include/asm-generic/atomic-gcc.h:69: undefined reference to `__sync_val_compare_and_swap_4'
Cc Thomas Petazzoni <[email protected]>

---

Changes v1 -> v2:
* Depend on generic BR2_TOOLCHAIN_HAS_SYNC_4

 package/linux-tools/Config.in | 4 ++++
 1 file changed, 4 insertions(+)
package/linux-tools/Config.in +4 -0
index 4916faa349..104065b22d 100644
@@ -46,6 +46,7 @@ config BR2_PACKAGE_LINUX_TOOLS_PCI
 config BR2_PACKAGE_LINUX_TOOLS_PERF
 	bool "perf"
 	select BR2_PACKAGE_LINUX_TOOLS
+	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 	help
 	  perf (sometimes "Perf Events" or perf tools, originally
 	  "Performance Counters for Linux") - is a performance
@@ -64,6 +65,9 @@ config BR2_PACKAGE_LINUX_TOOLS_PERF
 
 	  https://perf.wiki.kernel.org/
 
+comment "perf needs 32-bit atomic ops"
+	depends on !BR2_TOOLCHAIN_HAS_SYNC_4
+
 if BR2_PACKAGE_LINUX_TOOLS_PERF
 
 config BR2_PACKAGE_LINUX_TOOLS_PERF_TUI
Signature · 1 line
2.16.2
#1 lore raw

PATCH v2 1/1 linux-tools/perf: Add dependency on 32-bit atomics

Hello,

Quoted 10 lines · On Thu, 18 Apr 2019 20:38:45 +0300 Alexey Brodkin…

Atomic ops are strictly required by perf utility as it uses atomic_xxx() functions.

Otherwise building fails like that:

|.../output/host/opt/ext-toolchain/bin/../lib/gcc/arc-snps-linux-uclibc/8.2.1/../../../../arc-snps-linux-uclibc/bin/ld:
|.../output/build/linux-5.0.7/tools/perf/libperf.a(libperf-in.o): in function `atomic_cmpxchg':
|.../output/build/linux-5.0.7/tools/include/asm-generic/atomic-gcc.h:69: undefined reference to `__sync_val_compare_and_swap_4'
Cc Thomas Petazzoni <[email protected]>

I have applied to master, after doing one change, see below.

package/linux-tools/Config.in config BR2_PACKAGE_LINUX_TOOLS_PERF · line 70

Quoted 3 lines
package/linux-tools/Config.in +3 -0
+comment "perf needs 32-bit atomic ops"
+	depends on !BR2_TOOLCHAIN_HAS_SYNC_4
+

We typically don't add such comments, because it's an architecture dependency. There is nothing the user can do about it, so there's no point in having a comment.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH v2 1/1 linux-tools/perf: Add dependency on 32-bit atomics

In reply to Alexey Brodkin
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Alexey" == Alexey Brodkin <[email protected]> writes:

Atomic ops are strictly required by perf utility as it uses atomic_xxx() functions.

Otherwise building fails like that:

|.../output/host/opt/ext-toolchain/bin/../lib/gcc/arc-snps-linux-uclibc/8.2.1/../../../../arc-snps-linux-uclibc/bin/ld:
|.../output/build/linux-5.0.7/tools/perf/libperf.a(libperf-in.o): in function `atomic_cmpxchg':
|.../output/build/linux-5.0.7/tools/include/asm-generic/atomic-gcc.h:69: undefined reference to `__sync_val_compare_and_swap_4'
Quoted 6 lines
Cc Thomas Petazzoni <[email protected]>

---

Changes v1 -> v2:
* Depend on generic BR2_TOOLCHAIN_HAS_SYNC_4

Committed to 2019.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard