Skip to contentSkip to conversation

rustc: disable for ARMV7A with EABI

PATCH New Eric Le Bihan 3 participants 6 messages Feb 26, 2018 – Feb 27, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rustc: disable for ARMV7A with EABI

The Rust project does not support armv7a EABI, only EABIHF [1]. So disable rustc for this ARM variant.

Fixes:

- http://autobuild.buildroot.net/results/51c98ca5486e7e83725ababa437cbb8204ceb66b/

[1] https://forge.rust-lang.org/platform-support.html

---
 package/rustc/Config.in.host | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/rustc/Config.in.host +2 -1
index bdbe488f48..1c79eededc 100644
@@ -5,7 +5,8 @@ config BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS
 	default y if BR2_i386
 	default y if BR2_x86_64
 	default y if BR2_aarch64
-	default y if BR2_arm && !BR2_ARM_CPU_ARMV4 && !BR2_ARM_CPU_ARMV5
+	default y if BR2_arm && !BR2_ARM_CPU_ARMV4 && !BR2_ARM_CPU_ARMV5 \
+	        && !(BR2_ARM_CPU_ARMV7A && BR2_ARM_EABI)
 	default y if BR2_powerpc || BR2_powerpc64
 	default y if (BR2_mips || BR2_mipsel) && !BR2_MIPS_CPU_MIPS32R6
 	default y if (BR2_mips64 || BR2_mips64el) && !BR2_MIPS_CPU_MIPS64R6 \
Signature · 1 line
2.14.3
#1 lore raw

PATCH 1/1 rustc: disable for ARMV7A with EABI

Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Eric" == Eric Le Bihan <[email protected]> writes:

The Rust project does not support armv7a EABI, only EABIHF [1]. So disable rustc for this ARM variant.

Quoted 7 lines

Fixes:

- http://autobuild.buildroot.net/results/51c98ca5486e7e83725ababa437cbb8204ceb66b/

[1] https://forge.rust-lang.org/platform-support.html

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 rustc: disable for ARMV7A with EABI

In reply to Eric Le Bihan

Hello,

Quoted 2 lines · Eric Le Bihan

The Rust project does not support armv7a EABI, only EABIHF [1]. So disable rustc for this ARM variant.

Are you sure ?

Quoted 1 line

[1] https://forge.rust-lang.org/platform-support.html

On this page, I see:

arm-unknown-linux-gnueabi ? ? ? ARMv6 Linux
arm-unknown-linux-gnueabihf ? ? ? ARMv6 Linux, hardfloat
armv7-unknown-linux-gnueabihf ? ? ? ARMv7 Linux

The arm-unknown-linux-gnueabi variant should apply to ARMv7 as well.

It looks like a better fix would be:

config BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS
bool
# The pre-built Rust standard library is only available for the # following architectures/ABIs, and is built against glibc. default y if BR2_i386
default y if BR2_x86_64
default y if BR2_aarch64
- default y if BR2_arm && !BR2_ARM_CPU_ARMV4 && !BR2_ARM_CPU_ARMV5

+	default y if BR2_ARM_CPU_ARMV6 || BR2_ARM_CPU_ARMV7A
        default y if BR2_powerpc || BR2_powerpc64
        default y if (BR2_mips || BR2_mipsel) && !BR2_MIPS_CPU_MIPS32R6
        default y if (BR2_mips64 || BR2_mips64el) && !BR2_MIPS_CPU_MIPS64R6 \
                && BR2_MIPS_NABI64
        depends on BR2_TOOLCHAIN_USES_GLIBC
        depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"

config BR2_PACKAGE_HOST_RUSTC_ARCH
string
- default "armv7" if BR2_ARM_CPU_ARMV7A
+ default "armv7" if (BR2_ARM_CPU_ARMV7A && BR2_ARM_EABIHF)
default BR2_ARCH if !BR2_ARM_CPU_ARMV7A

config BR2_PACKAGE_HOST_RUSTC_ABI
string
default "eabi" if BR2_ARM_EABI
default "eabihf" if BR2_ARM_EABIHF
default "abi64" if BR2_MIPS_NABI64

Indeed arm-unknown-linux-gnueabi can support ARMv6 and later (including ARMv7) with EABI, arm-unknown-linux-gnueabihf can support ARMv6 EABIhf, and armv7-unknown-linux-gnueabihf can support ARMv7 EABIhf.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
#3 lore raw

PATCH 1/1 rustc: disable for ARMV7A with EABI

Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hello,

Quoted 2 lines · Eric Le Bihan

The Rust project does not support armv7a EABI, only EABIHF [1]. So disable rustc for this ARM variant.

Are you sure ?

Quoted 1 line

[1] https://forge.rust-lang.org/platform-support.html

Quoted 7 lines

On this page, I see:

arm-unknown-linux-gnueabi ? ? ? ARMv6 Linux
arm-unknown-linux-gnueabihf ? ? ? ARMv6 Linux, hardfloat
armv7-unknown-linux-gnueabihf ? ? ? ARMv7 Linux

The arm-unknown-linux-gnueabi variant should apply to ARMv7 as well.

Ok, but that is more of an improvement. It was still wrong that it tried to download an ARMv7 EABI toolchain.

Review

Quoted 11 lines

It looks like a better fix would be:

config BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS
bool
# The pre-built Rust standard library is only available for the # following architectures/ABIs, and is built against glibc. default y if BR2_i386
default y if BR2_x86_64
default y if BR2_aarch64

(quoted diff) +1 -1
-       default y if BR2_arm && !BR2_ARM_CPU_ARMV4 && !BR2_ARM_CPU_ARMV5
+	default y if BR2_ARM_CPU_ARMV6 || BR2_ARM_CPU_ARMV7A

I agree that having positive logic would be nicer. It is a bit more complicated than this as we also should handle ARMV8A cores in ARM mode similar to how ve handle ARMV7A.

Care to send an updated patch on top of master doing that?

Signature · 1 line
Bye, Peter Korsgaard
#4 lore raw

PATCH 1/1 rustc: disable for ARMV7A with EABI

Hello,

Quoted 16 lines · Peter Korsgaard

Review

Quoted 11 lines

It looks like a better fix would be:

config BR2_PACKAGE_HOST_RUSTC_ARCH_SUPPORTS
bool
# The pre-built Rust standard library is only available for the # following architectures/ABIs, and is built against glibc. default y if BR2_i386
default y if BR2_x86_64
default y if BR2_aarch64

(quoted diff) +1 -1
-       default y if BR2_arm && !BR2_ARM_CPU_ARMV4 && !BR2_ARM_CPU_ARMV5
+	default y if BR2_ARM_CPU_ARMV6 || BR2_ARM_CPU_ARMV7A  

I agree that having positive logic would be nicer. It is a bit more complicated than this as we also should handle ARMV8A cores in ARM mode similar to how ve handle ARMV7A.

Quoted 1 line

Care to send an updated patch on top of master doing that?

I was hoping that Eric would handle that :-)

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
#5 lore raw

PATCH 1/1 rustc: disable for ARMV7A with EABI

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Hi,

Quoted 7 lines
Quoted 5 lines

I agree that having positive logic would be nicer. It is a bit more complicated than this as we also should handle ARMV8A cores in ARM mode similar to how ve handle ARMV7A.

Care to send an updated patch on top of master doing that?

I was hoping that Eric would handle that :-)

Fine by me. Eric? ;)

Signature · 1 line
Bye, Peter Korsgaard