Skip to contentSkip to conversation

jq: compile as _GNU_SOURCE to fix segfault after compilation with gcc 6

PATCH New Thomas De Schampheleire 2 participants 3 messages Feb 19, 2018 – Apr 10, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 jq: compile as _GNU_SOURCE to fix segfault after compilation with gcc 6

When compiling host-jq with gcc 6+, running it gives an immediate segfault. Reported upstream: https://github.com/stedolan/jq/issues/1598

The issue can be solved by compiling with _GNU_SOURCE as extra preprocessor define. Once the issue is solved upstream, this change can be reverted.

As the issue will normally be the same for target, apply the same fix there.

---
 package/jq/jq.mk | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
package/jq/jq.mk +4 -2
index aecdba2280..79629faa5e 100644
@@ -11,8 +11,10 @@ JQ_LICENSE_FILES = COPYING
 JQ_INSTALL_STAGING = YES
 
 # uses c99 specific features
-JQ_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -std=c99"
-HOST_JQ_CONF_ENV += CFLAGS="$(HOST_CFLAGS) -std=c99"
+# _GNU_SOURCE added to fix gcc6+ host compilation
+# (https://github.com/stedolan/jq/issues/1598)
+JQ_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -std=c99 -D_GNU_SOURCE"
+HOST_JQ_CONF_ENV += CFLAGS="$(HOST_CFLAGS) -std=c99 -D_GNU_SOURCE"
 
 # jq explicitly enables maintainer mode, which we don't need/want
 JQ_CONF_OPTS += --disable-maintainer-mode
Signature · 1 line
2.13.6
#1 lore raw

PATCH 1/1 jq: compile as _GNU_SOURCE to fix segfault after compilation with gcc 6

Quoted 4 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas De Schampheleire <[email protected]> writes:

When compiling host-jq with gcc 6+, running it gives an immediate segfault. Reported upstream: https://github.com/stedolan/jq/issues/1598

Ahh, so the issue is a missing prototype for strdup(), so the compiler defaults to int for the return type.

Quoted 6 lines

The issue can be solved by compiling with _GNU_SOURCE as extra preprocessor define. Once the issue is solved upstream, this change can be reverted.

As the issue will normally be the same for target, apply the same fix there.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 jq: compile as _GNU_SOURCE to fix segfault after compilation with gcc 6

In reply to Thomas De Schampheleire
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas De Schampheleire <[email protected]> writes:

When compiling host-jq with gcc 6+, running it gives an immediate segfault. Reported upstream: https://github.com/stedolan/jq/issues/1598

The issue can be solved by compiling with _GNU_SOURCE as extra preprocessor define. Once the issue is solved upstream, this change can be reverted.

As the issue will normally be the same for target, apply the same fix there.

Committed to 2017.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard