Skip to contentSkip to conversation

ARM: dts: armada-370-rn104: add pinmuxing for i2c0

PATCH New Uwe Kleine-König 2 participants 4 messages Sep 29, 2016 – Oct 6, 2016 Device tree bindings

lore
Share & tools
lore

Uwe Kleine-König

author
#0 lore raw

PATCH 1/2 ARM: dts: armada-370-rn104: add pinmuxing for i2c0

Up to now a working i2c bus depended on the bootloader to configure the pinmuxing. Make it explicit.

As a side effect this change makes i2c work in barebox.

Signed-off-by Uwe Kleine-K?nig <[email protected]>
---
 arch/arm/boot/dts/armada-370-netgear-rn104.dts | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/armada-370-netgear-rn104.dts +4 -0
index 11565752b9f6..d44a850d879c 100644
@@ -128,6 +128,10 @@
 			i2c at 11000 {
 				compatible = "marvell,mv64xxx-i2c";
 				clock-frequency = <100000>;
+
+				pinctrl-0 = <&i2c0_pins>;
+				pinctrl-names = "default";
+
 				status = "okay";
 
 				isl12057: isl12057 at 68 {
Signature · 1 line
2.8.1
author
#1 lore raw

PATCH 2/2 ARM: dts: armada-370-rn104: drop specification of compatible for i2c0

The compatible string is already provided by armada-370.dtsi.

Signed-off-by Uwe Kleine-K?nig <[email protected]>
---
 arch/arm/boot/dts/armada-370-netgear-rn104.dts | 1 -
 1 file changed, 1 deletion(-)
arch/arm/boot/dts/armada-370-netgear-rn104.dts +0 -1
index d44a850d879c..14c379699350 100644
@@ -126,7 +126,6 @@
 			};
 
 			i2c at 11000 {
-				compatible = "marvell,mv64xxx-i2c";
 				clock-frequency = <100000>;
 
 				pinctrl-0 = <&i2c0_pins>;
Signature · 1 line
2.8.1
#2 lore raw

PATCH 2/2 ARM: dts: armada-370-rn104: drop specification of compatible for i2c0

Hi Uwe,

Quoted 3 lines · Uwe Kleine-K?nig

The compatible string is already provided by armada-370.dtsi.

Signed-off-by Uwe Kleine-K?nig <[email protected]>

Applied on mvebu/dt-4.10

Thanks,

Gregory

Quoted 19 lines
---
 arch/arm/boot/dts/armada-370-netgear-rn104.dts | 1 -
 1 file changed, 1 deletion(-)
arch/arm/boot/dts/armada-370-netgear-rn104.dts +0 -1
index d44a850d879c..14c379699350 100644
@@ -126,7 +126,6 @@
 			};
 
 			i2c at 11000 {
-				compatible = "marvell,mv64xxx-i2c";
 				clock-frequency = <100000>;
 
 				pinctrl-0 = <&i2c0_pins>;
Signature · 1 line
2.8.1
Signature · 4 lines
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#3 lore raw

PATCH 1/2 ARM: dts: armada-370-rn104: add pinmuxing for i2c0

In reply to Uwe Kleine-König

Hi Uwe,

Quoted 6 lines · Uwe Kleine-K?nig

Up to now a working i2c bus depended on the bootloader to configure the pinmuxing. Make it explicit.

As a side effect this change makes i2c work in barebox.

Signed-off-by Uwe Kleine-K?nig <[email protected]>

Applied on mvebu/dt-4.10

Thanks,

Gregory

Quoted 22 lines
---
 arch/arm/boot/dts/armada-370-netgear-rn104.dts | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/armada-370-netgear-rn104.dts +4 -0
index 11565752b9f6..d44a850d879c 100644
@@ -128,6 +128,10 @@
 			i2c at 11000 {
 				compatible = "marvell,mv64xxx-i2c";
 				clock-frequency = <100000>;
+
+				pinctrl-0 = <&i2c0_pins>;
+				pinctrl-names = "default";
+
 				status = "okay";
 
 				isl12057: isl12057 at 68 {
Signature · 1 line
2.8.1
Signature · 4 lines
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com