Skip to contentSkip to conversation

ltrace: disable elfutils unwinding when libunwind is used

PATCH New Baruch Siach 2 participants 2 messages Dec 9, 2014

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 ltrace: disable elfutils unwinding when libunwind is used

ltrace can't use both. Use --with-elfutils=no to disable use of elfutils (libdwfl) for unwinding.

Note that elfutils (libelf) is still a mandatory dependency regardless of --with-elfutils.

Fixes:
http://autobuild.buildroot.net/results/a3c/a3c1647578cdeda3aaf672084a9a893f06dbad26/
http://autobuild.buildroot.net/results/fdb/fdb7e760faeda77b263a6dac3e322a25b53e67ff/
http://autobuild.buildroot.net/results/70a/70a0614ca7baf6a46898834a87cd46865f6e3385/

---
v2:
* Improve commit log; note that elfutils is a dependency anyway
* Add code comment

---
 package/ltrace/ltrace.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
package/ltrace/ltrace.mk +3 -1
index 5c9549f4019b..7f00ce324e9c 100644
@@ -21,7 +21,9 @@ LTRACE_POST_PATCH_HOOKS += LTRACE_CREATE_CONFIG_M4
 # We don't normally do so for uClibc and we can't know if it's external
 ifeq ($(BR2_PACKAGE_LIBUNWIND),y)
 ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),)
-LTRACE_CONF_OPTS += --with-libunwind=yes
+# --with-elfutils only selects unwinding support backend. elfutils is a
+# mandatory dependency regardless.
+LTRACE_CONF_OPTS += --with-libunwind=yes --with-elfutils=no
 LTRACE_DEPENDENCIES += libunwind
 else
 LTRACE_CONF_OPTS += --with-libunwind=no
Signature · 1 line
2.1.3
#1 lore raw

PATCH v2 1/1 ltrace: disable elfutils unwinding when libunwind is used

Quoted 13 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Baruch" == Baruch Siach <[email protected]> writes:

ltrace can't use both. Use --with-elfutils=no to disable use of elfutils (libdwfl) for unwinding.

Note that elfutils (libelf) is still a mandatory dependency regardless of --with-elfutils.

Fixes:
http://autobuild.buildroot.net/results/a3c/a3c1647578cdeda3aaf672084a9a893f06dbad26/
http://autobuild.buildroot.net/results/fdb/fdb7e760faeda77b263a6dac3e322a25b53e67ff/
http://autobuild.buildroot.net/results/70a/70a0614ca7baf6a46898834a87cd46865f6e3385/

Quoted 5 lines

---
v2:
* Improve commit log; note that elfutils is a dependency anyway
* Add code comment

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard