pakage/erlang: fix host build without termcap (curses) library
PATCH 1/1 pakage/erlang: fix host build without termcap (curses) library
We do not need termcap (curses) support in the host variant of erlang.
Fixes a bunch of autobuild failures;
http://autobuild.buildroot.net/results/4be/4bef658b6815929058c769037211f7e0fc8d1f9c/ http://autobuild.buildroot.net/results/726/72619ed15590a3a5a41b7c398d973766ecab0a2e/ http://autobuild.buildroot.net/results/366/366439438549d5f7656be72f71dae3bb5f99c6b2/ ...
---
Cc-ing Nathaniel, as all failures happen on his build server. Thomas and Nathaniel, could you please review the setting of that autobuild server? And the others as well?
It seems legit ncurses is missing on a build server, but we did not notice, because we do require it for menuconfig and nconfig, so virtually everyone has it, and it is most probably installed on other autobuild servers because owners want to be able to run menuconfig on them to debug stuff.
Care to have a look, please?
Regards,
Yann E. MORIN.
--- package/erlang/erlang.mk | 2 ++ 1 file changed, 2 insertions(+)
package/erlang/erlang.mk +2 -0
@@ -27,6 +27,8 @@ ERLANG_CONF_OPTS = --without-javac HOST_ERLANG_DEPENDENCIES = host-openssl HOST_ERLANG_CONF_OPTS = --without-javac --with-ssl=$(HOST_DIR)/usr +HOST_ERLANG_CONF_OPTS += --without-termcap + ifeq ($(BR2_PACKAGE_NCURSES),y) ERLANG_CONF_OPTS += --with-termcap ERLANG_DEPENDENCIES += ncurses
Signature · 1 line
1.9.1
PATCH 1/1 pakage/erlang: fix host build without termcap (curses) library
Quoted 5 lines · Yann E. MORIN
Cc-ing Nathaniel, as all failures happen on his build server. Thomas and Nathaniel, could you please review the setting of that autobuild server? And the others as well?
It seems legit ncurses is missing on a build server, but we did not
notice,
Quoted 8 lines
because we do require it for menuconfig and nconfig, so virtually everyone has it, and it is most probably installed on other autobuild servers because owners want to be able to run menuconfig on them to debug stuff.
Care to have a look, please?
Regards,
Yann E. MORIN.
I haven't installed libncurses-dev per the discussion we had a few weeks/months back. (Basically only use the system's ncurses for 'make *config', and in all other cases build it)
I haven't heard otherwise, and this is also causing failures in host-mysql (IIRC).
If you both believe that I should install it, I will, but I still believe it is better to build host-ncurses.
Thanks, Nathaniel.
PATCH 1/1 pakage/erlang: fix host build without termcap (curses) library
Nathaniel, All,
On 2014-11-18 15:59 +0800, Nathaniel Roach spake thusly:
Quoted 11 lines · Yann E. MORIN
Quoted 5 lines
Cc-ing Nathaniel, as all failures happen on his build server. Thomas and Nathaniel, could you please review the setting of that autobuild server? And the others as well?
It seems legit ncurses is missing on a build server, but we did not
notice,
Quoted 4 lines
because we do require it for menuconfig and nconfig, so virtually everyone has it, and it is most probably installed on other autobuild servers because owners want to be able to run menuconfig on them to debug stuff.
Quoted 8 lines
Quoted 4 lines
Care to have a look, please?
Regards,
Yann E. MORIN.I haven't installed libncurses-dev per the discussion we had a few weeks/months back. (Basically only use the system's ncurses for 'make *config', and in all other cases build it)
Ah, OK. I've overlooked that discussion, then. Thanks!
Quoted 5 lines
I haven't heard otherwise, and this is also causing failures in host-mysql (IIRC).
If you both believe that I should install it, I will, but I still believe it is better to build host-ncurses.
Yes, I fully agree with this. No need to fix your autobuild instance.
Thank you!
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/1 pakage/erlang: fix host build without termcap (curses) library
In reply to Yann E. MORINDear Yann E. MORIN,
Quoted 3 lines · Yann E. MORIN
Cc-ing Nathaniel, as all failures happen on his build server. Thomas and Nathaniel, could you please review the setting of that autobuild server? And the others as well?
We already discussed this on the mailing list some time ago. Nathaniel's build server is the only one where libncurses-dev is not installed in the system. And since libncurses-dev is not part of our mandatory dependencies (someone could very well use gconfig or xconfig only, for example), we thought that keeping Nathaniel's configuration as is was a good way of catching the cases where we have a missing dependency on host-ncurses.
I remember we even had a discussion to decide whether we should build host-ncurses in such cases, or whether we should make libncurses-dev a hard dependency of Buildroot, and Peter decided that building host-ncurses was the right solution.
Best regards,
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
PATCH 1/1 pakage/erlang: fix host build without termcap (curses) library
Thomas, All,
On 2014-11-18 09:31 +0100, Thomas Petazzoni spake thusly:
Quoted 13 lines · Yann E. MORIN
Quoted 3 lines
Cc-ing Nathaniel, as all failures happen on his build server. Thomas and Nathaniel, could you please review the setting of that autobuild server? And the others as well?
We already discussed this on the mailing list some time ago. Nathaniel's build server is the only one where libncurses-dev is not installed in the system. And since libncurses-dev is not part of our mandatory dependencies (someone could very well use gconfig or xconfig only, for example), we thought that keeping Nathaniel's configuration as is was a good way of catching the cases where we have a missing dependency on host-ncurses.
Quoted 4 lines
I remember we even had a discussion to decide whether we should build host-ncurses in such cases, or whether we should make libncurses-dev a hard dependency of Buildroot, and Peter decided that building host-ncurses was the right solution.
I fully back this resolution. It is very often that a build server (whether it is for us to do autobuilds, or a production build server) lacks such libraries.
So, we have to fix such build failures by either:
- adding a dependency on host-ncurses, or
- disabling ncurses/termcap support for the host tools if it makes sense and it is possible, otherwise revert to depending on host-ncurses.
Thank you!
Regards,
Yann E. MORIN.
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/1 pakage/erlang: fix host build without termcap (curses) library
In reply to Yann E. MORINQuoted 4 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Yann" == Yann E MORIN <[email protected]> writes:
We do not need termcap (curses) support in the host variant of erlang. Fixes a bunch of autobuild failures;
Quoted 8 lines
http://autobuild.buildroot.net/results/4be/4bef658b6815929058c769037211f7e0fc8d1f9c/ http://autobuild.buildroot.net/results/726/72619ed15590a3a5a41b7c398d973766ecab0a2e/ http://autobuild.buildroot.net/results/366/366439438549d5f7656be72f71dae3bb5f99c6b2/ ...Signed-off-by "Yann E. MORIN" <[email protected]>Cc Nathaniel Roach <[email protected]>Cc Thomas Petazzoni <[email protected]>
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard