Skip to contentSkip to conversation

uclibc: disable parallel build for uClibc 0.9.31

PATCH New Alexey Brodkin 2 participants 2 messages Jun 30, 2014 – Jul 1, 2014

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 uclibc: disable parallel build for uClibc 0.9.31

This is only required for uClibc 0.9.31 and this veriosn is only used by AVR32 so could be safely removed together with AVR32.

Even 0.9.32 builds well in parallel (at least on x86) so IMHO there's no need in >= 0.9.33, just disable for a particular broken version.

Cc Anton Kolesov <[email protected]>
Cc Peter Korsgaard <[email protected]>
Cc Gustavo Zacarias <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Thomas De Schampheleire <[email protected]>

---
In v2 I replaced MAKE_UCLIBC with UCLIBC_MAKE as suggested by Thomas.

---
 package/uclibc/uclibc.mk | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)
package/uclibc/uclibc.mk +13 -1
index 28a8a08..caa5553 100644
@@ -493,8 +493,20 @@ define UCLIBC_BUILD_TEST_SUITE
 endef
 endif
 
+# In uClibc 0.9.31 parallel building is broken so we have to disable it
+# Fortunately uClibc 0.9.31 is only used by AVR32 and in its turn AVR32 is
+# about to be removed from buildroot.
+#
+# So as soon as AVR32 is removed please revert this patch so instead of
+# UCLIBC_MAKE normal "MAKE" is used in UCLIBC_BUILD_CMDS
+ifeq ($(BR2_UCLIBC_VERSION_0_9_31),y)
+	UCLIBC_MAKE = $(MAKE1)
+else
+	UCLIBC_MAKE = $(MAKE)
+endif
+
 define UCLIBC_BUILD_CMDS
-	$(MAKE) -C $(@D) \
+	$(UCLIBC_MAKE) -C $(@D) \
 		$(UCLIBC_MAKE_FLAGS) \
 		PREFIX= \
 		DEVEL_PREFIX=/ \
Signature · 1 line
1.9.3
#1 lore raw

PATCH v2 1/1 uclibc: disable parallel build for uClibc 0.9.31

Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Alexey" == Alexey Brodkin <[email protected]> writes:

This is only required for uClibc 0.9.31 and this veriosn is only used by AVR32 so could be safely removed together with AVR32.

Even 0.9.32 builds well in parallel (at least on x86) so IMHO there's no need in >= 0.9.33, just disable for a particular broken version.

Quoted 8 lines
Cc Anton Kolesov <[email protected]>
Cc Peter Korsgaard <[email protected]>
Cc Gustavo Zacarias <[email protected]>
Cc Thomas Petazzoni <[email protected]>
Cc Thomas De Schampheleire <[email protected]>

---
In v2 I replaced MAKE_UCLIBC with UCLIBC_MAKE as suggested by Thomas.

Committed, thanks.

Signature · 2 lines
Venlig hilsen,
Peter Korsgaard