Skip to contentSkip to conversation

manual: fix C++ suport in libc case, fix indentation

PATCH New Yann E. MORIN 4 participants 4 messages May 2, 2014

lore
Share & tools
lore

Yann E. MORIN

author
#0 lore raw

PATCH 1/1 manual: fix C++ suport in libc case, fix indentation

From: "Yann E. MORIN" <[email protected]>

The manual has this sentence for the dependency on a C library *and* a toolchain feature:

foo needs an (e)glibc toolchain, or foo needs an (e)glibc toolchain w/ C++ support

And then, just below, the comment text for C++ is just 'C++', not 'C++ support'.

Fix that, and add a bit of indentation too.

Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Samuel Martin <[email protected]>
---
 docs/manual/adding-packages-directory.txt | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
docs/manual/adding-packages-directory.txt +2 -2
index 5d4d5d9..3cf3afa 100644
@@ -227,10 +227,10 @@ use in the comment.
 
 * C library
 ** Dependency symbol: +BR2_TOOLCHAIN_USES_GLIBC+,
-+BR2_TOOLCHAIN_USES_UCLIBC+
+   +BR2_TOOLCHAIN_USES_UCLIBC+
 ** Comment string: for the C library, a slightly different comment text
    is used: +foo needs an (e)glibc toolchain+, or `foo needs an (e)glibc
-   toolchain w/ C++ support`
+   toolchain w/ C++`
 
 * C++ support
 ** Dependency symbol: +BR2_INSTALL_LIBSTDCPP+
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 manual: fix C++ suport in libc case, fix indentation

Quoted 8 lines · Yann E. MORIN

From: "Yann E. MORIN" <[email protected]>

The manual has this sentence for the dependency on a C library *and* a toolchain feature:

foo needs an (e)glibc toolchain, or foo needs an (e)glibc toolchain w/ C++ support

Quoted 7 lines

And then, just below, the comment text for C++ is just 'C++', not 'C++ support'.

Fix that, and add a bit of indentation too.

Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Samuel Martin <[email protected]>
Acked-by Thomas De Schampheleire <[email protected]>

I checked the Config.in files and fortunately this mistake was not yet applied.

Thanks for noticing!

Thomas

#2 lore raw

PATCH 1/1 manual: fix C++ suport in libc case, fix indentation

Hi Yann, all,

in the patch subject:
s/suport/support/

Quoted 12 lines · Thomas De Schampheleire
Quoted 11 lines · Yann E. MORIN

From: "Yann E. MORIN" <[email protected]>

The manual has this sentence for the dependency on a C library *and* a toolchain feature:

foo needs an (e)glibc toolchain, or foo needs an (e)glibc toolchain w/ C++ support

And then, just below, the comment text for C++ is just 'C++', not 'C++ support'.

Quoted 6 lines
Quoted 4 lines

Fix that, and add a bit of indentation too.

Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Samuel Martin <[email protected]>
Acked-by Thomas De Schampheleire <[email protected]>

Otherwise:

Acked-by Samuel Martin <[email protected]>
Signature · 1 line
Samuel
#3 lore raw

PATCH 1/1 manual: fix C++ suport in libc case, fix indentation

In reply to Yann E. MORIN
Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Yann" == Yann E MORIN <[email protected]> writes:

From: "Yann E. MORIN" <[email protected]>
The manual has this sentence for the dependency on a C library *and* a toolchain feature:

foo needs an (e)glibc toolchain, or foo needs an (e)glibc toolchain w/ C++ support

Quoted 7 lines

And then, just below, the comment text for C++ is just 'C++', not 'C++ support'.

Fix that, and add a bit of indentation too.

Signed-off-by "Yann E. MORIN" <[email protected]>
Cc Samuel Martin <[email protected]>

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard