Skip to contentSkip to conversation

ti-gfx.mk typo corrected

PATCH New Martin Creutziger 3 participants 5 messages Sep 2, 2013 – Sep 3, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ti-gfx.mk typo corrected

There is a simple typo in package/ti-gfx/ti-gfx.mk, which the following patch corrects:

---

ti-gfx/ti-gfx.mk +1 -1
Index: package/ti-gfx/ti-gfx.mk
===================================================================
@@ -29,7 +29,7 @@
  TI_GFX_PLATFORM = omap3630
  endif
  ifeq ($(BR2_PACKAGE_TI_GFX_ES6),y)
-TI_GFX_OMPAES = 6.x
+TI_GFX_OMAPES = 6.x
  TI_GFX_PLATFORM = ti81xx
  endif
  ifeq ($(BR2_PACKAGE_TI_GFX_ES8),y)

--

#1 lore raw

PATCH 1/1 ti-gfx.mk typo corrected

Dear Martin Creutziger,

Quoted 4 lines · Martin Creutziger

There is a simple typo in package/ti-gfx/ti-gfx.mk, which the following patch corrects:

Indeed, thanks!

Martin, does this mean you are successfully using the ti-gfx package? If so, can you tell us a bit more (which hardware platform, what software stack on top of OpenGL, etc.) ? Our Google Summer of Code student Spenser Gilliland is still working on improving OpenGL support in Buildroot, so we're definitely interested in getting feedback.

Thanks a lot!

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#2 lore raw

PATCH 1/1 ti-gfx.mk typo corrected

In reply to Martin Creutziger
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Martin" == Martin Creutziger <[email protected]> writes:

Martin> There is a simple typo in package/ti-gfx/ti-gfx.mk, which the Martin> following patch corrects:

Martin> Signed-off-by: Martin Creutziger <[email protected]> Martin> ---
Martin> Index: package/ti-gfx/ti-gfx.mk
Martin> ===================================================================
Martin> --- package/ti-gfx/ti-gfx.mk (revision 14043)
Martin> +++ package/ti-gfx/ti-gfx.mk (working copy)

Committed, thanks.

In the future, please consider creating the patch using git so it can be directly committed with git am (or atleast add one more directory level, as git am expects patch -p1 format).

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH 1/1 ti-gfx.mk typo corrected

Quoted 12 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Martin" == Martin Creutziger <[email protected]> writes:

Martin> There is a simple typo in package/ti-gfx/ti-gfx.mk, which the Martin> following patch corrects:

Martin> Signed-off-by: Martin Creutziger <[email protected]> Martin> ---
Martin> Index: package/ti-gfx/ti-gfx.mk
Martin> ===================================================================
Martin> --- package/ti-gfx/ti-gfx.mk (revision 14043)
Martin> +++ package/ti-gfx/ti-gfx.mk (working copy)

Quoted 6 lines

Committed, thanks.

In the future, please consider creating the patch using git so it can be directly committed with git am (or atleast add one more directory level, as git am expects patch -p1 format).

Hello Peter,

as this was my first patch here on the mailing list, I already expected that I won't get it 100% right ;)

I created it directly out of our SVN repository, but thanks for the pointers about the expected format - I'll try to get closer to it next time. :)

BR,
Martin

#4 lore raw

PATCH 1/1 ti-gfx.mk typo corrected

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Martin" == Martin Creutziger <[email protected]> writes:

Hi Martin,

Martin> as this was my first patch here on the mailing list, I already Martin> expected that I won't get it 100% right ;)

Martin> I created it directly out of our SVN repository, but thanks for the Martin> pointers about the expected format - I'll try to get closer to it next Martin> time. :)

Don't worry, and thanks for submitting the fix!

Signature · 1 line
Bye, Peter Korsgaard