Skip to contentSkip to conversation

nettle: fix ARM NEON breakage

PATCH New Gustavo Zacarias 2 participants 2 messages May 5, 2013

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 nettle: fix ARM NEON breakage

Nettle's ARM NEON optimizations use some assembly constructs that aren't friendly with binutils < 2.21, so just disable it for external toolchains or internal with an unsupported version.
http://autobuild.buildroot.net/results/3c6f91379f90d438b4da3dd330cf89e1dd746aaf/

---
 package/nettle/nettle.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/nettle/nettle.mk +2 -2
index b3d2730..131826e 100644
@@ -10,8 +10,8 @@ ifeq ($(BR2_arm7tdmi)$(BR2_arm720t)$(BR2_arm920t)$(BR2_arm922t)$(BR2_arm926t)$(B
 NETTLE_CONF_OPT += --disable-assembler
 endif
 
-# ARM NEON
-ifeq ($(BR2_ARM_CPU_HAS_NEON),y)
+# ARM NEON, requires binutils 2.21+
+ifeq ($(BR2_ARM_CPU_HAS_NEON)$(BR2_TOOLCHAIN_BUILDROOT)$(BR2_BINUTILS_VERSION_2_20_1),yy)
 NETTLE_CONF_OPT += --enable-arm-neon
 else
 NETTLE_CONF_OPT += --disable-arm-neon
Signature · 1 line
1.8.1.5
#1 lore raw

PATCH v2 1/1 nettle: fix ARM NEON breakage

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Gustavo" == Gustavo Zacarias <[email protected]> writes:

Gustavo> Nettle's ARM NEON optimizations use some assembly constructs Gustavo> that aren't friendly with binutils < 2.21, so just disable it Gustavo> for external toolchains or internal with an unsupported
Gustavo> version.
Gustavo> http://autobuild.buildroot.net/results/3c6f91379f90d438b4da3dd330cf89e1dd746aaf/

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard