Skip to contentSkip to conversation

ARM: OMAP2+: PM: fix return value check in omap2_set_init_voltage()

PATCH New Wei Yongjun 3 participants 3 messages Sep 27, 2012 – Oct 2, 2012

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: OMAP2+: PM: fix return value check in omap2_set_init_voltage()

From: Wei Yongjun <[email protected]>

In case of error, the function voltdm_lookup() returns NULL not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test.

dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)

---
 arch/arm/mach-omap2/pm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-omap2/pm.c +1 -1
index 9cb5ced..ab15e5c 100644
@@ -176,7 +176,7 @@ static int __init omap2_set_init_voltage(char *vdd_name, char *clk_name,
 	}
 
 	voltdm = voltdm_lookup(vdd_name);
-	if (IS_ERR(voltdm)) {
+	if (!voltdm) {
 		pr_err("%s: unable to get vdd pointer for vdd_%s\n",
 			__func__, vdd_name);
 		goto exit;
#1 lore raw

PATCH 1/1 ARM: OMAP2+: PM: fix return value check in omap2_set_init_voltage()

Quoted 19 lines · Wei Yongjun

From: Wei Yongjun <[email protected]>

In case of error, the function voltdm_lookup() returns NULL not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test.

dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)

---
 arch/arm/mach-omap2/pm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-omap2/pm.c +0 -0
index 9cb5ced..ab15e5c 100644

arch/arm/mach-omap2/pm.c static int __init omap2_set_init_voltage(char *vdd_name, char *clk_name, · line 182

Quoted 8 lines
arch/arm/mach-omap2/pm.c +1 -1
@@ -176,7 +176,7 @@ static int __init omap2_set_init_voltage(char *vdd_name, char *clk_name,
        }
 
        voltdm = voltdm_lookup(vdd_name);
-       if (IS_ERR(voltdm)) {
+       if (!voltdm) {
                pr_err("%s: unable to get vdd pointer for vdd_%s\n",
                        __func__, vdd_name);
                goto exit;

This looks good, so here is the ack:

Thanks,
Jean

Quoted 5 lines

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

#2 lore raw

PATCH 1/1 ARM: OMAP2+: PM: fix return value check in omap2_set_init_voltage()

Quoted 30 lines · Jean Pihet
Quoted 19 lines · Wei Yongjun

From: Wei Yongjun <[email protected]>

In case of error, the function voltdm_lookup() returns NULL not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test.

dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)

---
 arch/arm/mach-omap2/pm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-omap2/pm.c +0 -0
index 9cb5ced..ab15e5c 100644

arch/arm/mach-omap2/pm.c static int __init omap2_set_init_voltage(char *vdd_name, char *clk_name, · line 182

Quoted 8 lines
arch/arm/mach-omap2/pm.c +1 -1
@@ -176,7 +176,7 @@ static int __init omap2_set_init_voltage(char *vdd_name, char *clk_name,
        }
 
        voltdm = voltdm_lookup(vdd_name);
-       if (IS_ERR(voltdm)) {
+       if (!voltdm) {
                pr_err("%s: unable to get vdd pointer for vdd_%s\n",
                        __func__, vdd_name);
                goto exit;

This looks good, so here is the ack:

Quoted 1 line

Thanks, queuing this one for v3.7-rc.

Kevin