ARM: OMAP2+: PM: fix return value check in omap2_set_init_voltage()
PATCH 1/1 ARM: OMAP2+: PM: fix return value check in omap2_set_init_voltage()
From: Wei Yongjun <[email protected]>
In case of error, the function voltdm_lookup() returns NULL not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test.
dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)
--- arch/arm/mach-omap2/pm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-omap2/pm.c +1 -1
@@ -176,7 +176,7 @@ static int __init omap2_set_init_voltage(char *vdd_name, char *clk_name, } voltdm =voltdm_lookup (vdd_name); -if (IS_ERR (voltdm)) { +if (!voltdm) {pr_err ("%s: unable to get vdd pointer for vdd_%s\n" , __func__, vdd_name); goto exit;
PATCH 1/1 ARM: OMAP2+: PM: fix return value check in omap2_set_init_voltage()
Quoted 19 lines · Wei Yongjun
From: Wei Yongjun <[email protected]>
In case of error, the function
voltdm_lookup()returns NULL notERR_PTR(). TheIS_ERR()test in the return value check should be replaced with NULL test.dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)Signed-off-by Wei Yongjun <[email protected]>--- arch/arm/mach-omap2/pm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/mach-omap2/pm.c +0
-0
arch/arm/mach-omap2/pm.c static int __init omap2_set_init_voltage(char *vdd_name, char *clk_name, · line 182
Quoted 8 lines
arch/arm/mach-omap2/pm.c +1
-1@@ -176,7 +176,7 @@ static int __init omap2_set_init_voltage(char *vdd_name, char *clk_name, } voltdm =voltdm_lookup (vdd_name); -if (IS_ERR (voltdm)) { +if (!voltdm) {pr_err ("%s: unable to get vdd pointer for vdd_%s\n" , __func__, vdd_name); goto exit;
This looks good, so here is the ack:
Thanks,
Jean
Quoted 5 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 1/1 ARM: OMAP2+: PM: fix return value check in omap2_set_init_voltage()
Quoted 30 lines · Jean Pihet
Quoted 19 lines · Wei Yongjun
From: Wei Yongjun <[email protected]>
In case of error, the function
voltdm_lookup()returns NULL notERR_PTR(). TheIS_ERR()test in the return value check should be replaced with NULL test.dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)Signed-off-by Wei Yongjun <[email protected]>--- arch/arm/mach-omap2/pm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/mach-omap2/pm.c +0
-0arch/arm/mach-omap2/pm.c static int __init omap2_set_init_voltage(char *vdd_name, char *clk_name, · line 182
Quoted 8 lines
arch/arm/mach-omap2/pm.c +1
-1@@ -176,7 +176,7 @@ static int __init omap2_set_init_voltage(char *vdd_name, char *clk_name, } voltdm =voltdm_lookup (vdd_name); -if (IS_ERR (voltdm)) { +if (!voltdm) {pr_err ("%s: unable to get vdd pointer for vdd_%s\n" , __func__, vdd_name); goto exit;This looks good, so here is the ack:
Quoted 1 line
Acked-by Jean Pihet <[email protected]>
Thanks, queuing this one for v3.7-rc.
Kevin