Skip to contentSkip to conversation

Add sam-ba to at91sam926*_defconfig

PATCH New Alexandre Belloni 4 participants 11 messages Apr 11, 2012 – Apr 16, 2012 Arm/Microchip (AT91) SoC support

lore
Share & tools
lore

Alexandre Belloni

author
#0 lore raw

PATCH 1/1 Add sam-ba to at91sam926*_defconfig

Signed-off-by Alexandre Belloni <[email protected]>
---
 configs/at91sam9260dfc_defconfig |    4 ++++
 configs/at91sam9261ek_defconfig  |    5 +++++
 configs/at91sam9263ek_defconfig  |    4 ++++
 3 files changed, 13 insertions(+), 0 deletions(-)
configs/at91sam9260dfc_defconfig +4 -0
index 3cd58ac..921afa8 100644
@@ -2,6 +2,10 @@
 BR2_arm=y
 BR2_arm926t=y
 
+# Host utilities
+#
+BR2_PACKAGE_HOST_SAM_BA=y
+
 # First stage bootloader
 BR2_TARGET_AT91BOOTSTRAP=y
 BR2_TARGET_AT91BOOTSTRAP_BOARD="at91sam9260ek"
configs/at91sam9261ek_defconfig +5 -0
index 73edd89..b801bbe 100644
@@ -2,6 +2,11 @@
 BR2_arm=y
 BR2_arm926t=y
 
+
+# Host utilities
+#
+BR2_PACKAGE_HOST_SAM_BA=y
+
 # First stage bootloader
 BR2_TARGET_AT91BOOTSTRAP=y
 BR2_TARGET_AT91BOOTSTRAP_BOARD="at91sam9261ek"
configs/at91sam9263ek_defconfig +4 -0
index e4a44f1..2cd82c0 100644
@@ -2,6 +2,10 @@
 BR2_arm=y
 BR2_arm926t=y
 
+# Host utilities
+#
+BR2_PACKAGE_HOST_SAM_BA=y
+
 # First stage bootloader
 BR2_TARGET_AT91BOOTSTRAP=y
 BR2_TARGET_AT91BOOTSTRAP_BOARD="at91sam9263ek"
Signature · 1 line
1.7.5.4
author
#3 lore raw

PATCH 1/1 Add sam-ba to at91sam926*_defconfig

Quoted 5 lines · Jean-Christophe PLAGNIOL-VILLARD
Quoted 1 line
Acked-by Thomas Petazzoni <[email protected]>

this soc config I disagree

I run on ARM and PPC and samba is x86 only

That makes sense. Should we detect the host arch and disable sam-ba ?

I guess we can do that whitout overcomplicating the host infrastructure.

Signature · 1 line
Alexandre Belloni
#4 lore raw

PATCH 1/1 Add sam-ba to at91sam926*_defconfig

In reply to Jean-Christophe PLAGNIOL-VILLARD
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Jean-Christophe" == Jean-Christophe PLAGNIOL-VILLARD <[email protected]> writes:

Hi,

Jean-Christophe> this soc config I disagree

Jean-Christophe> I run on ARM and PPC and samba is x86 only

You build buildroot ON ARM/PPC? That's very uncommon (well, gcc110 is ppc64 - But still). Nevertheless, nothing breaks by including sam-ba in the build, your host dir just gets a little bit bigger. In this case I would say the advantage for the common case (build on x86 for at91 development) outweighs the minor disadvantage for your use case.

Signature · 1 line
Bye, Peter Korsgaard
#5 lore raw

PATCH 1/1 Add sam-ba to at91sam926*_defconfig

Quoted 6 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Jean-Christophe" == Jean-Christophe PLAGNIOL-VILLARD <[email protected]> writes:

Hi,

Jean-Christophe> this soc config I disagree

Quoted 7 lines

Jean-Christophe> I run on ARM and PPC and samba is x86 only

You build buildroot ON ARM/PPC? That's very uncommon (well, gcc110 is ppc64 - But still). Nevertheless, nothing breaks by including sam-ba in the build, your host dir just gets a little bit bigger. In this case I would say the advantage for the common case (build on x86 for at91 development) outweighs the minor disadvantage for your use case.

I've a quad Arm and a quad G4

except you expect a packet you install to work I expect to detect the HOST type and propose it only if it work

Best Regards,
J.

#6 lore raw

PATCH 1/1 Add sam-ba to at91sam926*_defconfig

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Jean-Christophe" == Jean-Christophe PLAGNIOL-VILLARD <[email protected]> writes:

Hi,

Quoted 5 lines
Quoted 5 lines

You build buildroot ON ARM/PPC? That's very uncommon (well, gcc110 is ppc64 - But still). Nevertheless, nothing breaks by including sam-ba in the build, your host dir just gets a little bit bigger. In this case I would say the advantage for the common case (build on x86 for at91 development) outweighs the minor disadvantage for your use case.

Jean-Christophe> I've a quad Arm and a quad G4

Both of those are significantly slower than a recent x86, but all the power to you for using it.

Jean-Christophe> except you expect a packet you install to work I Jean-Christophe> expect to detect the HOST type and propose it only if Jean-Christophe> it work

We don't have any concept of host type in Kconfig, so I don't see how we could possibly do that.

Signature · 1 line
Bye, Peter Korsgaard
#7 lore raw

PATCH 1/1 Add sam-ba to at91sam926*_defconfig

Quoted 15 lines · Peter Korsgaard
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Jean-Christophe" == Jean-Christophe PLAGNIOL-VILLARD <[email protected]> writes:

Hi,

Quoted 5 lines
Quoted 5 lines

You build buildroot ON ARM/PPC? That's very uncommon (well, gcc110 is ppc64 - But still). Nevertheless, nothing breaks by including sam-ba in the build, your host dir just gets a little bit bigger. In this case I would say the advantage for the common case (build on x86 for at91 development) outweighs the minor disadvantage for your use case.

Jean-Christophe> I've a quad Arm and a quad G4

Both of those are significantly slower than a recent x86, but all the power to you for using it.

Quoted 6 lines

Jean-Christophe> except you expect a packet you install to work I Jean-Christophe> expect to detect the HOST type and propose it only if Jean-Christophe> it work

We don't have any concept of host type in Kconfig, so I don't see how we could possibly do that.

I did it on dtc

HOSTOS := $(shell uname -s | tr '[:upper:]' '[:lower:]' | \
	    sed -e 's/\(cygwin\).*/cygwin/')

this work on unix

Best Regards,
J.

#8 lore raw

PATCH 1/1 Add sam-ba to at91sam926*_defconfig

Le Mon, 16 Apr 2012 14:34:29 +0200,
Jean-Christophe PLAGNIOL-VILLARD <[email protected]> a ?crit :

Quoted 6 lines

I did it on dtc

HOSTOS := $(shell uname -s | tr '[:upper:]' '[:lower:]' | \
	    sed -e 's/\(cygwin\).*/cygwin/')

this work on unix

But it does not allow to do Kconfig dependencies.

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#9 lore raw

PATCH 1/1 Add sam-ba to at91sam926*_defconfig

Quoted 11 lines · Thomas Petazzoni

Le Mon, 16 Apr 2012 14:34:29 +0200,
Jean-Christophe PLAGNIOL-VILLARD <[email protected]> a ?crit :

Quoted 6 lines

I did it on dtc

HOSTOS := $(shell uname -s | tr '[:upper:]' '[:lower:]' | \
	    sed -e 's/\(cygwin\).*/cygwin/')

this work on unix

But it does not allow to do Kconfig dependencies.

you can use env in Kconfig
option env="KERNELVERSION"

in barebox or kernel

Best Regards,
J.

#10 lore raw

PATCH 1/1 Add sam-ba to at91sam926*_defconfig

In reply to Alexandre Belloni
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Alexandre" == Alexandre Belloni <[email protected]> writes:

Alexandre> Signed-off-by: Alexandre Belloni <[email protected]> Alexandre> ---

 Alexandre>  configs/at91sam9260dfc_defconfig |    4 ++++
 Alexandre>  configs/at91sam9261ek_defconfig  |    5 +++++
 Alexandre>  configs/at91sam9263ek_defconfig  |    4 ++++

Alexandre> 3 files changed, 13 insertions(+), 0 deletions(-)

You forgot 9g20dfc. I've fixed that and committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard