Skip to contentSkip to conversation

OOPS on boot (hotplug related?)

2.6.10-rc2-mm1 Christian Axelsson 3 participants 4 messages Nov 17, 2004 – Nov 18, 2004

lore
Share & tools
lore
#0 lore raw

Hi!
Im getting OOPSes on boot on my laptop. Output is copied by hand and Ive only included the parts that I *think* are useful:

VFS: Mounted root (reiser4 filesystem) readonly.
Freeing unused kernel memory: 176k freed

Unable to handle kernel NULL pointer dereference at virtual address 0000003c
 printing eip:
c01ea243
*pde = 00000000
Oops: 0000 [#1]
PREEMPT
Modules linked in:
CPU:    0
EIP:    0060:[<c01ea243>]   Not tainted VLI
EFLAGS: 00010286   (2.6.10-rc2-mm1)

EIP is at get_nonexclusive_access+0x13/0x40
eax: 00000000 ebx: dfbce730 ecx: 00000000 edx: dfbce6d8
esi: dfbce700 edi: dfbe44ec ebp: dfbce6d8 esp: dfbf1c10
ds: 007b es: 007b ss: 0068
Process hotplug (pid: 966, threadinfo=dfbf0000 task=dfbcba80)

Stack: c01e8f1f dfbce6d8 00000000 c01e8ee0 dfbe7360 00000000 dfbe44ec
       c014a547 dfbe44ec 080d8000 dfbf1c58 c0112d4d dfbd3080 dfbd2dc0
       00000000 dfbce7d0 00000001 dfbd3080 080d84d4 00000001 c014a9f0
Call Trace:
 [<c01e8f1f>] unix_file_filemap_nopage+0x3f/0x90
 [<c01e8ee0>] unix_file_filemap_nopage+0x0/0x90
 [<c014a547>] do_no_page+0xc7/0x360
 [<c0112d4d>] pte_alloc_one+0x1d/0x50
 [<c014a9f0>] handle_mm_fault+0xf0/0x1a0
 [<c013bba2>] generic_file_mmap+3ec/0x60e
 [<c011356c>] do_page_fault+0x3ec/0x60e

<snipped>

Code: 00 0f c1 10 0f 85 14 12 00 00 c3 8d b6 00 00 00 00 8d bc 27 00 00 00 00 b8 00 e0 ff ff 8b 54 24 04 21 e0 8b 00 8b 80 b8 04 00 <8b> 40 3c 8b 48 08 85 c9 75 0b 89 d0 ff 00 0f 88 f3 11 00 00 c3

This one is followed by two similar (probably identical) OOPSes and then it panics. Im using latest hotplug. Config attached.

Signature · 2 lines
Regards,
Christian
#1 lore raw
Quoted 6 lines · Christian Axelsson

I'm getting OOPSes on boot on my laptop. Output is copied by hand and Ive only included the parts that I *think* are useful:

...
EIP is at get_nonexclusive_access+0x13/0x40

Yup, seems that reiser4 broke. I've forwarded a copy of an earlier report to [email protected].

#2 lore raw

Andrew Morton <[email protected]> disait dernièrement que :

Quoted 10 lines
Quoted 6 lines · Christian Axelsson

I'm getting OOPSes on boot on my laptop. Output is copied by hand and Ive only included the parts that I *think* are useful:

...
EIP is at get_nonexclusive_access+0x13/0x40

Yup, seems that reiser4 broke. I've forwarded a copy of an earlier report to [email protected].

V. Saveliev provided the right fix shortly after I reported this oops.

I attach the patch

Regards,

# This is a BitKeeper generated diff -Nru style patch. #
# ChangeSet
# 2004/11/15 16:23:47+03:00 [email protected]
# unix_file_filemap_nopage: missing context creation is added
#

# plugin/file/file.c
#   2004/11/15 16:23:45+03:00 [email protected] +5 -1
#   unix_file_filemap_nopage: missing context creation is added
# 
diff -Nru a/plugin/file/file.c b/plugin/file/file.c
--- a/plugin/file/file.c	2004-11-17 09:36:11 +03:00
+++ b/plugin/file/file.c	2004-11-17 09:36:11 +03:00
@@ -1961,8 +1961,10 @@
 {
 	struct page *page;
 	struct inode *inode;
-
+	reiser4_context ctx;
+	
 	inode = area->vm_file->f_dentry->d_inode;
+	init_context(&ctx, inode->i_sb);

/* block filemap_nopage if copy on capture is processing with a node of this file */ down_read(&reiser4_inode_data(inode)->coc_sem);
@@ -1972,6 +1974,8 @@

drop_nonexclusive_access(unix_file_inode_data(inode)); up_read(&reiser4_inode_data(inode)->coc_sem);
+
+ reiser4_exit_context(&ctx);
return page;
}

Signature · 1 line
-- 
Quoted 1 line · Lisa R. Nelson

So much for a friendly group.

You really have seen nothing yet :-)

- Bas Mevissen on linux-kernel

#3 lore raw

Mathieu Segaud <[email protected]> disait dernièrement que :

Quoted 5 lines

V. Saveliev provided the right fix shortly after I reported this oops.

I attach the patch

Regards,

correcting myself, the patch I gave was to apply in fs/reiser4... by the way, thanks go to Vladimir Saveliev.

fs/reiser4/plugin/file/file.c +5 -1
@@ -1961,8 +1961,10 @@
 {
 	struct page *page;
 	struct inode *inode;
-
+	reiser4_context ctx;
+	
 	inode = area->vm_file->f_dentry->d_inode;
+	init_context(&ctx, inode->i_sb);
 
 	/* block filemap_nopage if copy on capture is processing with a node of this file */
 	down_read(&reiser4_inode_data(inode)->coc_sem);
@@ -1972,6 +1974,8 @@
 
 	drop_nonexclusive_access(unix_file_inode_data(inode));
 	up_read(&reiser4_inode_data(inode)->coc_sem);
+
+	reiser4_exit_context(&ctx);
 	return page;
 }
 
Signature · 4 lines
-- 
"Just wait. My crystal ball is infallible."

	- Linus Torvalds