toolchain/toolchain-external: ensure BR2_TOOLCHAIN_EXTERNAL_PATH is set
PATCH 1/1 toolchain/toolchain-external: ensure BR2_TOOLCHAIN_EXTERNAL_PATH is set
--- toolchain/toolchain-external/pkg-toolchain-external.mk | 3 +++ 1 file changed, 3 insertions(+)
toolchain/toolchain-external/pkg-toolchain-external.mk +3 -0
@@ -69,6 +69,9 @@ ifeq ($(BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD),y) TOOLCHAIN_EXTERNAL_INSTALL_DIR = $(TOOLCHAIN_EXTERNAL_DOWNLOAD_INSTALL_DIR) else TOOLCHAIN_EXTERNAL_INSTALL_DIR = $(abspath $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_PATH))) +ifeq ($(TOOLCHAIN_EXTERNAL_INSTALL_DIR),) +$(error No external toolchain path set, check your BR2_TOOLCHAIN_EXTERNAL_PATH setting) +endif endif ifeq ($(TOOLCHAIN_EXTERNAL_INSTALL_DIR),)
Signature · 6 lines
2.25.1 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Quoted 10 lines · James Hilliard
Signed-off-by James Hilliard <[email protected]>--- toolchain/toolchain-external/pkg-toolchain-external.mk | 3 +++ 1 file changed, 3 insertions(+)toolchain/toolchain-external/pkg-toolchain-external.mk +0
-0
toolchain/toolchain-external/pkg-toolchain-external.mk ifeq ($(BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD),y) · line 72
Quoted 4 lines
toolchain/toolchain-external/pkg-toolchain-external.mk +1
-0@@ -69,6 +69,9 @@ ifeq ($(BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD),y) TOOLCHAIN_EXTERNAL_INSTALL_DIR = $(TOOLCHAIN_EXTERNAL_DOWNLOAD_INSTALL_DIR) else TOOLCHAIN_EXTERNAL_INSTALL_DIR = $(abspath $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_PATH))) +ifeq ($(TOOLCHAIN_EXTERNAL_INSTALL_DIR),)
You also need a condition on BR2_TOOLCHAIN_EXTERNAL, otherwise it will always
fail with an internal toolchain.
You also need a condition on BR_BUILDING, otherwise the error is printed even
in situations where an invalid configuration is allowed (e.g. 'make help').
I added both to all 4 patches and applied to master, thanks.
Regards,
Arnout
toolchain/toolchain-external/pkg-toolchain-external.mk ifeq ($(BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD),y) · line 77
Quoted 5 lines
toolchain/toolchain-external/pkg-toolchain-external.mk +2
-0+$(error No external toolchain path set, check your BR2_TOOLCHAIN_EXTERNAL_PATH setting) +endif endif ifeq ($(TOOLCHAIN_EXTERNAL_INSTALL_DIR),)
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Quoted 3 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"James" == James Hilliard <[email protected]> writes:
Signed-off-by James Hilliard <[email protected]>
Committed to 2022.02.x, thanks.
Signature · 5 lines
Bye, Peter Korsgaard _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot