Skip to contentSkip to conversation

design: fix computation of buffer log item bitmap size

PATCH In review Darrick J. Wong 2 participants 2 messages Jan 4, 2022

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 design: fix computation of buffer log item bitmap size

From: Darrick J. Wong <[email protected]>

Wengang Wang was trying to work through a buffer log item by consulting the ondisk format documentation, and was confused by the formula given in section 14.3.14 regarding the size of blf_data_map, aka the dirty bitmap for buffer log items. We noticed that the documentation doesn't match what the kernel actually does, so let's fix this.

---
 .../journaling_log.asciidoc                        |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
design/XFS_Filesystem_Structure/journaling_log.asciidoc +1 -1
index 8421a53..ddcb87f 100644
@@ -867,7 +867,7 @@ The size of +blf_data_map+, in 32-bit words.
 This variable-sized array acts as a dirty bitmap for the logged buffer.  Each
 1 bit represents a dirty region in the buffer, and each run of 1 bits
 corresponds to a subsequent log item containing the new contents of the buffer
-area.  Each bit represents +(blf_len * 512) / (blf_map_size * NBBY)+ bytes.
+area.  Each bit represents +XFS_BLF_CHUNK+ (i.e. 128) bytes.
 
 [[Buffer_Data_Log_Item]]
 === Buffer Data Log Item
Reviewed-by on v2 1/1
#1 lore raw
Quoted 10 lines · Darrick J. Wong

From: Darrick J. Wong <[email protected]>

Wengang Wang was trying to work through a buffer log item by consulting the ondisk format documentation, and was confused by the formula given in section 14.3.14 regarding the size of blf_data_map, aka the dirty bitmap for buffer log items. We noticed that the documentation doesn't match what the kernel actually does, so let's fix this.

Looks good.

Quoted 17 lines
---
 .../journaling_log.asciidoc                        |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
design/XFS_Filesystem_Structure/journaling_log.asciidoc +1 -1
index 8421a53..ddcb87f 100644
@@ -867,7 +867,7 @@ The size of +blf_data_map+, in 32-bit words.
 This variable-sized array acts as a dirty bitmap for the logged buffer.  Each
 1 bit represents a dirty region in the buffer, and each run of 1 bits
 corresponds to a subsequent log item containing the new contents of the buffer
-area.  Each bit represents +(blf_len * 512) / (blf_map_size * NBBY)+ bytes.
+area.  Each bit represents +XFS_BLF_CHUNK+ (i.e. 128) bytes.
 
 [[Buffer_Data_Log_Item]]
 === Buffer Data Log Item
Signature · 1 line
chandan