memcg_subgroup_charge: Remove memory limitation
PATCH 1/1 memcg_subgroup_charge: Remove memory limitation
From: Joerg Vehlow <[email protected]>
The test is supposed to verify, that memory used by a task is not migrated to a subgroup, when the task is migrated. In order to test this, it is not required, to limit the memory at all, because accounting is done anyway and the test checks the memory statistics.
Therefore all memory limiting is removed. This also gets rid of a faulty assumption when writing the test:
The test allocates 33 pages using mmap. It is expected, that it does not need more than 33 * pagesize of memory. But sometimes the kernel has to allocate new page tables. This is accounted as kmem AND user memory.
(See kernel doc cgroup-v1/memory.txt section 2.7) If this happend, the test failed, if the system has no swap, because the oom killer kills the process.
--- .../kernel/controllers/memcg/functional/memcg_lib.sh | 4 ---- .../memcg/functional/memcg_subgroup_charge.sh | 12 +----------- 2 files changed, 1 insertion(+), 15 deletions(-)
testcases/kernel/controllers/memcg/functional/memcg_lib.sh +0 -4
@@ -404,13 +404,9 @@ test_hugepage() } # Test the memory charge won't move to subgroup -# $1 - memory.limit_in_bytes in parent group -# $2 - memory.limit_in_bytes in sub group test_subgroup() { mkdir subgroup - echo $1 > memory.limit_in_bytes - echo $2 > subgroup/memory.limit_in_bytes tst_resm TINFO "Running memcg_process --mmap-anon -s $PAGESIZES" memcg_process --mmap-anon -s $PAGESIZES &
testcases/kernel/controllers/memcg/functional/memcg_subgroup_charge.sh +1 -11
@@ -26,7 +26,7 @@ ################################################################################ TCID="memcg_subgroup_charge" -TST_TOTAL=3 +TST_TOTAL=1 . memcg_lib.sh
@@ -36,15 +36,5 @@ testcase_1() test_subgroup $PAGESIZES $((2*PAGESIZES)) } -testcase_2() -{ - test_subgroup $PAGESIZES $PAGESIZES -} - -testcase_3() -{ - test_subgroup $PAGESIZES 0 -} - run_tests tst_exit
Signature · 1 line
2.20.1
PATCH 1/1 memcg_subgroup_charge: Remove memory limitation
Hi,
a little ping for this patch?
I recently updated the ltp suite for our tests to 20200930 and stumbled over this error again.
Any reason for not applying it?
J?rg
Quoted 71 lines · Joerg Vehlow
From: Joerg Vehlow <[email protected]>
The test is supposed to verify, that memory used by a task is not migrated to a subgroup, when the task is migrated. In order to test this, it is not required, to limit the memory at all, because accounting is done anyway and the test checks the memory statistics.
Therefore all memory limiting is removed. This also gets rid of a faulty assumption when writing the test:
The test allocates 33 pages using mmap. It is expected, that it does not need more than 33 * pagesize of memory. But sometimes the kernel has to allocate new page tables. This is accounted as kmem AND user memory.
(See kernel doccgroup-v1/memory.txtsection 2.7) If this happend, the test failed, if the system has no swap, because the oom killer kills the process.Signed-off-by Joerg Vehlow <[email protected]>--- .../kernel/controllers/memcg/functional/memcg_lib.sh | 4 ---- .../memcg/functional/memcg_subgroup_charge.sh | 12 +----------- 2 files changed, 1 insertion(+), 15 deletions(-)testcases/kernel/controllers/memcg/functional/memcg_lib.sh +0
-4@@ -404,13 +404,9 @@ test_hugepage() } # Test the memory charge won't move to subgroup -# $1 - memory.limit_in_bytes in parent group -# $2 - memory.limit_in_bytes in sub group test_subgroup() { mkdir subgroup - echo $1 > memory.limit_in_bytes - echo $2 > subgroup/memory.limit_in_bytes tst_resm TINFO "Running memcg_process --mmap-anon -s $PAGESIZES" memcg_process --mmap-anon -s $PAGESIZES &testcases/kernel/controllers/memcg/functional/memcg_subgroup_charge.sh +1
-11@@ -26,7 +26,7 @@ ################################################################################ TCID="memcg_subgroup_charge" -TST_TOTAL=3 +TST_TOTAL=1 . memcg_lib.sh@@ -36,15 +36,5 @@ testcase_1() test_subgroup $PAGESIZES $((2*PAGESIZES)) } -testcase_2() -{ - test_subgroup $PAGESIZES $PAGESIZES -} - -testcase_3() -{ - test_subgroup $PAGESIZES 0 -} - run_tests tst_exit
PATCH 1/1 memcg_subgroup_charge: Remove memory limitation
Hello,
Quoted 6 lines · Joerg Vehlow
Hi,
a little ping for this patch?
I recently updated the ltp suite for our tests to 20200930 and stumbled over this error again.
Any reason for not applying it?
If there was no response it's safe to assume it was forgotten about. Thanks for bumping it.
Quoted 21 lines
J?rg
Quoted 17 lines · Joerg Vehlow
From: Joerg Vehlow <[email protected]>
The test is supposed to verify, that memory used by a task is not migrated to a subgroup, when the task is migrated. In order to test this, it is not required, to limit the memory at all, because accounting is done anyway and the test checks the memory statistics.
Therefore all memory limiting is removed. This also gets rid of a faulty assumption when writing the test:
The test allocates 33 pages using mmap. It is expected, that it does not need more than 33 * pagesize of memory. But sometimes the kernel has to allocate new page tables. This is accounted as kmem AND user memory.
(See kernel doccgroup-v1/memory.txtsection 2.7) If this happend, the test failed, if the system has no swap, because the oom killer kills the process.
Perhaps they were checking for side effects from setting the limit... I think though it is correct to remove these limits.
Both check_stat lines are suspect to me as some unrelated tasklet could run in the processes context and allocate some memory. Possibly this should be converted to only an approximate check?
Quoted 54 lines
Quoted 54 lines
Signed-off-by Joerg Vehlow <[email protected]>--- .../kernel/controllers/memcg/functional/memcg_lib.sh | 4 ---- .../memcg/functional/memcg_subgroup_charge.sh | 12 +----------- 2 files changed, 1 insertion(+), 15 deletions(-)testcases/kernel/controllers/memcg/functional/memcg_lib.sh +0
-4@@ -404,13 +404,9 @@ test_hugepage() } # Test the memory charge won't move to subgroup -# $1 - memory.limit_in_bytes in parent group -# $2 - memory.limit_in_bytes in sub group test_subgroup() { mkdir subgroup - echo $1 > memory.limit_in_bytes - echo $2 > subgroup/memory.limit_in_bytes tst_resm TINFO "Running memcg_process --mmap-anon -s $PAGESIZES" memcg_process --mmap-anon -s $PAGESIZES &testcases/kernel/controllers/memcg/functional/memcg_subgroup_charge.sh +1
-11@@ -26,7 +26,7 @@ ################################################################################ TCID="memcg_subgroup_charge" -TST_TOTAL=3 +TST_TOTAL=1 . memcg_lib.sh@@ -36,15 +36,5 @@ testcase_1() test_subgroup $PAGESIZES $((2*PAGESIZES)) } -testcase_2() -{ - test_subgroup $PAGESIZES $PAGESIZES -} - -testcase_3() -{ - test_subgroup $PAGESIZES 0 -} - run_tests tst_exit
Signature · 2 lines
Thank you, Richard.