package/localedef: add missing dependeny on host-gawk
PATCH 1/1 package/localedef: add missing dependeny on host-gawk
While reviewing the patch [1], we noticed that host-gawk dependency was missing. I may trigger an issue if gawk is missing on the host since it's a "critical tool" [2].
Indeed, localedef package is actually glibc sources that check gawk host binary.
host-gawk is listed in glibc package dependency [3], so add it now.
[1] af90a104c06542a1bf5545eaf9b9c7beb7176e80
[2] https://sourceware.org/git/?p=glibc.git;a=blob;f=configure.ac;h=49b900c1ed68fa4dd1dadca809ceb6e8b237a89c;hb=9ea3686266dca3f004ba874745a4087a89682617#l1021
[3] https://git.buildroot.net/buildroot/tree/package/glibc/glibc.mk?h=2020.02#n38
--- package/localedef/localedef.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
package/localedef/localedef.mk +2 -1
@@ -14,7 +14,8 @@ HOST_LOCALEDEF_DL_SUBDIR = glibc HOST_LOCALEDEF_DEPENDENCIES = \ $(BR2_MAKE_HOST_DEPENDENCY) \ - host-bison + host-bison \ + host-gawk HOST_LOCALEDEF_CONF_ENV += ac_cv_prog_MAKE="$(BR2_MAKE)"
Signature · 1 line
2.24.1
Yann E. MORIN
AppliedPATCH 1/1 package/localedef: add missing dependeny on host-gawk
Romain, All,
On 2020-03-17 23:02 +0100, Romain Naour spake thusly:
Quoted 7 lines
While reviewing the patch [1], we noticed that host-gawk dependency was missing. I may trigger an issue if gawk is missing on the host since it's a "critical tool" [2].
Indeed, localedef package is actually glibc sources that check gawk host binary.
host-gawk is listed in glibc package dependency [3], so add it now.
Quoted 6 lines
[1]
af90a104c06542a1bf5545eaf9b9c7beb7176e80
[2] https://sourceware.org/git/?p=glibc.git;a=blob;f=configure.ac;h=49b900c1ed68fa4dd1dadca809ceb6e8b237a89c;hb=9ea3686266dca3f004ba874745a4087a89682617#l1021
[3] https://git.buildroot.net/buildroot/tree/package/glibc/glibc.mk?h=2020.02#n38Signed-off-by Romain Naour <[email protected]>Cc Yann E. MORIN <[email protected]>
Applied to master, thanks.
Regards,
Yann E. MORIN.
Quoted 21 lines
--- package/localedef/localedef.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)package/localedef/localedef.mk +2
-1@@ -14,7 +14,8 @@ HOST_LOCALEDEF_DL_SUBDIR = glibc HOST_LOCALEDEF_DEPENDENCIES = \ $(BR2_MAKE_HOST_DEPENDENCY) \ - host-bison + host-bison \ + host-gawk HOST_LOCALEDEF_CONF_ENV += ac_cv_prog_MAKE="$(BR2_MAKE)"Signature · 1 line
2.24.1
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------'
PATCH 1/1 package/localedef: add missing dependeny on host-gawk
In reply to Romain NaourQuoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Romain" == Romain Naour <[email protected]> writes:
While reviewing the patch [1], we noticed that host-gawk dependency was missing. I may trigger an issue if gawk is missing on the host since it's a "critical tool" [2].
Indeed, localedef package is actually glibc sources that check gawk host binary.
host-gawk is listed in glibc package dependency [3], so add it now.
Quoted 6 lines
[1]
af90a104c06542a1bf5545eaf9b9c7beb7176e80
[2] https://sourceware.org/git/?p=glibc.git;a=blob;f=configure.ac;h=49b900c1ed68fa4dd1dadca809ceb6e8b237a89c;hb=9ea3686266dca3f004ba874745a4087a89682617#l1021
[3] https://git.buildroot.net/buildroot/tree/package/glibc/glibc.mk?h=2020.02#n38Signed-off-by Romain Naour <[email protected]>Cc Yann E. MORIN <[email protected]>
Committed to 2020.02.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard