package/pkg-kconfig: fix reconfigure for kconfig packages
PATCH v3 1/1 package/pkg-kconfig: fix reconfigure for kconfig packages
From: Angelo Compagnucci <[email protected]>
Commit 4b81badbcc0b25678ac6627548160702731cf393
Currently, calling foo-reconfigure for a kconfig-based package will not re-trigger the configuration (kconfig-wise) step for the package.
was supposed to solve this problem and lately we had
Commit 05fea6e4a60a38a797d9bacbf318a2cd7dbd435f
infra/pkg-kconfig: do not rely on package's .config as a timestamp
that introduced the .stamp_dotconfig file.
For this reason, to trigger a kconfig package reconfigure is now necessary to remove the .stamp_dotconfig file.
--- package/pkg-kconfig.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
package/pkg-kconfig.mk +1 -1
@@ -175,7 +175,7 @@ $$($(2)_TARGET_CONFIGURE): $$($(2)_DIR)/.stamp_kconfig_fixup_done $(1)-clean-for-reconfigure: $(1)-clean-kconfig-for-reconfigure $(1)-clean-kconfig-for-reconfigure: - rm -f $$($(2)_DIR)/.stamp_kconfig_fixup_done + rm -f $$($(2)_DIR)/$$($(2)_KCONFIG_STAMP_DOTCONFIG) # Only enable the foo-*config targets when the package is actually enabled. # Note: the variable $(2)_KCONFIG_VAR is not related to the kconfig
Signature · 1 line
2.7.4
Thomas Petazzoni
AppliedPATCH v3 1/1 package/pkg-kconfig: fix reconfigure for kconfig packages
Quoted 15 lines · On Tue, 26 Nov 2019 14:24:58 +0100 Angelo Compagnucci…
From: Angelo Compagnucci <[email protected]>
Commit
4b81badbcc0b25678ac6627548160702731cf393Currently, calling foo-reconfigure for a kconfig-based package will not re-trigger the configuration (kconfig-wise) step for the package.
was supposed to solve this problem and lately we had
Commit
05fea6e4a60a38a797d9bacbf318a2cd7dbd435finfra/pkg-kconfig: do not rely on package's .config as a timestamp
that introduced the .stamp_dotconfig file.
Quoted 7 lines
For this reason, to trigger a kconfig package reconfigure is now necessary to remove the .stamp_dotconfig file.
Signed-off-by Angelo Compagnucci <[email protected]>--- package/pkg-kconfig.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to master, thanks.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
PATCH v3 1/1 package/pkg-kconfig: fix reconfigure for kconfig packages
In reply to Angelo CompagnucciQuoted 12 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Angelo" == Angelo Compagnucci <[email protected]> writes:
From: Angelo Compagnucci <[email protected]> Commit
4b81badbcc0b25678ac6627548160702731cf393Currently, calling foo-reconfigure for a kconfig-based package will not re-trigger the configuration (kconfig-wise) step for the package.
was supposed to solve this problem and lately we had
Commit
05fea6e4a60a38a797d9bacbf318a2cd7dbd435f
Quoted 8 lines
infra/pkg-kconfig: do not rely on package's .config as a timestamp
that introduced the .stamp_dotconfig file.
For this reason, to trigger a kconfig package reconfigure is now necessary to remove the .stamp_dotconfig file.
Signed-off-by Angelo Compagnucci <[email protected]>
Committed to 2019.02.x, 2019.08.x and 2019.11.x, thanks.
Signature · 1 line
Bye, Peter Korsgaard