Skip to contentSkip to conversation

ath10k: Fixed "Failed to wake target" QCA6174

PATCH In review liupold 2 participants 2 messages Oct 30, 2019

Subsystems (3)
lore
Share & tools
lore

liupold

author
#0 lore raw

PATCH 1/1 ath10k: Fixed "Failed to wake target" QCA6174

There is a issue with card about waking up during boot and from suspend the only way to prevent it (is seems) by making pci_ps = false, on Acer Swift 3 (ryzen 2500u).

---
 drivers/net/wireless/ath/ath10k/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/ath/ath10k/pci.c +1 -1
index a0b4d265c6eb..653590342619 100644
@@ -3514,7 +3514,7 @@ static int ath10k_pci_probe(struct pci_dev *pdev,
 	case QCA6164_2_1_DEVICE_ID:
 	case QCA6174_2_1_DEVICE_ID:
 		hw_rev = ATH10K_HW_QCA6174;
-		pci_ps = true;
+		pci_ps = false;
 		pci_soft_reset = ath10k_pci_warm_reset;
 		pci_hard_reset = ath10k_pci_qca6174_chip_reset;
 		targ_cpu_to_ce_addr = ath10k_pci_qca6174_targ_cpu_to_ce_addr;
Signature · 1 line
2.23.0
#1 lore raw

+ ath10k list

Quoted 3 lines · liupold

There is a issue with card about waking up during boot and from suspend the only way to prevent it (is seems) by making pci_ps = false, on Acer Swift 3 (ryzen 2500u).

Can you provide dmesg output when this problem happens? Was QCA6174 installed to Swift 3 by default at the factory or did you install it afterwards on your own?

Quoted 1 line

Is 'liupold' your full legal name?

Quoted 9 lines
---
 drivers/net/wireless/ath/ath10k/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/ath/ath10k/pci.c +0 -0
index a0b4d265c6eb..653590342619 100644

drivers/net/wireless/ath/ath10k/pci.c static int ath10k_pci_probe(struct pci_dev *pdev, · line 3520

Quoted 8 lines
drivers/net/wireless/ath/ath10k/pci.c +1 -1
@@ -3514,7 +3514,7 @@ static int ath10k_pci_probe(struct pci_dev *pdev,
 	case QCA6164_2_1_DEVICE_ID:
 	case QCA6174_2_1_DEVICE_ID:
 		hw_rev = ATH10K_HW_QCA6174;
-		pci_ps = true;
+		pci_ps = false;
 		pci_soft_reset = ath10k_pci_warm_reset;
 		pci_hard_reset = ath10k_pci_qca6174_chip_reset;
 		targ_cpu_to_ce_addr = ath10k_pci_qca6174_targ_cpu_to_ce_addr;

This increases power consumption for all QCA6174 devices so I'm not eager to do this.

Signature · 1 line
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches