Skip to contentSkip to conversation

package/ettercap: new package

PATCH New Jugurtha BELKALEM 2 participants 2 messages May 7, 2019 – Aug 3, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/ettercap: new package

Ettercap is a comprehensive suite for man
in the middle attacks.
It features sniffing of live connections, content
filtering on the fly and many other interesting
tricks.

Ettercap can help identify misconfigured networks, testing intrusion detection and prevention applications and build robust embedded systems that are "security by design" compliant.

This tool can be used for security testing or
educational purposes.

Master branch from :
https://github.com/Ettercap/ettercap
was used as the source for this packet as it
remains in active development (unlike release
version which dates back to 2015).

More information is available at:
https://www.ettercap-project.org/

---
 DEVELOPERS                                         |  3 ++
 package/Config.in                                  |  1 +
 .../0001-Fix-invalid-utf-8-is-not-supported.patch  | 33 ++++++++++++++++++++++
 package/ettercap/Config.in                         | 22 +++++++++++++++
 package/ettercap/ettercap.hash                     |  3 ++
 package/ettercap/ettercap.mk                       | 16 +++++++++++
 6 files changed, 78 insertions(+)
 create mode 100644 package/ettercap/0001-Fix-invalid-utf-8-is-not-supported.patch
 create mode 100644 package/ettercap/Config.in
 create mode 100644 package/ettercap/ettercap.hash
 create mode 100644 package/ettercap/ettercap.mk
DEVELOPERS +3 -0
index 5bfc456..9246d96 100644
@@ -1227,6 +1227,9 @@ F:	package/python-xlib/
 N:	Joshua Henderson <[email protected]>
 F:	package/qt5/qt5wayland/
 
+N:	Jugurtha BELKALEM <[email protected]>
+F:	package/ettercap/
+
 N:	Juha Rantanen <[email protected]>
 F:	package/acsccid/
 
package/Config.in +1 -0
index f592e74..52d08d3 100644
@@ -1757,6 +1757,7 @@ endif
 endmenu
 
 menu "Security"
+	source "package/ettercap/Config.in"
 	source "package/libselinux/Config.in"
 	source "package/libsemanage/Config.in"
 	source "package/libsepol/Config.in"
package/ettercap/0001-Fix-invalid-utf-8-is-not-supported.patch new file +33 -0
new file mode 100644
index 0000000..9627cc3
@@ -0,0 +1,33 @@
+From b4f8a10100669806de6cb37b1c1f747539e93b31 Mon Sep 17 00:00:00 2001
+From: Jugurtha BELKALEM <[email protected]>
+Date: Tue, 7 May 2019 13:25:44 +0200
+Subject: [PATCH] Fix invalid utf-8 is not supported
+
+Fixes fatal error message generated even when
+utf-8 is available.
+Ettercap requires gettext package and works fine.
+ 
+Signed-off-by: Jugurtha BELKALEM <[email protected]>
+---
+ ettercap-5fb604823c6063676ebdf7cac66b7807acb4f7ed/src/ec_format.c | 5 +----
+ 1 file changed, 1 insertion(+), 4 deletions(-)
+
+diff --git a/src/ec_format.c b/ettercap-5fb604823c6063676ebdf7cac66b7807acb4f7ed/src/ec_format.c
+index 5c9b850..dd9d972 100644
+--- a/src/ec_format.c
++++ b/src/ec_format.c
+@@ -417,10 +417,7 @@ int set_utf8_encoding(u_char *fromcode)
+ 
+    /* make sure encoding type is supported */
+    cd = iconv_open("UTF-8", (const char*)fromcode);
+-   
+-   if (cd == (iconv_t)(-1))
+-      SEMIFATAL_ERROR("The conversion from %s to UTF-8 is not supported.", fromcode);
+-   
++      
+    iconv_close(cd);
+ 
+    utf8_encoding = strdup((const char*)fromcode);
+-- 
+2.7.4
+
package/ettercap/Config.in new file +22 -0
new file mode 100644
index 0000000..fbab876
@@ -0,0 +1,22 @@
+config BR2_PACKAGE_ETTERCAP
+	bool "ettercap"
+	select BR2_PACKAGE_ETHTOOL # runtime
+	select BR2_PACKAGE_GEOIP # runtime
+	select BR2_PACKAGE_GETTEXT # runtime
+	select BR2_PACKAGE_LIBCURL # runtime
+	select BR2_PACKAGE_LIBNET # runtime
+	select BR2_PACKAGE_LIBPCAP # runtime
+	select BR2_PACKAGE_LIBPTHREAD_STUB # runtime
+	select BR2_PACKAGE_NCURSES # runtime
+	select BR2_PACKAGE_OPENSSL # runtime
+	select BR2_PACKAGE_ZLIB # runtime
+	help
+	  Ettercap is a comprehensive suite for man
+	  in the middle attacks. It features sniffing of
+	  live connections, content filtering on the fly
+	  and many other interesting tricks. It supports
+	  active and passive dissection of many protocols
+	  and includes many features for network and
+	  host analysis.
+
+	  http://www.ettercap-project.org/
package/ettercap/ettercap.hash new file +3 -0
new file mode 100644
index 0000000..776c34c
@@ -0,0 +1,3 @@
+# Locally calculated
+sha256 a6ea1b70f9e1d8ba8815ca540ff1571556d6ba19cfd05c409f518d03e669befc  ettercap-5fb604823c6063676ebdf7cac66b7807acb4f7ed.tar.gz
+sha256 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  LICENSE
package/ettercap/ettercap.mk new file +16 -0
new file mode 100644
index 0000000..b913708
@@ -0,0 +1,16 @@
+################################################################################
+#
+# ettercap
+#
+################################################################################
+
+ETTERCAP_VERSION = 5fb604823c6063676ebdf7cac66b7807acb4f7ed
+ETTERCAP_SITE = $(call github,Ettercap,ettercap,$(ETTERCAP_VERSION))
+ETTERCAP_LICENSE = GPL-2.0
+ETTERCAP_LICENSE_FILES = LICENSE
+ETTERCAP_SUPPORTS_IN_SOURCE_BUILD = NO
+ETTERCAP_DEPENDENCIES = geoip host-ncurses libzlib \
+	libcurl libnet libopenssl libpcap ncurses
+ETTERCAP_CONF_OPTS = -DENABLE_GTK=NO
+
+$(eval $(cmake-package))
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 package/ettercap: new package

Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Jugurtha" == Jugurtha BELKALEM <[email protected]> writes:

Ettercap is a comprehensive suite for man
in the middle attacks.
It features sniffing of live connections, content
filtering on the fly and many other interesting
tricks.

Quoted 4 lines

Ettercap can help identify misconfigured networks, testing intrusion detection and prevention applications and build robust embedded systems that are "security by design" compliant.

You word wrapping is kind of odd?

Quoted 8 lines

This tool can be used for security testing or
educational purposes.

Master branch from :
https://github.com/Ettercap/ettercap
was used as the source for this packet as it
remains in active development (unlike release
version which dates back to 2015).

In the mean time 0.8.3 has been released.

package/Config.in endif · line 1760

Quoted 6 lines

+++ b/package/Config.in

package/Config.in +1 -0
@@ -1757,6 +1757,7 @@ endif
 endmenu
 
 menu "Security"
+	source "package/ettercap/Config.in"

Sticking this under libraries -> security is a bit odd. Perhaps a better place would be Networking applications?

Quoted 17 lines
package/ettercap/0001-Fix-invalid-utf-8-is-not-supported.patch new file +16 -0
+++ b/package/ettercap/0001-Fix-invalid-utf-8-is-not-supported.patch
@@ -0,0 +1,33 @@
+From b4f8a10100669806de6cb37b1c1f747539e93b31 Mon Sep 17 00:00:00 2001
+From: Jugurtha BELKALEM <[email protected]>
+Date: Tue, 7 May 2019 13:25:44 +0200
+Subject: [PATCH] Fix invalid utf-8 is not supported
+
+Fixes fatal error message generated even when
+utf-8 is available.
+Ettercap requires gettext package and works fine.
+ 
+Signed-off-by: Jugurtha BELKALEM <[email protected]>
+---
+ ettercap-5fb604823c6063676ebdf7cac66b7807acb4f7ed/src/ec_format.c | 5 +----
+ 1 file changed, 1 insertion(+), 4 deletions(-)
+
+diff --git a/src/ec_format.c b/ettercap-5fb604823c6063676ebdf7cac66b7807acb4f7ed/src/ec_format.c

package/ettercap/0001-Fix-invalid-utf-8-is-not-supported.patch line 25

Quoted 10 lines
package/ettercap/0001-Fix-invalid-utf-8-is-not-supported.patch new file +10 -0
+index 5c9b850..dd9d972 100644
+--- a/src/ec_format.c
++++ b/src/ec_format.c
+@@ -417,10 +417,7 @@ int set_utf8_encoding(u_char *fromcode)
+ 
+    /* make sure encoding type is supported */
+    cd = iconv_open("UTF-8", (const char*)fromcode);
+-   
+-   if (cd == (iconv_t)(-1))
+-      SEMIFATAL_ERROR("The conversion from %s to UTF-8 is not supported.", fromcode);

This looks very confusing to me - Can you provide more details? What is fromcode set to here when it fails? What toolchains do you see this error with? Can we instead turn off HAVE_UTF8 for those cases?

Quoted 8 lines
package/ettercap/Config.in new file +2 -0
new file mode 100644
index 0000000..fbab876
@@ -0,0 +1,22 @@
+config BR2_PACKAGE_ETTERCAP
+	bool "ettercap"

package/ettercap/Config.in line 12

Quoted 10 lines
package/ettercap/Config.in new file +10 -0
+	select BR2_PACKAGE_ETHTOOL # runtime
+	select BR2_PACKAGE_GEOIP # runtime
+	select BR2_PACKAGE_GETTEXT # runtime
+	select BR2_PACKAGE_LIBCURL # runtime
+	select BR2_PACKAGE_LIBNET # runtime
+	select BR2_PACKAGE_LIBPCAP # runtime
+	select BR2_PACKAGE_LIBPTHREAD_STUB # runtime
+	select BR2_PACKAGE_NCURSES # runtime
+	select BR2_PACKAGE_OPENSSL # runtime
+	select BR2_PACKAGE_ZLIB # runtime

You list all of these as runtime dependencies, but still add them to ETTERCAP_DEPENDENCIES? Doing a quick test, I see that atleast ncurses is a build dependency:

Could NOT find Curses (missing: CURSES_LIBRARY CURSES_INCLUDE_PATH)

Looking a CMakeLists.txt I see that a number of these are optional:

option(ENABLE_CURSES "Enable curses interface" ON) option(ENABLE_GTK "Enable GTK interface" ON) option(ENABLE_PLUGINS "Enable plugins support" ON) option(ENABLE_IPV6 "Enable IPv6 support" OFF) option(ENABLE_LUA "Enable LUA support (EXPERIMENTAL)" OFF) option(ENABLE_PDF_DOCS "Enable PDF document generation" OFF) option(ENABLE_TESTS "Enable Unit Tests" OFF) option(ENABLE_GEOIP "Build with GeoIP support" ON) option(LIBRARY_BUILD "Build for libettercap only" OFF) option(INSTALL_DESKTOP "Install ettercap desktop files" ON)

So it would be nice to only enable these things if the affected packages are enabled.

Are there really no toolchain dependencies? I see that plugins are enabled by default, so presumably this means that it uses dlopen() and hence will not work in a BR2_STATIC_LIBS setup?

package/ettercap/Config.in line 15

Quoted 3 lines
package/ettercap/Config.in new file +3 -0
+ETTERCAP_VERSION = 5fb604823c6063676ebdf7cac66b7807acb4f7ed
+ETTERCAP_SITE = $(call github,Ettercap,ettercap,$(ETTERCAP_VERSION))
+ETTERCAP_LICENSE = GPL-2.0

The source files contains the "any later version" text, so it should be GPL-2.0+

package/ettercap/Config.in line 19

Quoted 4 lines
package/ettercap/Config.in new file +4 -0
+ETTERCAP_LICENSE_FILES = LICENSE
+ETTERCAP_SUPPORTS_IN_SOURCE_BUILD = NO
+ETTERCAP_DEPENDENCIES = geoip host-ncurses libzlib \
+	libcurl libnet libopenssl libpcap ncurses

Why is host-ncurses needed?

Care to fix these issues and send an updated patch?

Signature · 1 line
Bye, Peter Korsgaard