Skip to contentSkip to conversation

package/bind: fix python build

PATCH New Fabrice Fontaine 3 participants 10 messages Apr 27, 2019 – May 1, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/bind: fix python build

A check for python-ply has been added as this is a dependency of the dnssec-keymgr script so install host-python-ply to avoid a build failure if python-ply is not installed on host

Fixes:
- http://autobuild.buildroot.org/results/96815b1300547c976443bf74b762febdfcc8d3ba

---
 package/bind/bind.mk | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
package/bind/bind.mk +5 -2
index 356bc259b2..087ce941b0 100644
@@ -70,8 +70,11 @@ else
 BIND_CONF_OPTS += --with-openssl=no
 endif
 
-# Used by dnssec-checkds and dnssec-coverage
-ifeq ($(BR2_PACKAGE_PYTHON)$(BR2_PACKAGE_PYTHON3),)
+# Used by dnssec-keymgr
+ifeq ($(BR2_PACKAGE_PYTHON_PLY),y)
+BIND_DEPENDENCIES += host-python-ply
+BIND_CONF_OPTS += --with-python=$(HOST_DIR)/usr/bin/python
+else
 BIND_CONF_OPTS += --with-python=no
 endif
 
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 package/bind: fix python build

Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

A check for python-ply has been added as this is a dependency of the dnssec-keymgr script so install host-python-ply to avoid a build failure if python-ply is not installed on host

Fixes:
- http://autobuild.buildroot.org/results/96815b1300547c976443bf74b762febdfcc8d3ba

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#2 lore raw

PATCH 1/1 package/bind: fix python build

Quoted 11 lines
Quoted 11 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines

"Peter" == Peter Korsgaard <[email protected]> writes:

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

A check for python-ply has been added as this is a dependency of the dnssec-keymgr script so install host-python-ply to avoid a build failure if python-ply is not installed on host

Fixes:
- http://autobuild.buildroot.org/results/96815b1300547c976443bf74b762febdfcc8d3ba

Committed to 2019.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH 1/1 package/bind: fix python build

In reply to Fabrice Fontaine
Quoted 19 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

A check for python-ply has been added as this is a dependency of the dnssec-keymgr script so install host-python-ply to avoid a build failure if python-ply is not installed on host

Fixes:
- http://autobuild.buildroot.org/results/96815b1300547c976443bf74b762febdfcc8d3ba

---
 package/bind/bind.mk | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
package/bind/bind.mk +0 -0
index 356bc259b2..087ce941b0 100644

package/bind/bind.mk else · line 76

Quoted 9 lines
package/bind/bind.mk +4 -2
@@ -70,8 +70,11 @@ else
 BIND_CONF_OPTS += --with-openssl=no
 endif
 
-# Used by dnssec-checkds and dnssec-coverage
-ifeq ($(BR2_PACKAGE_PYTHON)$(BR2_PACKAGE_PYTHON3),)
+# Used by dnssec-keymgr
+ifeq ($(BR2_PACKAGE_PYTHON_PLY),y)
+BIND_DEPENDENCIES += host-python-ply
+BIND_CONF_OPTS += --with-python=$(HOST_DIR)/usr/bin/python

Hmm, I somehow missed the host/target mixup. This is not good. You test if the target python-ply package is enabled, but then add host-python-ply (which doesn't exist) to _DEPENDENCIES:

http://autobuild.buildroot.net/results/2615ebfdcb068594d028af4823260e613d37e867/build-end.log

If I understand it right, we need ply for the host to satisfy the configure check and ply for the target for runtime, so I guess the solution is to add a host version of the python-ply package.

Signature · 1 line
Bye, Peter Korsgaard
#4 lore raw

PATCH 1/1 package/bind: fix python build

Hello Peter,

Le mar. 30 avr. 2019 ? 09:21, Peter Korsgaard <[email protected]> a ?crit :

Quoted 34 lines
Quoted 20 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

A check for python-ply has been added as this is a dependency of the dnssec-keymgr script so install host-python-ply to avoid a build failure if python-ply is not installed on host

Fixes:
- http://autobuild.buildroot.org/results/96815b1300547c976443bf74b762febdfcc8d3ba

---
 package/bind/bind.mk | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
package/bind/bind.mk +0 -0
index 356bc259b2..087ce941b0 100644

package/bind/bind.mk else · line 76

Quoted 9 lines
package/bind/bind.mk +4 -2
@@ -70,8 +70,11 @@ else
 BIND_CONF_OPTS += --with-openssl=no
 endif
 
-# Used by dnssec-checkds and dnssec-coverage
-ifeq ($(BR2_PACKAGE_PYTHON)$(BR2_PACKAGE_PYTHON3),)
+# Used by dnssec-keymgr
+ifeq ($(BR2_PACKAGE_PYTHON_PLY),y)
+BIND_DEPENDENCIES += host-python-ply
+BIND_CONF_OPTS += --with-python=$(HOST_DIR)/usr/bin/python

Hmm, I somehow missed the host/target mixup. This is not good. You test if the target python-ply package is enabled, but then add host-python-ply (which doesn't exist) to _DEPENDENCIES:

Quoted 5 lines

http://autobuild.buildroot.net/results/2615ebfdcb068594d028af4823260e613d37e867/build-end.log

If I understand it right, we need ply for the host to satisfy the configure check and ply for the target for runtime, so I guess the solution is to add a host version of the python-ply package.

Yes, I forgot to add the host variant of python-ply.

Quoted 3 lines

--
Bye, Peter Korsgaard

Best Regards,

Fabrice

#5 lore raw

PATCH 1/1 package/bind: fix python build

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

Hi,

Quoted 5 lines
Quoted 3 lines

If I understand it right, we need ply for the host to satisfy the configure check and ply for the target for runtime, so I guess the solution is to add a host version of the python-ply package.

Yes, I forgot to add the host variant of python-ply.

Will you send a patch to fix it?

Signature · 1 line
Bye, Peter Korsgaard
#6 lore raw

PATCH 1/1 package/bind: fix python build

Hello,

Le mar. 30 avr. 2019 ? 10:10, Peter Korsgaard <[email protected]> a ?crit :

Quoted 5 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

Hi,

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines

If I understand it right, we need ply for the host to satisfy the configure check and ply for the target for runtime, so I guess the solution is to add a host version of the python-ply package.

Yes, I forgot to add the host variant of python-ply.

Will you send a patch to fix it?

Yes, I'll do it this evening.

Quoted 3 lines

--
Bye, Peter Korsgaard

Fabrice

#7 lore raw

PATCH 1/1 package/bind: fix python build

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

Hi,

Quoted 4 lines
Quoted 3 lines
Quoted 1 line

Yes, I forgot to add the host variant of python-ply.

Will you send a patch to fix it?

Yes, I'll do it this evening.

Great, thanks!

Signature · 1 line
Bye, Peter Korsgaard
#8 lore raw

PATCH 1/1 package/bind: fix python build

In reply to Peter Korsgaard
Quoted 33 lines · Peter Korsgaard
Quoted 19 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Fabrice" == Fabrice Fontaine <[email protected]> writes:

A check for python-ply has been added as this is a dependency of the dnssec-keymgr script so install host-python-ply to avoid a build failure if python-ply is not installed on host

Fixes:
- http://autobuild.buildroot.org/results/96815b1300547c976443bf74b762febdfcc8d3ba

---
 package/bind/bind.mk | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)
package/bind/bind.mk +0 -0
index 356bc259b2..087ce941b0 100644

package/bind/bind.mk else · line 76

Quoted 9 lines
package/bind/bind.mk +4 -2
@@ -70,8 +70,11 @@ else
 BIND_CONF_OPTS += --with-openssl=no
 endif
 
-# Used by dnssec-checkds and dnssec-coverage
-ifeq ($(BR2_PACKAGE_PYTHON)$(BR2_PACKAGE_PYTHON3),)
+# Used by dnssec-keymgr
+ifeq ($(BR2_PACKAGE_PYTHON_PLY),y)
+BIND_DEPENDENCIES += host-python-ply
+BIND_CONF_OPTS += --with-python=$(HOST_DIR)/usr/bin/python

Hmm, I somehow missed the host/target mixup. This is not good. You test if the target python-ply package is enabled, but then add host-python-ply (which doesn't exist) to _DEPENDENCIES:

Quoted 5 lines

http://autobuild.buildroot.net/results/2615ebfdcb068594d028af4823260e613d37e867/build-end.log

If I understand it right, we need ply for the host to satisfy the configure check and ply for the target for runtime, so I guess the solution is to add a host version of the python-ply package.

It's pretty ridiculous that we need host-python and host-python-ply *just* to
satisfy the configure script... AFAICS, it's not actually used anywhere. Can't we turn PYTHON into a cache var and replace all that with a simple ac_cv_PYTHON=pyhon ?

Regards,
Arnout

#9 lore raw

PATCH 1/1 package/bind: fix python build

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle <[email protected]> writes:

Hi,

Quoted 6 lines
Quoted 6 lines

Hmm, I somehow missed the host/target mixup. This is not good. You test if the target python-ply package is enabled, but then add host-python-ply (which doesn't exist) to _DEPENDENCIES:

http://autobuild.buildroot.net/results/2615ebfdcb068594d028af4823260e613d37e867/build-end.log

Quoted 8 lines
Quoted 3 lines

If I understand it right, we need ply for the host to satisfy the configure check and ply for the target for runtime, so I guess the solution is to add a host version of the python-ply package.

It's pretty ridiculous that we need host-python and host-python-ply *just* to
satisfy the configure script... AFAICS, it's not actually used anywhere. Can't we turn PYTHON into a cache var and replace all that with a simple ac_cv_PYTHON=pyhon ?

I guess we could, but it also needs python for the target at runtime, so that implies host-python, and host-python-ply is a pure python package so trivial to build - So it doesn't really gain much.

Signature · 1 line
Bye, Peter Korsgaard