ixgbe: recognize 1000BaseLX SFP modules as 1Gbps
Subsystems (3)
PATCH 1/1 ixgbe: recognize 1000BaseLX SFP modules as 1Gbps
Add the two 1000BaseLX enum values to the X550's check for 1Gbps modules, allowing the core driver code to establish a link over this SFP type.
This is done by the out-of-tree driver but the fix wasn't in mainline.
--- drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c +3 -1
@@ -2262,7 +2262,9 @@ static s32 ixgbe_get_link_capabilities_X550em(struct ixgbe_hw *hw, *autoneg = false;if (hw->phy.sfp_type == ixgbe_sfp_type_1g_sx_core0 || - hw->phy.sfp_type == ixgbe_sfp_type_1g_sx_core1) { + hw->phy.sfp_type == ixgbe_sfp_type_1g_sx_core1 || + hw->phy.sfp_type == ixgbe_sfp_type_1g_lx_core0 || + hw->phy.sfp_type == ixgbe_sfp_type_1g_lx_core1) { *speed =IXGBE_LINK_SPEED_1GB_FULL ;return 0 ; }
Signature · 1 line
2.19.1
Quoted 1 line · Josh Elsasser
Fixes 6a14ee0cfb19 ("ixgbe: Add X550 support function pointers")
Not that it matters much I guess, but I think LX SFPs were unsupported at that time. The LX support appears to have been added under the radar while refactoring ixgbe_setup_sfp_modules_X550em in commit e23f33367882 ("ixgbe: Fix 1G and 10G link stability for X550EM_x SFP+")
Bj?rn
Quoted 4 lines · Bj?rn Mork
Not that it matters much I guess, but I think LX SFPs were unsupported at that time. The LX support appears to have been added under the radar while refactoring
ixgbe_setup_sfp_modules_X550emin commite23f33367882("ixgbe: Fix 1G and 10G link stability forX550EM_xSFP+")
Looks like you?re right. Want me to respin with an additional ?Fixes? tag?
- Josh
Quoted 10 lines · Josh Elsasser
Quoted 7 lines · Bjørn Mork
Not that it matters much I guess, but I think LX SFPs were unsupported
at that time. The LX support appears to have been added under the radar
while refactoringixgbe_setup_sfp_modules_X550emin commite23f33367882
("ixgbe: Fix 1G and 10G link stability forX550EM_xSFP+")
Quoted 2 lines
Looks like you’re right. Want me to respin with an additional “Fixes” tag?
No need to re-spin the patch, just reply with the additional "Fixes" tag and if patchwork does not pick it up, I will add it to the patch I have in my tree for validation and review.
Quoted 3 lines · Jeff Kirsher
No need to re-spin the patch, just reply with the additional "Fixes" tag and if patchwork does not pick it up, I will add it to the patch I have in my tree for validation and review.
Thanks, let?s try that.
David Miller
maintainerFrom: Josh Elsasser <[email protected]>
Date: Mon, 26 Nov 2018 16:54:11 -0800
Quoted 9 lines
Quoted 3 lines · Jeff Kirsher
No need to re-spin the patch, just reply with the additional "Fixes" tag and if patchwork does not pick it up, I will add it to the patch I have in my tree for validation and review.
Thanks, let?s try that.
Fixes e23f33367882 ("ixgbe: Fix 1G and 10G link stability for X550EM_x SFP+?)
Unfortunately, patchwork isn't smart enough to pick up Fixes: tags still.
Quoted 11 lines · David Miller
From: Josh Elsasser <[email protected]>
Date: Mon, 26 Nov 2018 16:54:11 -0800Quoted 8 lines
Quoted 5 lines · Jeff Kirsher
No need to re-spin the patch, just reply with the additional "Fixes"
tag and if patchwork does not pick it up, I will add it to the patch I
have in my tree for validation and review.
Quoted 7 lines
Quoted 4 lines
Thanks, let’s try that.
Fixes e23f33367882 ("ixgbe: Fix 1G and 10G link stability for
X550EM_xSFP+”)Unfortunately, patchwork isn't smart enough to pick up Fixes: tags still.
:-( I will get it added to the patch in my tree then. Thanks Dave for the info.
Quoted 9 lines · David Miller
From: Josh Elsasser <[email protected]>
Date: Mon, 26 Nov 2018 16:54:11 -0800Quoted 6 lines
Quoted 3 lines · Jeff Kirsher
No need to re-spin the patch, just reply with the additional "Fixes" tag and if patchwork does not pick it up, I will add it to the patch I have in my tree for validation and review.
Quoted 7 lines
Quoted 3 lines
Thanks, let?s try that.
Fixes e23f33367882 ("ixgbe: Fix 1G and 10G link stability for X550EM_x SFP+?)Unfortunately, patchwork isn't smart enough to pick up Fixes: tags still.
This is something that can be added easily in the patchwork administration panel, maybe ask Jeremy or Stephen to do that?
Signature · 1 line
Florian
Quoted 13 lines
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf Of Josh Elsasser
Sent: Saturday, November 24, 2018 12:58 PM
To: intel-wired-lan at lists.osuosl.org
Cc: netdev at vger.kernel.org; David S. Miller <[email protected]>; Josh Elsasser <[email protected]>; linux-kernel at vger.kernel.org
Subject: [Intel-wired-lan] [PATCH net] ixgbe: recognize 1000BaseLX SFP modules as 1GbpsAdd the two 1000BaseLX enum values to the X550's check for 1Gbps modules, allowing the core driver code to establish a link over this SFP type.
Quoted 7 lines
This is done by the out-of-tree driver but the fix wasn't in mainline.
Fixes 6a14ee0cfb19 ("ixgbe: Add X550 support function pointers")Signed-off-by Josh Elsasser <[email protected]>--- drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)