Skip to contentSkip to conversation

Missing prerequisite for arm-dts-ls1021a-specify-tbipa-register-address.patch

DISCUSSION Esben Haabendal 2 participants 5 messages May 28, 2018 – May 29, 2018 Stable branch

lore
Share & tools
lore

Esben Haabendal

author
#0 lore raw

Hi

The arm-dts-ls1021a-specify-tbipa-register-address.patch which have just been added to 4.4-stable, 4.9-stable, 4.14-stable and 4.16-stable trees, relies on the 2d23129b00d2a67e58a7b17205f5ba7ec4523fd0 in order to make sense.

Could 2d23129b00d2a67e58a7b17205f5ba7ec4523fd0 be added to those trees as well?

/Esben

maintainer
#1 lore raw
Quoted 9 lines · Esben Haabendal

Hi

The arm-dts-ls1021a-specify-tbipa-register-address.patch which have just been added to 4.4-stable, 4.9-stable, 4.14-stable and 4.16-stable trees, relies on the 2d23129b00d2a67e58a7b17205f5ba7ec4523fd0 in order to make sense.

Could 2d23129b00d2a67e58a7b17205f5ba7ec4523fd0 be added to those trees as well?

~/linux/stable/linux-stable $ git show 2d23129b00d2a67e58a7b17205f5ba7ec4523fd0
fatal: bad object 2d23129b00d2a67e58a7b17205f5ba7ec4523fd0

Are you sure that is the correct git id?

thanks,

greg k-h

author
#2 lore raw
Quoted 8 lines · Greg KH
Quoted 7 lines · Esben Haabendal

Hi

The arm-dts-ls1021a-specify-tbipa-register-address.patch which have just been added to 4.4-stable, 4.9-stable, 4.14-stable and 4.16-stable trees, relies on the 2d23129b00d2a67e58a7b17205f5ba7ec4523fd0 in order to make sense.

Quoted 7 lines
Quoted 2 lines

Could 2d23129b00d2a67e58a7b17205f5ba7ec4523fd0 be added to those trees as well?

~/linux/stable/linux-stable $ git show 2d23129b00d2a67e58a7b17205f5ba7ec4523fd0
fatal: bad object 2d23129b00d2a67e58a7b17205f5ba7ec4523fd0

Are you sure that is the correct git id?

Obviously not.

The correct id is 21481189e8ffa4016e398d46ac6d66fb0f23acc3

Sorry about that.

/Esben

maintainer
#3 lore raw
Quoted 16 lines · Esben Haabendal
Quoted 14 lines · Greg KH
Quoted 9 lines · Esben Haabendal

Hi

The arm-dts-ls1021a-specify-tbipa-register-address.patch which have just been added to 4.4-stable, 4.9-stable, 4.14-stable and 4.16-stable trees, relies on the 2d23129b00d2a67e58a7b17205f5ba7ec4523fd0 in order to make sense.

Could 2d23129b00d2a67e58a7b17205f5ba7ec4523fd0 be added to those trees as well?

~/linux/stable/linux-stable $ git show 2d23129b00d2a67e58a7b17205f5ba7ec4523fd0
fatal: bad object 2d23129b00d2a67e58a7b17205f5ba7ec4523fd0

Quoted 7 lines
Quoted 1 line

Are you sure that is the correct git id?

Obviously not.

The correct id is 21481189e8ffa4016e398d46ac6d66fb0f23acc3

Sorry about that.

In looking at this patch, it just seems to be changing the way the information is retrieved from the hardware/dts file, and as such, does not seem like a viable stable kernel patch at this point in time.

So I've removed the original arm-dts-ls1021a-specify-tbipa-register-address.patch patch from all of the specific kernel patch queues now.

thanks,

greg k-h

author
#4 lore raw
Quoted 26 lines · Greg KH
Quoted 17 lines · Esben Haabendal
Quoted 15 lines · Greg KH
Quoted 9 lines · Esben Haabendal

Hi

The arm-dts-ls1021a-specify-tbipa-register-address.patch which have just been added to 4.4-stable, 4.9-stable, 4.14-stable and 4.16-stable trees, relies on the 2d23129b00d2a67e58a7b17205f5ba7ec4523fd0 in order to make sense.

Could 2d23129b00d2a67e58a7b17205f5ba7ec4523fd0 be added to those trees as well?

~/linux/stable/linux-stable $ git show 2d23129b00d2a67e58a7b17205f5ba7ec4523fd0
fatal: bad object 2d23129b00d2a67e58a7b17205f5ba7ec4523fd0

Quoted 7 lines
Quoted 1 line

Are you sure that is the correct git id?

Obviously not.

The correct id is 21481189e8ffa4016e398d46ac6d66fb0f23acc3

Sorry about that.

Quoted 7 lines

In looking at this patch, it just seems to be changing the way the information is retrieved from the hardware/dts file, and as such, does not seem like a viable stable kernel patch at this point in time.

So I've removed the original arm-dts-ls1021a-specify-tbipa-register-address.patch patch from all of the specific kernel patch queues now.

Yes, 21481189e8ffa4016e398d46ac6d66fb0f23acc3 changes the way the TBIPA register is accessed. But only if DTS has two register blocks, which is not the case without 5571196135abb6d51e01592812997403c136067c.

So I think it is fair to say that it is backwards compatible, but whether it together with 5571196135abb6d51e01592812997403c136067c is viable for stable right now is another question.

They do change how hardware is accessed, but they changes it so that it fixes a bug on LS1021A.

/Esben