qt5webengine: fix build issue with alsa
PATCH v2 1/1 qt5webengine: fix build issue with alsa
Qt WebEngine auto-guesses if it compiles support for alsa. When the alsa-lib config is enabled but the features mixer, rawmidi, hwdep and seq are not also enabled, it leads to a build failure.
Lets the developer decide whether or not support for alsa in Qt WebEngine by adding the new config BR2_PACKAGE_QT5WEBENGINE_ALSA that selects the features it needs when it is set.
Fixes [1].
[1]: http://autobuild.buildroot.net/results/d81537a8f67bb0a3625057560b2f16daf4828f98/build-end.log
---
Changes since v1:
* turn alsa-lib dependency into select
package/qt5/qt5webengine/Config.in | 10 ++++++++++ package/qt5/qt5webengine/qt5webengine.mk | 6 ++++++ 2 files changed, 16 insertions(+)
package/qt5/qt5webengine/Config.in +10 -0
@@ -81,4 +81,14 @@ config BR2_PACKAGE_QT5WEBENGINE_PROPRIETARY_CODECS which includes required proprietary audio and video codecs, such as H.264 and MPEG layer-3 (MP3). +config BR2_PACKAGE_QT5WEBENGINE_ALSA + bool "alsa" + select BR2_PACKAGE_ALSA_LIB + select BR2_PACKAGE_ALSA_LIB_MIXER + select BR2_PACKAGE_ALSA_LIB_RAWMIDI + select BR2_PACKAGE_ALSA_LIB_HWDEP + select BR2_PACKAGE_ALSA_LIB_SEQ + help + Enable ALSA support. + endif
package/qt5/qt5webengine/qt5webengine.mk +6 -0
@@ -28,6 +28,12 @@ ifeq ($(BR2_PACKAGE_QT5WEBENGINE_PROPRIETARY_CODECS),y) QT5WEBENGINE_QMAKEFLAGS += WEBENGINE_CONFIG+=use_proprietary_codecs endif +ifeq ($(BR2_PACKAGE_QT5WEBENGINE_ALSA),y) +QT5WEBENGINE_DEPENDENCIES += alsa-lib +else +QT5WEBENGINE_QMAKEFLAGS += QT_CONFIG-=alsa +endif + # QtWebengine's build system uses python, but only supports python2. We work # around this by forcing python2 early in the PATH, via a python->python2 # symlink.
Signature · 1 line
2.11.0
PATCH v2 1/1 qt5webengine: fix build issue with alsa
Quoted 12 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Ga?l" == Ga?l PORTAY <[email protected]> writes:
Qt WebEngine auto-guesses if it compiles support for alsa. When the alsa-lib config is enabled but the features mixer, rawmidi, hwdep and seq are not also enabled, it leads to a build failure.
Lets the developer decide whether or not support for alsa in Qt WebEngine by adding the new config
BR2_PACKAGE_QT5WEBENGINE_ALSAthat selects the features it needs when it is set.Fixes [1].
Quoted 7 lines
[1]: http://autobuild.buildroot.net/results/d81537a8f67bb0a3625057560b2f16daf4828f98/build-end.log
Signed-off-by Ga?l PORTAY <[email protected]>---
Changes since v1:
* turn alsa-lib dependency into select
Committed, thanks.
Signature · 1 line
Bye, Peter Korsgaard