Skip to contentSkip to conversation

sunxi-mali-driver-mainline: new package

PATCH New Giulio Benetti 3 participants 18 messages Nov 25, 2017 – Feb 16, 2018 Arm/Allwinner sunXi SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 sunxi-mali-driver-mainline: new package

Added kernel allwinner mali driver package. Used combined with userspace Allwinner openGL libraries, it gives possibility to use 3D openGL SoC acceleration.

---
 DEVELOPERS                                         |  3 ++
 package/Config.in                                  |  1 +
 package/sunxi-mali-driver-mainline/Config.in       | 38 ++++++++++++++++++++++
 .../sunxi-mali-driver-mainline.mk                  | 30 +++++++++++++++++
 4 files changed, 72 insertions(+)
 create mode 100644 package/sunxi-mali-driver-mainline/Config.in
 create mode 100644 package/sunxi-mali-driver-mainline/sunxi-mali-driver-mainline.mk
DEVELOPERS +3 -0
index 7621f96..60a934e 100644
@@ -698,6 +698,9 @@ F:	package/ocrad/
 F:	package/tesseract-ocr/
 F:	package/webp/
 
+N:	Giulio Benetti <[email protected]>
+F:	package/sunxi-mali-driver-mainline/
+
 N:	Gregory Dymarek <[email protected]>
 F:	package/ding-libs/
 F:	package/gengetopt/
package/Config.in +1 -0
index fe5ccc4..e619992 100644
@@ -497,6 +497,7 @@ endmenu
 	source "package/stm32flash/Config.in"
 	source "package/sunxi-cedarx/Config.in"
 	source "package/sunxi-mali/Config.in"
+	source "package/sunxi-mali-driver-mainline/Config.in"
 	source "package/sysstat/Config.in"
 	source "package/targetcli-fb/Config.in"
 	source "package/ti-gfx/Config.in"
package/sunxi-mali-driver-mainline/Config.in new file +38 -0
new file mode 100644
index 0000000..1f9ef59
@@ -0,0 +1,38 @@
+comment "sunxi-mali-driver-mainline needs a Linux kernel to be built"
+	depends on !BR2_LINUX_KERNEL
+
+config BR2_PACKAGE_SUNXI_MALI_DRIVER_MAINLINE
+	bool "sunxi-mali-driver-mainline"
+	depends on BR2_LINUX_KERNEL
+	select BR2_LINUX_NEEDS_MODULES # not using kernel-module infra
+	help
+	  This package builds and installs the Linux kernel driver for
+	  the Mali GPU on Allwinner platforms, compatible with recent
+	  Linux kernels (>= 4.4). Note that it should be installed
+	  together with the corresponding userspace OpenGL libraries,
+	  which are provided as binaries only at:
+	  https://github.com/free-electrons/mali-blobs
+
+	  sunxi-mali-driver-mainline requires a Linux kernel >= 4.4 with the
+	  following options enabled:
+
+	  - CONFIG_CMA
+	  - CONFIG_DMA_CMA
+	  - CONFIG_DRM_FBDEV_OVERALLOC >= 200 for double buffer or more
+
+	  https://github.com/mripard/sunxi-mali/blob/master/README.md
+
+if BR2_PACKAGE_SUNXI_MALI_DRIVER_MAINLINE
+
+choice
+	prompt "Version"
+	default BR2_PACKAGE_SUNXI_MALI_DRIVER_MAINLINE_R6P2
+	help
+	  Select the version of the kernel module.
+
+config BR2_PACKAGE_SUNXI_MALI_DRIVER_MAINLINE_R6P2
+	bool "r6p2"
+
+endchoice
+
+endif
package/sunxi-mali-driver-mainline/sunxi-mali-driver-mainline.mk new file +30 -0
new file mode 100644
index 0000000..41d145d
@@ -0,0 +1,30 @@
+################################################################################
+#
+# sunxi-mali-driver-mainline
+#
+################################################################################
+
+SUNXI_MALI_DRIVER_MAINLINE_VERSION = 42c7c139c14103a83bb2ad7e7a1f0ed491f96500
+SUNXI_MALI_DRIVER_MAINLINE_SITE = $(call github,mripard,sunxi-mali,$(SUNXI_MALI_DRIVER_MAINLINE_VERSION))
+SUNXI_MALI_DRIVER_MAINLINE_DEPENDENCIES = linux
+
+SUNXI_MALI_DRIVER_MAINLINE_MAKE_OPTS = \
+	KDIR=$(LINUX_DIR) \
+	CROSS_COMPILE=$(TARGET_CROSS) \
+	INSTALL_MOD_PATH=$(TARGET_DIR)
+
+ifeq ($(BR2_PACKAGE_SUNXI_MALI_DRIVER_MAINLINE_R6P2),y)
+SUNXI_MALI_DRIVER_VER=r6p2
+endif
+
+define SUNXI_MALI_DRIVER_MAINLINE_BUILD_CMDS
+	cd $(@D) && $(SUNXI_MALI_DRIVER_MAINLINE_MAKE_OPTS) \
+		$(SHELL) ./build.sh -r $(SUNXI_MALI_DRIVER_VER) -b
+endef
+
+define SUNXI_MALI_DRIVER_MAINLINE_INSTALL_TARGET_CMDS
+	cd $(@D) && $(SUNXI_MALI_DRIVER_MAINLINE_MAKE_OPTS) \
+		$(SHELL) ./build.sh -r $(SUNXI_MALI_DRIVER_VER) -i
+endef
+
+$(eval $(generic-package))
Signature · 1 line
2.7.4
#1 lore raw

PATCH 2/2 sunxi-mali-mainline: new package

Add Allwinner Mali openGL userspace driver r6p2.
Used combined with kernelspace Mali driver,
it gives possibility to use 3D openGL SoC acceleration. It provides fbdev libraries and headers.
It is compatible with Linux >= 4.4 as sunxi-mali-driver-mainline.

---
 DEVELOPERS                                         |  1 +
 package/Config.in                                  |  1 +
 package/sunxi-mali-mainline/Config.in              | 36 ++++++++++++++++++++++
 package/sunxi-mali-mainline/egl.pc                 | 12 ++++++++
 package/sunxi-mali-mainline/glesv2.pc              | 12 ++++++++
 package/sunxi-mali-mainline/sunxi-mali-mainline.mk | 33 ++++++++++++++++++++
 6 files changed, 95 insertions(+)
 create mode 100644 package/sunxi-mali-mainline/Config.in
 create mode 100644 package/sunxi-mali-mainline/egl.pc
 create mode 100644 package/sunxi-mali-mainline/glesv2.pc
 create mode 100644 package/sunxi-mali-mainline/sunxi-mali-mainline.mk
DEVELOPERS +1 -0
index 60a934e..b26706b 100644
@@ -700,6 +700,7 @@ F:	package/webp/
 
 N:	Giulio Benetti <[email protected]>
 F:	package/sunxi-mali-driver-mainline/
+F:	package/sunxi-mali-mainline/
 
 N:	Gregory Dymarek <[email protected]>
 F:	package/ding-libs/
package/Config.in +1 -0
index e619992..dc0d8d1 100644
@@ -497,6 +497,7 @@ endmenu
 	source "package/stm32flash/Config.in"
 	source "package/sunxi-cedarx/Config.in"
 	source "package/sunxi-mali/Config.in"
+	source "package/sunxi-mali-mainline/Config.in"
 	source "package/sunxi-mali-driver-mainline/Config.in"
 	source "package/sysstat/Config.in"
 	source "package/targetcli-fb/Config.in"
package/sunxi-mali-mainline/Config.in new file +36 -0
new file mode 100644
index 0000000..3bf5a8d
@@ -0,0 +1,36 @@
+config BR2_PACKAGE_SUNXI_MALI_MAINLINE
+	bool "sunxi-mali-mainline"
+	depends on BR2_arm
+	depends on BR2_ARM_EABIHF
+	depends on BR2_TOOLCHAIN_USES_GLIBC
+	select BR2_PACKAGE_HAS_LIBEGL
+	select BR2_PACKAGE_HAS_LIBGLES
+	help
+	  Install userspace Allwinner OpenGL libraries.
+	
+	  https://github.com/free-electrons/mali-blobs
+
+if BR2_PACKAGE_SUNXI_MALI_MAINLINE
+
+config BR2_PACKAGE_PROVIDES_LIBEGL
+	default "sunxi-mali-mainline"
+
+config BR2_PACKAGE_PROVIDES_LIBGLES
+	default "sunxi-mali-mainline"
+
+choice
+	prompt "Version"
+	default BR2_PACKAGE_SUNXI_MALI_MAINLINE_R6P2
+	help
+	  Select the version of the userspace module.
+
+config BR2_PACKAGE_SUNXI_MALI_MAINLINE_R6P2
+	bool "r6p2"
+
+endchoice
+
+endif
+
+comment "sunxi-mali needs an EABIhf glibc toolchain"
+	depends on BR2_arm
+	depends on !BR2_TOOLCHAIN_USES_GLIBC || !BR2_ARM_EABIHF
package/sunxi-mali-mainline/egl.pc new file +12 -0
new file mode 100644
index 0000000..3854e5f
@@ -0,0 +1,12 @@
+prefix=/usr/
+exec_prefix=${prefix}
+libdir=${exec_prefix}/lib
+includedir=${prefix}/include
+
+Name: egl
+Description: ARM Mali implementation of EGL
+Version: 1.4
+Requires:
+Libs: -L${libdir} -lEGL -lGLESv2
+Cflags: -I${includedir}
+
package/sunxi-mali-mainline/glesv2.pc new file +12 -0
new file mode 100644
index 0000000..6910b46
@@ -0,0 +1,12 @@
+prefix=/usr
+exec_prefix=${prefix}
+libdir=${exec_prefix}/lib
+includedir=${prefix}/include
+
+Name: glesv2
+Description: ARM Mali implementation of OpenGL ESv2
+Version: 2.0
+Requires:
+Libs: -L${libdir} -lGLESv2 -lGLESv1_CM
+Cflags: -I${includedir}
+
package/sunxi-mali-mainline/sunxi-mali-mainline.mk new file +33 -0
new file mode 100644
index 0000000..1f7c05c
@@ -0,0 +1,33 @@
+################################################################################
+#
+# sunxi-mali-mainline
+#
+################################################################################
+
+SUNXI_MALI_MAINLINE_VERSION = cb3e8ece9b2c3a70cbeb3204cd6f30eceaa32023
+SUNXI_MALI_MAINLINE_SITE = $(call github,free-electrons,mali-blobs,$(SUNXI_MALI_MAINLINE_VERSION))
+SUNXI_MALI_MAINLINE_INSTALL_STAGING = YES
+SUNXI_MALI_MAINLINE_PROVIDES = libegl libgles
+
+ifeq ($(BR2_PACKAGE_SUNXI_MALI_MAINLINE_R6P2),y)
+SUNXI_MALI_LIB_VER=r6p2
+endif
+
+define SUNXI_MALI_MAINLINE_INSTALL_STAGING_CMDS
+	cp -rf $(@D)/$(SUNXI_MALI_LIB_VER)/fbdev/lib/lib_fb_dev/* \
+		$(STAGING_DIR)/usr/lib/
+	cp -rf $(@D)/$(SUNXI_MALI_LIB_VER)/fbdev/include/* \
+		$(STAGING_DIR)/usr/include/
+
+	$(INSTALL) -D -m 0644 package/sunxi-mali-mainline/egl.pc \
+		$(STAGING_DIR)/usr/lib/pkgconfig/egl.pc
+	$(INSTALL) -D -m 0644 package/sunxi-mali-mainline/glesv2.pc \
+		$(STAGING_DIR)/usr/lib/pkgconfig/glesv2.pc
+endef
+
+define SUNXI_MALI_MAINLINE_INSTALL_TARGET_CMDS
+	cp -rf $(@D)/$(SUNXI_MALI_LIB_VER)/fbdev/lib/lib_fb_dev/* \
+		$(TARGET_DIR)/usr/lib/
+endef
+
+$(eval $(generic-package))
Signature · 1 line
2.7.4
#2 lore raw

PATCH 2/2 sunxi-mali-mainline: new package

Quoted 7 lines · Giulio Benetti

Add Allwinner Mali openGL userspace driver r6p2.
Used combined with kernelspace Mali driver,
it gives possibility to use 3D openGL SoC acceleration. It provides fbdev libraries and headers.
It is compatible with Linux >= 4.4 as sunxi-mali-driver-mainline.

Maxime

Signature · 10 lines
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20171127/72990ea7/attachment.asc>
#3 lore raw

PATCH 2/2 sunxi-mali-mainline: new package

In reply to Giulio Benetti
Quoted 27 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Giulio" == Giulio Benetti <[email protected]> writes:

Add Allwinner Mali openGL userspace driver r6p2.
Used combined with kernelspace Mali driver,
it gives possibility to use 3D openGL SoC acceleration. It provides fbdev libraries and headers.
It is compatible with Linux >= 4.4 as sunxi-mali-driver-mainline.

---
 DEVELOPERS                                         |  1 +
 package/Config.in                                  |  1 +
 package/sunxi-mali-mainline/Config.in              | 36 ++++++++++++++++++++++
 package/sunxi-mali-mainline/egl.pc                 | 12 ++++++++
 package/sunxi-mali-mainline/glesv2.pc              | 12 ++++++++
 package/sunxi-mali-mainline/sunxi-mali-mainline.mk | 33 ++++++++++++++++++++
 6 files changed, 95 insertions(+)
 create mode 100644 package/sunxi-mali-mainline/Config.in
 create mode 100644 package/sunxi-mali-mainline/egl.pc
 create mode 100644 package/sunxi-mali-mainline/glesv2.pc
 create mode 100644 package/sunxi-mali-mainline/sunxi-mali-mainline.mk
DEVELOPERS +0 -0
index 60a934e..b26706b 100644

DEVELOPERS F: package/webp/ · line 703

Quoted 4 lines
DEVELOPERS +1 -0
@@ -700,6 +700,7 @@ F:	package/webp/
 
 N:	Giulio Benetti <[email protected]>
 F:	package/sunxi-mali-driver-mainline/
+F:	package/sunxi-mali-mainline/

In Buildroot we "always" build user space and optionally build a Linux kernel, so I've swapped these two packages around.

Quoted 6 lines
DEVELOPERS +5 -0
+++ b/package/sunxi-mali-mainline/sunxi-mali-mainline.mk
@@ -0,0 +1,33 @@
+################################################################################
+#
+# sunxi-mali-mainline
+#

DEVELOPERS line 14

Quoted 10 lines
DEVELOPERS +10 -0
+################################################################################
+
+SUNXI_MALI_MAINLINE_VERSION = cb3e8ece9b2c3a70cbeb3204cd6f30eceaa32023
+SUNXI_MALI_MAINLINE_SITE = $(call github,free-electrons,mali-blobs,$(SUNXI_MALI_MAINLINE_VERSION))
+SUNXI_MALI_MAINLINE_INSTALL_STAGING = YES
+SUNXI_MALI_MAINLINE_PROVIDES = libegl libgles
+
+ifeq ($(BR2_PACKAGE_SUNXI_MALI_MAINLINE_R6P2),y)
+SUNXI_MALI_LIB_VER=r6p2
+endif

Variables should be prefixed with the package name. You have all the other version logic in the Config.in, so I've changed it to use a BR2_PACKAGE_SUNXI_MALI_MAINLINE_REVISION symbol in Config.in and then assign that to SUNXI_MALI_MAINLINE_REV similar to E.G. how it is done for linux-headers.

Quoted 7 lines
DEVELOPERS +7 -0
+
+define SUNXI_MALI_MAINLINE_INSTALL_STAGING_CMDS
+	cp -rf $(@D)/$(SUNXI_MALI_LIB_VER)/fbdev/lib/lib_fb_dev/* \
+		$(STAGING_DIR)/usr/lib/
+	cp -rf $(@D)/$(SUNXI_MALI_LIB_VER)/fbdev/include/* \
+		$(STAGING_DIR)/usr/include/
+

DEVELOPERS line 31

Quoted 10 lines
DEVELOPERS +10 -0
+	$(INSTALL) -D -m 0644 package/sunxi-mali-mainline/egl.pc \
+		$(STAGING_DIR)/usr/lib/pkgconfig/egl.pc
+	$(INSTALL) -D -m 0644 package/sunxi-mali-mainline/glesv2.pc \
+		$(STAGING_DIR)/usr/lib/pkgconfig/glesv2.pc
+endef
+
+define SUNXI_MALI_MAINLINE_INSTALL_TARGET_CMDS
+	cp -rf $(@D)/$(SUNXI_MALI_LIB_VER)/fbdev/lib/lib_fb_dev/* \
+		$(TARGET_DIR)/usr/lib/
+endef

You need to ensure that the destination directories already exist, so I've added the needed mkdir -p calls before.

Committed to next with these fixes, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#4 lore raw

PATCH 2/2 sunxi-mali-mainline: new package

Il 15/02/2018 21:43, Peter Korsgaard ha scritto:

Quoted 28 lines
Quoted 27 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Giulio" == Giulio Benetti <[email protected]> writes:

Add Allwinner Mali openGL userspace driver r6p2.
Used combined with kernelspace Mali driver,
it gives possibility to use 3D openGL SoC acceleration. It provides fbdev libraries and headers.
It is compatible with Linux >= 4.4 as sunxi-mali-driver-mainline.

---
 DEVELOPERS                                         |  1 +
 package/Config.in                                  |  1 +
 package/sunxi-mali-mainline/Config.in              | 36 ++++++++++++++++++++++
 package/sunxi-mali-mainline/egl.pc                 | 12 ++++++++
 package/sunxi-mali-mainline/glesv2.pc              | 12 ++++++++
 package/sunxi-mali-mainline/sunxi-mali-mainline.mk | 33 ++++++++++++++++++++
 6 files changed, 95 insertions(+)
 create mode 100644 package/sunxi-mali-mainline/Config.in
 create mode 100644 package/sunxi-mali-mainline/egl.pc
 create mode 100644 package/sunxi-mali-mainline/glesv2.pc
 create mode 100644 package/sunxi-mali-mainline/sunxi-mali-mainline.mk
DEVELOPERS +0 -0
index 60a934e..b26706b 100644
@@ -700,6 +700,7 @@ F:	package/webp/
Quoted 6 lines

DEVELOPERS F: package/webp/ · line 703

Quoted 3 lines
DEVELOPERS +1 -0
 N:	Giulio Benetti <[email protected]>
 F:	package/sunxi-mali-driver-mainline/
+F:	package/sunxi-mali-mainline/

In Buildroot we "always" build user space and optionally build a Linux kernel, so I've swapped these two packages around.

Ok, I see the point.

Quoted 16 lines
Quoted 16 lines
DEVELOPERS +13 -0
+++ b/package/sunxi-mali-mainline/sunxi-mali-mainline.mk
@@ -0,0 +1,33 @@
+################################################################################
+#
+# sunxi-mali-mainline
+#
+################################################################################
+
+SUNXI_MALI_MAINLINE_VERSION = cb3e8ece9b2c3a70cbeb3204cd6f30eceaa32023
+SUNXI_MALI_MAINLINE_SITE = $(call github,free-electrons,mali-blobs,$(SUNXI_MALI_MAINLINE_VERSION))
+SUNXI_MALI_MAINLINE_INSTALL_STAGING = YES
+SUNXI_MALI_MAINLINE_PROVIDES = libegl libgles
+
+ifeq ($(BR2_PACKAGE_SUNXI_MALI_MAINLINE_R6P2),y)
Quoted 8 lines

DEVELOPERS line 14

Quoted 2 lines
DEVELOPERS +2 -0
+SUNXI_MALI_LIB_VER=r6p2
+endif

Variables should be prefixed with the package name. You have all the other version logic in the Config.in, so I've changed it to use a BR2_PACKAGE_SUNXI_MALI_MAINLINE_REVISION symbol in Config.in and then assign that to SUNXI_MALI_MAINLINE_REV similar to E.G. how it is done for linux-headers.

Cleaner and easier this way.

Quoted 14 lines
Quoted 14 lines
DEVELOPERS +12 -0
+
+define SUNXI_MALI_MAINLINE_INSTALL_STAGING_CMDS
+	cp -rf $(@D)/$(SUNXI_MALI_LIB_VER)/fbdev/lib/lib_fb_dev/* \
+		$(STAGING_DIR)/usr/lib/
+	cp -rf $(@D)/$(SUNXI_MALI_LIB_VER)/fbdev/include/* \
+		$(STAGING_DIR)/usr/include/
+
+	$(INSTALL) -D -m 0644 package/sunxi-mali-mainline/egl.pc \
+		$(STAGING_DIR)/usr/lib/pkgconfig/egl.pc
+	$(INSTALL) -D -m 0644 package/sunxi-mali-mainline/glesv2.pc \
+		$(STAGING_DIR)/usr/lib/pkgconfig/glesv2.pc
+endef
Quoted 8 lines

DEVELOPERS line 31

Quoted 5 lines
DEVELOPERS +5 -0
+
+define SUNXI_MALI_MAINLINE_INSTALL_TARGET_CMDS
+	cp -rf $(@D)/$(SUNXI_MALI_LIB_VER)/fbdev/lib/lib_fb_dev/* \
+		$(TARGET_DIR)/usr/lib/
+endef

You need to ensure that the destination directories already exist, so I've added the needed mkdir -p calls before.

Right, forgotten.

Quoted 2 lines

Committed to next with these fixes, thanks.

Thanks!!

Signature · 10 lines
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
Quoted 1 line
#5 lore raw

PATCH 1/2 sunxi-mali-driver-mainline: new package

In reply to Giulio Benetti

Hi,

Quoted 57 lines · Giulio Benetti

Added kernel allwinner mali driver package. Used combined with userspace Allwinner openGL libraries, it gives possibility to use 3D openGL SoC acceleration.

---
 DEVELOPERS                                         |  3 ++
 package/Config.in                                  |  1 +
 package/sunxi-mali-driver-mainline/Config.in       | 38 ++++++++++++++++++++++
 .../sunxi-mali-driver-mainline.mk                  | 30 +++++++++++++++++
 4 files changed, 72 insertions(+)
 create mode 100644 package/sunxi-mali-driver-mainline/Config.in
 create mode 100644 package/sunxi-mali-driver-mainline/sunxi-mali-driver-mainline.mk
DEVELOPERS +3 -0
index 7621f96..60a934e 100644
@@ -698,6 +698,9 @@ F:	package/ocrad/
 F:	package/tesseract-ocr/
 F:	package/webp/
 
+N:	Giulio Benetti <[email protected]>
+F:	package/sunxi-mali-driver-mainline/
+
 N:	Gregory Dymarek <[email protected]>
 F:	package/ding-libs/
 F:	package/gengetopt/
package/Config.in +1 -0
index fe5ccc4..e619992 100644
@@ -497,6 +497,7 @@ endmenu
 	source "package/stm32flash/Config.in"
 	source "package/sunxi-cedarx/Config.in"
 	source "package/sunxi-mali/Config.in"
+	source "package/sunxi-mali-driver-mainline/Config.in"
 	source "package/sysstat/Config.in"
 	source "package/targetcli-fb/Config.in"
 	source "package/ti-gfx/Config.in"
package/sunxi-mali-driver-mainline/Config.in new file +11 -0
new file mode 100644
index 0000000..1f9ef59
@@ -0,0 +1,38 @@
+comment "sunxi-mali-driver-mainline needs a Linux kernel to be built"
+	depends on !BR2_LINUX_KERNEL
+
+config BR2_PACKAGE_SUNXI_MALI_DRIVER_MAINLINE
+	bool "sunxi-mali-driver-mainline"
+	depends on BR2_LINUX_KERNEL
+	select BR2_LINUX_NEEDS_MODULES # not using kernel-module infra
+	help
+	  This package builds and installs the Linux kernel driver for
+	  the Mali GPU on Allwinner platforms, compatible with recent
+	  Linux kernels (>= 4.4). Note that it should be installed

package/sunxi-mali-driver-mainline/Config.in line 21

Quoted 10 lines
package/sunxi-mali-driver-mainline/Config.in new file +10 -0
+	  together with the corresponding userspace OpenGL libraries,
+	  which are provided as binaries only at:
+	  https://github.com/free-electrons/mali-blobs
+
+	  sunxi-mali-driver-mainline requires a Linux kernel >= 4.4 with the
+	  following options enabled:
+
+	  - CONFIG_CMA
+	  - CONFIG_DMA_CMA
+	  - CONFIG_DRM_FBDEV_OVERALLOC >= 200 for double buffer or more

Sorry for missing that out earlier, but that one is not true. You can achieve the same result using the drm_fbdev_overalloc kernel paremeter.

The rest looks good.

Maxime

Signature · 10 lines
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20171127/fdcc9508/attachment.asc>
#6 lore raw

PATCH 1/2 sunxi-mali-driver-mainline: new package

Hi Maxime,

Il 27/11/2017 15:28, Maxime Ripard ha scritto:

Quoted 65 lines

Hi,

Quoted 62 lines · Giulio Benetti

Added kernel allwinner mali driver package. Used combined with userspace Allwinner openGL libraries, it gives possibility to use 3D openGL SoC acceleration.

---
  DEVELOPERS                                         |  3 ++
  package/Config.in                                  |  1 +
  package/sunxi-mali-driver-mainline/Config.in       | 38 ++++++++++++++++++++++
  .../sunxi-mali-driver-mainline.mk                  | 30 +++++++++++++++++
  4 files changed, 72 insertions(+)

create mode 100644 package/sunxi-mali-driver-mainline/Config.in create mode 100644 package/sunxi-mali-driver-mainline/sunxi-mali-driver-mainline.mk

DEVELOPERS +3 -0
index 7621f96..60a934e 100644
@@ -698,6 +698,9 @@ F:	package/ocrad/
  F:	package/tesseract-ocr/
  F:	package/webp/
 
+N:	Giulio Benetti <[email protected]>
+F:	package/sunxi-mali-driver-mainline/
+
  N:	Gregory Dymarek <[email protected]>
  F:	package/ding-libs/
  F:	package/gengetopt/
package/Config.in +1 -0
index fe5ccc4..e619992 100644
@@ -497,6 +497,7 @@ endmenu
  	source "package/stm32flash/Config.in"
  	source "package/sunxi-cedarx/Config.in"
  	source "package/sunxi-mali/Config.in"
+	source "package/sunxi-mali-driver-mainline/Config.in"
  	source "package/sysstat/Config.in"
  	source "package/targetcli-fb/Config.in"
  	source "package/ti-gfx/Config.in"
package/sunxi-mali-driver-mainline/Config.in new file +16 -0
new file mode 100644
index 0000000..1f9ef59
@@ -0,0 +1,38 @@
+comment "sunxi-mali-driver-mainline needs a Linux kernel to be built"
+	depends on !BR2_LINUX_KERNEL
+
+config BR2_PACKAGE_SUNXI_MALI_DRIVER_MAINLINE
+	bool "sunxi-mali-driver-mainline"
+	depends on BR2_LINUX_KERNEL
+	select BR2_LINUX_NEEDS_MODULES # not using kernel-module infra
+	help
+	  This package builds and installs the Linux kernel driver for
+	  the Mali GPU on Allwinner platforms, compatible with recent
+	  Linux kernels (>= 4.4). Note that it should be installed
+	  together with the corresponding userspace OpenGL libraries,
+	  which are provided as binaries only at:
+	  https://github.com/free-electrons/mali-blobs
+
+	  sunxi-mali-driver-mainline requires a Linux kernel >= 4.4 with the
Quoted 8 lines

package/sunxi-mali-driver-mainline/Config.in line 21

Quoted 5 lines
package/sunxi-mali-driver-mainline/Config.in new file +5 -0
+	  following options enabled:
+
+	  - CONFIG_CMA
+	  - CONFIG_DMA_CMA
+	  - CONFIG_DRM_FBDEV_OVERALLOC >= 200 for double buffer or more

Sorry for missing that out earlier, but that one is not true. You can achieve the same result using the drm_fbdev_overalloc kernel paremeter.

Ok, I add it on Help.

Thanks

Quoted 5 lines

The rest looks good.

Maxime

Signature · 11 lines
Giulio Benetti
R&D Manager &
Advanced Research

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
#7 lore raw

PATCH 1/2 sunxi-mali-driver-mainline: new package

Hello everybody,

Il 27/11/2017 16:23, Giulio Benetti ha scritto:

Quoted 81 lines

Hi Maxime,

Il 27/11/2017 15:28, Maxime Ripard ha scritto:

Quoted 69 lines

Hi,

Quoted 66 lines · Giulio Benetti

Added kernel allwinner mali driver package. Used combined with userspace Allwinner openGL libraries, it gives possibility to use 3D openGL SoC acceleration.

---

? DEVELOPERS???????????????????????????????????????? |? 3 ++
? package/Config.in????????????????????????????????? |? 1 +
? package/sunxi-mali-driver-mainline/Config.in?????? | 38 

++++++++++++++++++++++
? .../sunxi-mali-driver-mainline.mk????????????????? | 30
+++++++++++++++++
? 4 files changed, 72 insertions(+)
? create mode 100644 package/sunxi-mali-driver-mainline/Config.in ? create mode 100644 package/sunxi-mali-driver-mainline/sunxi-mali-driver-mainline.mk

DEVELOPERS +0 -0
index 7621f96..60a934e 100644
@@ -698,6 +698,9 @@ F:??? package/ocrad/

? F:??? package/tesseract-ocr/
? F:??? package/webp/

DEVELOPERS +3 -0
+N:??? Giulio Benetti <[email protected]>
+F:??? package/sunxi-mali-driver-mainline/
+

? N:??? Gregory Dymarek <[email protected]>
? F:??? package/ding-libs/
? F:??? package/gengetopt/

package/Config.in +0 -0
index fe5ccc4..e619992 100644
@@ -497,6 +497,7 @@ endmenu

????? source "package/stm32flash/Config.in"
????? source "package/sunxi-cedarx/Config.in" ????? source "package/sunxi-mali/Config.in"
+??? source "package/sunxi-mali-driver-mainline/Config.in" ????? source "package/sysstat/Config.in"
????? source "package/targetcli-fb/Config.in" ????? source "package/ti-gfx/Config.in"

package/sunxi-mali-driver-mainline/Config.in new file +16 -0
new file mode 100644
index 0000000..1f9ef59
@@ -0,0 +1,38 @@
+comment "sunxi-mali-driver-mainline needs a Linux kernel to be built"
+??? depends on !BR2_LINUX_KERNEL
+
+config BR2_PACKAGE_SUNXI_MALI_DRIVER_MAINLINE
+??? bool "sunxi-mali-driver-mainline"
+??? depends on BR2_LINUX_KERNEL
+??? select BR2_LINUX_NEEDS_MODULES # not using kernel-module infra
+??? help
+????? This package builds and installs the Linux kernel driver for
+????? the Mali GPU on Allwinner platforms, compatible with recent
+????? Linux kernels (>= 4.4). Note that it should be installed
+????? together with the corresponding userspace OpenGL libraries,
+????? which are provided as binaries only at:
+????? https://github.com/free-electrons/mali-blobs
+
+????? sunxi-mali-driver-mainline requires a Linux kernel >= 4.4 with 

the

Quoted 8 lines
Quoted 5 lines

+????? following options enabled:
+
+????? - CONFIG_CMA
+????? - CONFIG_DMA_CMA
+????? - CONFIG_DRM_FBDEV_OVERALLOC >= 200 for double buffer or more

Sorry for missing that out earlier, but that one is not true. You can achieve the same result using the drm_fbdev_overalloc kernel paremeter.

Quoted 1 line

Ok, I add it on Help.

y_morin on #buildroot irc told me that maybe this missing Help phrase can be added by the one who will commit the patch.
Is it ok, or do I have to submit a new patch?

Kind regards

Quoted 10 lines

Thanks

Quoted 5 lines

The rest looks good.

Maxime

Signature · 11 lines
Giulio Benetti
R&D Manager &
Advanced Research

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
#8 lore raw

PATCH 1/2 sunxi-mali-driver-mainline: new package

Hello,

when could it be ok to update git commit SHA1 to the latest and integrate parallel build and last Help description?

Regards

Signature · 13 lines
Giulio Benetti
R&D Manager &
Advanced Research

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642

Il 28/11/2017 00:34, Giulio Benetti ha scritto:
Quoted 104 lines

Hello everybody,

Il 27/11/2017 16:23, Giulio Benetti ha scritto:

Quoted 81 lines

Hi Maxime,

Il 27/11/2017 15:28, Maxime Ripard ha scritto:

Quoted 69 lines

Hi,

Quoted 66 lines · Giulio Benetti

Added kernel allwinner mali driver package. Used combined with userspace Allwinner openGL libraries, it gives possibility to use 3D openGL SoC acceleration.

---

? DEVELOPERS???????????????????????????????????????? |? 3 ++
? package/Config.in????????????????????????????????? |? 1 +
? package/sunxi-mali-driver-mainline/Config.in?????? | 38 

++++++++++++++++++++++
? .../sunxi-mali-driver-mainline.mk????????????????? | 30
+++++++++++++++++
? 4 files changed, 72 insertions(+)
? create mode 100644 package/sunxi-mali-driver-mainline/Config.in ? create mode 100644 package/sunxi-mali-driver-mainline/sunxi-mali-driver-mainline.mk

DEVELOPERS +0 -0
index 7621f96..60a934e 100644
@@ -698,6 +698,9 @@ F:??? package/ocrad/

? F:??? package/tesseract-ocr/
? F:??? package/webp/

DEVELOPERS +3 -0
+N:??? Giulio Benetti <[email protected]>
+F:??? package/sunxi-mali-driver-mainline/
+

? N:??? Gregory Dymarek <[email protected]>
? F:??? package/ding-libs/
? F:??? package/gengetopt/

package/Config.in +0 -0
index fe5ccc4..e619992 100644
@@ -497,6 +497,7 @@ endmenu

????? source "package/stm32flash/Config.in"
????? source "package/sunxi-cedarx/Config.in" ????? source "package/sunxi-mali/Config.in"
+??? source "package/sunxi-mali-driver-mainline/Config.in" ????? source "package/sysstat/Config.in"
????? source "package/targetcli-fb/Config.in" ????? source "package/ti-gfx/Config.in"

package/sunxi-mali-driver-mainline/Config.in new file +16 -0
new file mode 100644
index 0000000..1f9ef59
@@ -0,0 +1,38 @@
+comment "sunxi-mali-driver-mainline needs a Linux kernel to be built"
+??? depends on !BR2_LINUX_KERNEL
+
+config BR2_PACKAGE_SUNXI_MALI_DRIVER_MAINLINE
+??? bool "sunxi-mali-driver-mainline"
+??? depends on BR2_LINUX_KERNEL
+??? select BR2_LINUX_NEEDS_MODULES # not using kernel-module infra
+??? help
+????? This package builds and installs the Linux kernel driver for
+????? the Mali GPU on Allwinner platforms, compatible with recent
+????? Linux kernels (>= 4.4). Note that it should be installed
+????? together with the corresponding userspace OpenGL libraries,
+????? which are provided as binaries only at:
+????? https://github.com/free-electrons/mali-blobs
+
+????? sunxi-mali-driver-mainline requires a Linux kernel >= 4.4 

with the

Quoted 8 lines
Quoted 5 lines

+????? following options enabled:
+
+????? - CONFIG_CMA
+????? - CONFIG_DMA_CMA
+????? - CONFIG_DRM_FBDEV_OVERALLOC >= 200 for double buffer or more

Sorry for missing that out earlier, but that one is not true. You can achieve the same result using the drm_fbdev_overalloc kernel paremeter.

Quoted 1 line

Ok, I add it on Help.

y_morin on #buildroot irc told me that maybe this missing Help phrase can be added by the one who will commit the patch.
Is it ok, or do I have to submit a new patch?

Kind regards

Quoted 10 lines

Thanks

Quoted 5 lines

The rest looks good.

Maxime

#9 lore raw

PATCH 1/2 sunxi-mali-driver-mainline: new package

In reply to Giulio Benetti
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Giulio" == Giulio Benetti <[email protected]> writes:

Added kernel allwinner mali driver package. Used combined with userspace Allwinner openGL libraries, it gives possibility to use 3D openGL SoC acceleration.

Quoted 6 lines
---
 DEVELOPERS                                         |  3 ++
 package/Config.in                                  |  1 +
 package/sunxi-mali-driver-mainline/Config.in       | 38 ++++++++++++++++++++++
 .../sunxi-mali-driver-mainline.mk                  | 30 +++++++++++++++++

I've renamed this to sunxi-mali-mainline-driver to better match sunxi-mali-mainline and so it sorts after that package.

package/sunxi-mali-driver-mainline/Config.in line 7

Quoted 9 lines

+++ b/package/sunxi-mali-driver-mainline/Config.in

package/sunxi-mali-driver-mainline/Config.in new file +7 -0
@@ -0,0 +1,38 @@
+comment "sunxi-mali-driver-mainline needs a Linux kernel to be built"
+	depends on !BR2_LINUX_KERNEL
+
+config BR2_PACKAGE_SUNXI_MALI_DRIVER_MAINLINE
+	bool "sunxi-mali-driver-mainline"
+	depends on BR2_LINUX_KERNEL
+	select BR2_LINUX_NEEDS_MODULES # not using kernel-module infra

This package doesn't make any sense without the binary user space component, so I've changed it to also depend on BR2_PACKAGE_SUNXI_MALI_MAINLINE. With that added, the package is only visible if that package is enabled and the Linux kernel is getting built, so it makes sense to enable this package by default, so I've added 'default y'.

Quoted 4 lines
package/sunxi-mali-driver-mainline/Config.in new file +4 -0
+	help
+	  This package builds and installs the Linux kernel driver for
+	  the Mali GPU on Allwinner platforms, compatible with recent
+	  Linux kernels (>= 4.4). Note that it should be installed

package/sunxi-mali-driver-mainline/Config.in line 21

Quoted 10 lines
package/sunxi-mali-driver-mainline/Config.in new file +10 -0
+	  together with the corresponding userspace OpenGL libraries,
+	  which are provided as binaries only at:
+	  https://github.com/free-electrons/mali-blobs
+
+	  sunxi-mali-driver-mainline requires a Linux kernel >= 4.4 with the
+	  following options enabled:
+
+	  - CONFIG_CMA
+	  - CONFIG_DMA_CMA
+	  - CONFIG_DRM_FBDEV_OVERALLOC >= 200 for double buffer or more

I've dropped this last line as suggested by Maxime.

For the CMA options it makes sense to automatically enable these kernel options, so I've added the needed logic in linux.mk to do so.

package/sunxi-mali-driver-mainline/Config.in line 34

Quoted 10 lines
package/sunxi-mali-driver-mainline/Config.in new file +10 -0
+if BR2_PACKAGE_SUNXI_MALI_DRIVER_MAINLINE
+
+choice
+	prompt "Version"
+	default BR2_PACKAGE_SUNXI_MALI_DRIVER_MAINLINE_R6P2
+	help
+	  Select the version of the kernel module.
+
+config BR2_PACKAGE_SUNXI_MALI_DRIVER_MAINLINE_R6P2
+	bool "r6p2"

The user space and kernel driver has to use the same version, so it doesn't make sense to have an independent version selection here.

I've dropped this and instead changed the .mk file to use the SUNXI_MALI_MAINLINE_REV variable from that package.

Committed to next with that fixed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#10 lore raw

PATCH 1/2 sunxi-mali-driver-mainline: new package

Il 15/02/2018 22:05, Peter Korsgaard ha scritto:

Quoted 51 lines
Quoted 6 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Giulio" == Giulio Benetti <[email protected]> writes:

Added kernel allwinner mali driver package. Used combined with userspace Allwinner openGL libraries, it gives possibility to use 3D openGL SoC acceleration.

Quoted 6 lines
---
 DEVELOPERS                                         |  3 ++
 package/Config.in                                  |  1 +
 package/sunxi-mali-driver-mainline/Config.in       | 38 ++++++++++++++++++++++
 .../sunxi-mali-driver-mainline.mk                  | 30 +++++++++++++++++

I've renamed this to sunxi-mali-mainline-driver to better match sunxi-mali-mainline and so it sorts after that package.

package/sunxi-mali-driver-mainline/Config.in line 7

Quoted 9 lines

+++ b/package/sunxi-mali-driver-mainline/Config.in

package/sunxi-mali-driver-mainline/Config.in new file +7 -0
@@ -0,0 +1,38 @@
+comment "sunxi-mali-driver-mainline needs a Linux kernel to be built"
+	depends on !BR2_LINUX_KERNEL
+
+config BR2_PACKAGE_SUNXI_MALI_DRIVER_MAINLINE
+	bool "sunxi-mali-driver-mainline"
+	depends on BR2_LINUX_KERNEL
+	select BR2_LINUX_NEEDS_MODULES # not using kernel-module infra

This package doesn't make any sense without the binary user space component, so I've changed it to also depend on BR2_PACKAGE_SUNXI_MALI_MAINLINE. With that added, the package is only visible if that package is enabled and the Linux kernel is getting built, so it makes sense to enable this package by default, so I've added 'default y'.

Quoted 4 lines
package/sunxi-mali-driver-mainline/Config.in new file +4 -0
+	help
+	  This package builds and installs the Linux kernel driver for
+	  the Mali GPU on Allwinner platforms, compatible with recent
+	  Linux kernels (>= 4.4). Note that it should be installed

package/sunxi-mali-driver-mainline/Config.in line 21

Quoted 10 lines
package/sunxi-mali-driver-mainline/Config.in new file +10 -0
+	  together with the corresponding userspace OpenGL libraries,
+	  which are provided as binaries only at:
+	  https://github.com/free-electrons/mali-blobs
+
+	  sunxi-mali-driver-mainline requires a Linux kernel >= 4.4 with the
+	  following options enabled:
+
+	  - CONFIG_CMA
+	  - CONFIG_DMA_CMA
+	  - CONFIG_DRM_FBDEV_OVERALLOC >= 200 for double buffer or more

I've dropped this last line as suggested by Maxime.

Quoted 2 lines

For the CMA options it makes sense to automatically enable these kernel options, so I've added the needed logic in linux.mk to do so.

New thing learnt.

Quoted 16 lines

package/sunxi-mali-driver-mainline/Config.in line 34

Quoted 12 lines
package/sunxi-mali-driver-mainline/Config.in new file +10 -0
+if BR2_PACKAGE_SUNXI_MALI_DRIVER_MAINLINE
+
+choice
+	prompt "Version"
+	default BR2_PACKAGE_SUNXI_MALI_DRIVER_MAINLINE_R6P2
+	help
+	  Select the version of the kernel module.
+
+config BR2_PACKAGE_SUNXI_MALI_DRIVER_MAINLINE_R6P2
+	bool "r6p2"

The user space and kernel driver has to use the same version, so it doesn't make sense to have an independent version selection here.

Quoted 2 lines

I've dropped this and instead changed the .mk file to use the SUNXI_MALI_MAINLINE_REV variable from that package.

Right.

Thank you very much for helping me on this, it was not so easy as first package to me.

Signature · 10 lines
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
Quoted 3 lines

Committed to next with that fixed, thanks.

#11 lore raw

PATCH 1/2 sunxi-mali-driver-mainline: new package

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Giulio" == Giulio Benetti <[email protected]> writes:

Hi,

Quoted 2 lines

Thank you very much for helping me on this,
it was not so easy as first package to me.

You are welcome, thank you for contributing!

As you perhaps noticed, I've also bumped the sunxi-mali-mainline-driver version for 4.15 support:

https://git.busybox.net/buildroot/commit/?h=next&id=1d339809d61aeed2911291830581f643596a2e5c

Signature · 1 line
Bye, Peter Korsgaard
#12 lore raw

PATCH 1/2 sunxi-mali-driver-mainline: new package

Hi,

Il 15/02/2018 23:03, Peter Korsgaard ha scritto:

Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Giulio" == Giulio Benetti <[email protected]> writes:

Hi,

Quoted 2 lines

Thank you very much for helping me on this,
it was not so easy as first package to me.

Quoted 6 lines

You are welcome, thank you for contributing!

As you perhaps noticed, I've also bumped the sunxi-mali-mainline-driver version for 4.15 support:

https://git.busybox.net/buildroot/commit/?h=next&id=1d339809d61aeed2911291830581f643596a2e5c

Yes, I've seen, I'm almost trying to rebuild. I've seen you use quilt before calling build.sh script. But build.sh should call it by itself.
Now I check and eventually I send you a patch.

As soon as Maxime accepts my PR on sunxi-mali we can bump again for 4.16-rc1 building.

Ah, one question, you figure as Author because you've reworked heavily the patch, right? (and it seems more than right to me)
Or was it a mistake?

Quoted 1 line
Signature · 10 lines
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
#13 lore raw

PATCH 1/2 sunxi-mali-driver-mainline: new package

Quoted 13 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Giulio" == Giulio Benetti <[email protected]> writes:

Hi,
Il 15/02/2018 23:03, Peter Korsgaard ha scritto:

Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Giulio" == Giulio Benetti <[email protected]> writes:

Hi,

Quoted 2 lines

Thank you very much for helping me on this,
it was not so easy as first package to me.

You are welcome, thank you for contributing!

Quoted 8 lines
Quoted 4 lines

As you perhaps noticed, I've also bumped the sunxi-mali-mainline-driver version for 4.15 support:

https://git.busybox.net/buildroot/commit/?h=next&id=1d339809d61aeed2911291830581f643596a2e5c

Yes, I've seen, I'm almost trying to rebuild. I've seen you use quilt before calling build.sh script. But build.sh should call it by itself.

No, I'm NOT using quilt. quilt is not a required dependency for Buildroot (and we don't have a host-quilt package), so I'm tweaking build.sh to use our apply-patches.sh script like we use to apply our patches instead of quilt.

Quoted 3 lines

Ah, one question, you figure as Author because you've reworked heavily the patch, right? (and it seems more than right to me)
Or was it a mistake?

Ups, that was mistake. I wanted to keep you authorship for the 2 patches, but me for the version bump - But apparently git ends up changing the authorship when you squash commits which I did to apply the various fixups - Sorry about that!

Signature · 1 line
Bye, Peter Korsgaard
#14 lore raw

PATCH 1/2 sunxi-mali-driver-mainline: new package

Hi,

Il 15/02/2018 23:32, Peter Korsgaard ha scritto:

Quoted 18 lines
Quoted 17 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Giulio" == Giulio Benetti <[email protected]> writes:

Hi,
Il 15/02/2018 23:03, Peter Korsgaard ha scritto:

Quoted 13 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Giulio" == Giulio Benetti <[email protected]> writes:

Hi,

Quoted 2 lines

Thank you very much for helping me on this,
it was not so easy as first package to me.

You are welcome, thank you for contributing!

As you perhaps noticed, I've also bumped the sunxi-mali-mainline-driver version for 4.15 support:

https://git.busybox.net/buildroot/commit/?h=next&id=1d339809d61aeed2911291830581f643596a2e5c

Quoted 8 lines
Quoted 3 lines

Yes, I've seen, I'm almost trying to rebuild. I've seen you use quilt before calling build.sh script. But build.sh should call it by itself.

No, I'm NOT using quilt. quilt is not a required dependency for Buildroot (and we don't have a host-quilt package), so I'm tweaking build.sh to use our apply-patches.sh script like we use to apply our patches instead of quilt.

Ah right, not host-quilt, now I've got the point.
Of course I had quilt installed on my host :)

Quoted 9 lines
Quoted 4 lines

Ah, one question, you figure as Author because you've reworked heavily the patch, right? (and it seems more than right to me)
Or was it a mistake?

Ups, that was mistake. I wanted to keep you authorship for the 2 patches, but me for the version bump - But apparently git ends up changing the authorship when you squash commits which I did to apply the various fixups - Sorry about that!

No problem! It was only to understand.
Thanks again

Signature · 10 lines
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
Quoted 1 line
#15 lore raw

PATCH 1/2 sunxi-mali-driver-mainline: new package

In reply to Peter Korsgaard

Hi,

Il 15/02/2018 23:32, Peter Korsgaard ha scritto:

Quoted 18 lines
Quoted 17 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Giulio" == Giulio Benetti <[email protected]> writes:

Hi,
Il 15/02/2018 23:03, Peter Korsgaard ha scritto:

Quoted 13 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Giulio" == Giulio Benetti <[email protected]> writes:

Hi,

Quoted 2 lines

Thank you very much for helping me on this,
it was not so easy as first package to me.

You are welcome, thank you for contributing!

As you perhaps noticed, I've also bumped the sunxi-mali-mainline-driver version for 4.15 support:

https://git.busybox.net/buildroot/commit/?h=next&id=1d339809d61aeed2911291830581f643596a2e5c

Quoted 8 lines
Quoted 3 lines

Yes, I've seen, I'm almost trying to rebuild. I've seen you use quilt before calling build.sh script. But build.sh should call it by itself.

No, I'm NOT using quilt. quilt is not a required dependency for Buildroot (and we don't have a host-quilt package), so I'm tweaking build.sh to use our apply-patches.sh script like we use to apply our patches instead of quilt.

Would it make sense to add host-quilt package?

Quoted 10 lines
Quoted 4 lines

Ah, one question, you figure as Author because you've reworked heavily the patch, right? (and it seems more than right to me)
Or was it a mistake?

Ups, that was mistake. I wanted to keep you authorship for the 2 patches, but me for the version bump - But apparently git ends up changing the authorship when you squash commits which I did to apply the various fixups - Sorry about that!

Signature · 10 lines
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
#16 lore raw

PATCH 1/2 sunxi-mali-driver-mainline: new package

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Giulio" == Giulio Benetti <[email protected]> writes:

Hi,

Quoted 6 lines
Quoted 4 lines

No, I'm NOT using quilt. quilt is not a required dependency for Buildroot (and we don't have a host-quilt package), so I'm tweaking build.sh to use our apply-patches.sh script like we use to apply our patches instead of quilt.

Would it make sense to add host-quilt package?

Well, we could - But as it is fairly simple to patch build.sh to use apply-patches.sh and no other packages currently needs it I decided not to do so yet.

Signature · 1 line
Bye, Peter Korsgaard
#17 lore raw

PATCH 1/2 sunxi-mali-driver-mainline: new package

Hi,

Il 16/02/2018 13:26, Peter Korsgaard ha scritto:

Quoted 9 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Giulio" == Giulio Benetti <[email protected]> writes:

Hi,

Quoted 4 lines
Quoted 4 lines

No, I'm NOT using quilt. quilt is not a required dependency for Buildroot (and we don't have a host-quilt package), so I'm tweaking build.sh to use our apply-patches.sh script like we use to apply our patches instead of quilt.

Quoted 5 lines
Quoted 1 line

Would it make sense to add host-quilt package?

Well, we could - But as it is fairly simple to patch build.sh to use apply-patches.sh and no other packages currently needs it I decided not to do so yet.

Ok, thanks.

Signature · 10 lines
Giulio Benetti
CTO

MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
Quoted 1 line