Skip to contentSkip to conversation

package/libcue: is not parallel-safe

PATCH New Romain Naour 3 participants 7 messages Dec 21, 2017 – Dec 31, 2017

lore
Share & tools
lore

Romain Naour

author
#0 lore raw

PATCH 1/1 package/libcue: is not parallel-safe

The last commit before the 1.4.0 release was to disable parallel build [1]

[1] https://github.com/lipnitsk/libcue/commit/bebbc18a8c00a0b8c26bc6191af68c6a83629b40

Fixes:
http://autobuild.buildroot.net/results/f25/f256037ca3d49f96add8ca2e2f9c980f5f9d764e
http://autobuild.buildroot.net/results/d84/d84c7d0cb9cf5fa9996c42149eda5295700516f5

Signed-off-by Romain Naour <[email protected]>
---
 package/libcue/libcue.mk | 2 ++
 1 file changed, 2 insertions(+)
package/libcue/libcue.mk +2 -0
index 3aa3b4815f..7f8e45ecec 100644
@@ -12,6 +12,8 @@ LIBCUE_DEPENDENCIES = host-bison host-flex flex
 LIBCUE_INSTALL_STAGING = YES
 LIBCUE_AUTORECONF = YES
 
+LIBCUE_MAKE = $(MAKE1)
+
 # Needed for autoreconf
 define LIBCUE_MAKE_CONFIG_DIR
 	mkdir $(@D)/config
Signature · 1 line
2.14.3
#1 lore raw

PATCH 1/1 package/libcue: is not parallel-safe

Romain, All,

On 2017-12-21 17:48 +0100, Romain Naour spake thusly:

Quoted 9 lines

The last commit before the 1.4.0 release was to disable parallel build [1]

[1] https://github.com/lipnitsk/libcue/commit/bebbc18a8c00a0b8c26bc6191af68c6a83629b40

Fixes:
http://autobuild.buildroot.net/results/f25/f256037ca3d49f96add8ca2e2f9c980f5f9d764e
http://autobuild.buildroot.net/results/d84/d84c7d0cb9cf5fa9996c42149eda5295700516f5

Signed-off-by Romain Naour <[email protected]>
Reviewed-by ME

However, isn't it time to update? 1.4.0 was released in 2010, and there have been new releases since then, the most recent, 2.2.0, in November 2017, and they switched to cmake.

Regards,
Yann E. MORIN.

Quoted 24 lines
---
 package/libcue/libcue.mk | 2 ++
 1 file changed, 2 insertions(+)
package/libcue/libcue.mk +2 -0
index 3aa3b4815f..7f8e45ecec 100644
@@ -12,6 +12,8 @@ LIBCUE_DEPENDENCIES = host-bison host-flex flex
 LIBCUE_INSTALL_STAGING = YES
 LIBCUE_AUTORECONF = YES
 
+LIBCUE_MAKE = $(MAKE1)
+
 # Needed for autoreconf
 define LIBCUE_MAKE_CONFIG_DIR
 	mkdir $(@D)/config
Signature · 6 lines
2.14.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH 1/1 package/libcue: is not parallel-safe

On 2017-12-21 18:02 +0100, Yann E. MORIN spake thusly:

Quoted 7 lines

Romain, All,

On 2017-12-21 17:48 +0100, Romain Naour spake thusly:

Quoted 4 lines

The last commit before the 1.4.0 release was to disable parallel build [1]

[1] https://github.com/lipnitsk/libcue/commit/bebbc18a8c00a0b8c26bc6191af68c6a83629b40

Quoted 7 lines
Quoted 5 lines

Fixes:
http://autobuild.buildroot.net/results/f25/f256037ca3d49f96add8ca2e2f9c980f5f9d764e
http://autobuild.buildroot.net/results/d84/d84c7d0cb9cf5fa9996c42149eda5295700516f5

Signed-off-by Romain Naour <[email protected]>
Reviewed-by ME
Reviewed-by "Yann E. MORIN" <[email protected]>

(It seems that I have a hard time with autocompletion, be it on IRC or in email bodies... Sigh...)

Regards,
Yann E. MORIN.

Quoted 43 lines

However, isn't it time to update? 1.4.0 was released in 2010, and there have been new releases since then, the most recent, 2.2.0, in November 2017, and they switched to cmake.

Regards,
Yann E. MORIN.

Quoted 24 lines
---
 package/libcue/libcue.mk | 2 ++
 1 file changed, 2 insertions(+)
package/libcue/libcue.mk +2 -0
index 3aa3b4815f..7f8e45ecec 100644
@@ -12,6 +12,8 @@ LIBCUE_DEPENDENCIES = host-bison host-flex flex
 LIBCUE_INSTALL_STAGING = YES
 LIBCUE_AUTORECONF = YES
 
+LIBCUE_MAKE = $(MAKE1)
+
 # Needed for autoreconf
 define LIBCUE_MAKE_CONFIG_DIR
 	mkdir $(@D)/config
Signature · 6 lines
2.14.3

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 10 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#3 lore raw

PATCH 1/1 package/libcue: is not parallel-safe

In reply to Romain Naour
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Romain" == Romain Naour <[email protected]> writes:

The last commit before the 1.4.0 release was to disable parallel build [1]
[1] https://github.com/lipnitsk/libcue/commit/bebbc18a8c00a0b8c26bc6191af68c6a83629b40

Fixes:
http://autobuild.buildroot.net/results/f25/f256037ca3d49f96add8ca2e2f9c980f5f9d764e
http://autobuild.buildroot.net/results/d84/d84c7d0cb9cf5fa9996c42149eda5295700516f5

Signed-off-by Romain Naour <[email protected]>

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
author
#4 lore raw

PATCH 1/1 package/libcue: is not parallel-safe

Hi Peter,

Le 22/12/2017 ? 10:17, Peter Korsgaard a ?crit?:

Quoted 5 lines
Quoted 4 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Romain" == Romain Naour <[email protected]> writes:

The last commit before the 1.4.0 release was to disable parallel build [1]
[1] https://github.com/lipnitsk/libcue/commit/bebbc18a8c00a0b8c26bc6191af68c6a83629b40

Quoted 8 lines
Quoted 5 lines

Fixes:
http://autobuild.buildroot.net/results/f25/f256037ca3d49f96add8ca2e2f9c980f5f9d764e
http://autobuild.buildroot.net/results/d84/d84c7d0cb9cf5fa9996c42149eda5295700516f5

Signed-off-by Romain Naour <[email protected]>

Committed, thanks.

This patch needs to be backported to 2017.08 and 2017.02 branches.

http://autobuild.buildroot.net/results/51d/51d585cbf387fb514d04304aa0ea38324a02362e/build-end.log

Best regards,
Romain

#5 lore raw

PATCH 1/1 package/libcue: is not parallel-safe

In reply to Romain Naour
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Romain" == Romain Naour <[email protected]> writes:

The last commit before the 1.4.0 release was to disable parallel build [1]
[1] https://github.com/lipnitsk/libcue/commit/bebbc18a8c00a0b8c26bc6191af68c6a83629b40

Fixes:
http://autobuild.buildroot.net/results/f25/f256037ca3d49f96add8ca2e2f9c980f5f9d764e
http://autobuild.buildroot.net/results/d84/d84c7d0cb9cf5fa9996c42149eda5295700516f5

Signed-off-by Romain Naour <[email protected]>

Committed to 2017.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#6 lore raw

PATCH 1/1 package/libcue: is not parallel-safe

In reply to Romain Naour
Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Romain" == Romain Naour <[email protected]> writes:

The last commit before the 1.4.0 release was to disable parallel build [1]
[1] https://github.com/lipnitsk/libcue/commit/bebbc18a8c00a0b8c26bc6191af68c6a83629b40

Fixes:
http://autobuild.buildroot.net/results/f25/f256037ca3d49f96add8ca2e2f9c980f5f9d764e
http://autobuild.buildroot.net/results/d84/d84c7d0cb9cf5fa9996c42149eda5295700516f5

Signed-off-by Romain Naour <[email protected]>

Committed to 2017.02.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard