Skip to contentSkip to conversation

package/linux-tools: fixes build of iio with 4.14+ kernels

PATCH New julien.boibessot at free.fr 3 participants 5 messages Dec 8, 2017 – Dec 27, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/linux-tools: fixes build of iio with 4.14+ kernels

From: Julien BOIBESSOT <[email protected]>

Since this commit [1], iio build has been moved to other linux-tools build system. Installation dir is now given by DESTDIR, like for all other linux-tools. I kept INSTALL_DIR env and 'install' target to be compatible with oldest kernels.

[1]: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/tools/iio/Makefile?h=v4.14.4&id=18956cf2d78a8d4a5959e20240f04ce8d5a6c121

---
 package/linux-tools/linux-tool-iio.mk.in | 2 ++
 1 file changed, 2 insertions(+)
package/linux-tools/linux-tool-iio.mk.in +2 -0
index 60d6249..a8cc89e 100644
@@ -19,9 +19,11 @@ define IIO_BUILD_CMDS
 		$(IIO_MAKE_OPTS)
 endef
 
+# DESTDIR used since kernel version 4.14
 define IIO_INSTALL_TARGET_CMDS
 	$(TARGET_MAKE_ENV) $(MAKE) -C $(LINUX_DIR)/tools/iio \
 		$(IIO_MAKE_OPTS) \
 		INSTALL_ROOT=$(TARGET_DIR) \
+		DESTDIR=$(TARGET_DIR) \
 		install
 endef
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 package/linux-tools: fixes build of iio with 4.14+ kernels

Hello,

Quoted 7 lines · julien.boibessot at free.fr

From: Julien BOIBESSOT <[email protected]>

Since this commit [1], iio build has been moved to other linux-tools build system. Installation dir is now given by DESTDIR, like for all other linux-tools. I kept INSTALL_DIR env and 'install' target to be compatible with oldest kernels.

Quoted 6 lines

[1]: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/tools/iio/Makefile?h=v4.14.4&id=18956cf2d78a8d4a5959e20240f04ce8d5a6c121

---
 package/linux-tools/linux-tool-iio.mk.in | 2 ++
 1 file changed, 2 insertions(+)

Applied to master after improving the commit log. Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 package/linux-tools: fixes build of iio with 4.14+ kernels

Quoted 10 lines · Thomas Petazzoni

Hello,

Quoted 7 lines · julien.boibessot at free.fr

From: Julien BOIBESSOT <[email protected]>

Since this commit [1], iio build has been moved to other linux-tools build system. Installation dir is now given by DESTDIR, like for all other linux-tools. I kept INSTALL_DIR env and 'install' target to be compatible with oldest kernels.

Quoted 7 lines
Quoted 6 lines

[1]: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/tools/iio/Makefile?h=v4.14.4&id=18956cf2d78a8d4a5959e20240f04ce8d5a6c121

---
 package/linux-tools/linux-tool-iio.mk.in | 2 ++
 1 file changed, 2 insertions(+)

Applied to master after improving the commit log. Thanks!

Thanks Thomas, should I send the same for 2017.02 ?

Regards,
Julien

#3 lore raw

PATCH 1/1 package/linux-tools: fixes build of iio with 4.14+ kernels

Hello,

Quoted 3 lines · Julien Boibessot
Quoted 1 line

Applied to master after improving the commit log. Thanks!

Thanks Thomas, should I send the same for 2017.02 ?

Not needed, Peter will apply it to the 2017.02.x branch.

Ideally, when you know a patch is needed for 2017.02.x, it would be nice to indicate that under the --- sign that follows the Signed-off-by. This way, it is clear for Peter that the submitter wants the patch in 2017.02.x.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#4 lore raw

PATCH 1/1 package/linux-tools: fixes build of iio with 4.14+ kernels

In reply to julien.boibessot at free.fr
Quoted 11 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"julien" == julien boibessot <[email protected]> writes:

From: Julien BOIBESSOT <[email protected]>
Since this commit [1], iio build has been moved to other linux-tools build system. Installation dir is now given by DESTDIR, like for all other linux-tools. I kept INSTALL_DIR env and 'install' target to be compatible with oldest kernels.

[1]: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/tools/iio/Makefile?h=v4.14.4&id=18956cf2d78a8d4a5959e20240f04ce8d5a6c121

Committed to 2017.11.x, thanks.

Signature · 1 line
Bye, Peter Korsgaard