Skip to contentSkip to conversation

Documentation: fix ascii art in networking docs

PATCH In review Pavel Machek 4 participants 5 messages Sep 16, 2017

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Documentation: fix ascii art in networking docs

Fix ascii-art.

---

Resent, because I did not get DaveM's address right.

Documentation/networking/switchdev.txt +1 -1
index 5e40e1f..6309e90 100644
@@ -29,7 +29,7 @@ with SR-IOV or soft switches, such as OVS, are possible.
                       sw1p1  +  sw1p3  +  sw1p5  +          eth1
                         +    |    +    |    +    |            +
                         |    |    |    |    |    |            |
-                     +--+----+----+----+-+--+----+---+  +-----+-----+
+                     +--+----+----+----+----+----+---+  +-----+-----+
                      |         Switch driver         |  |    mgmt   |
                      |        (this document)        |  |   driver  |
                      |                               |  |           |
Signature · 10 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html



----- End forwarded message -----

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#1 lore raw
Quoted 14 lines · Pavel Machek

Fix ascii-art.

---

Resent, because I did not get DaveM's address right.

Documentation/networking/switchdev.txt +0 -0
index 5e40e1f..6309e90 100644

Documentation/networking/switchdev.txt with SR-IOV or soft switches, such as OVS, are possible. · line 35

Quoted 8 lines
Documentation/networking/switchdev.txt +1 -1
@@ -29,7 +29,7 @@ with SR-IOV or soft switches, such as OVS, are possible.
 ??????????????????????????????????????????????????????????????????sw1p1??? +  sw1p3  + ???sw1p5  +  ????????????????????????eth1
 ????????????????????????????????????????????????????????????????????????+????????????|????????????+????????????|????????????+????????????|????????????????????????????????????+
 ????????????????????????????????????????????????????????????????????????|????????????|????????????|????????????|????????????|????????????|????????????????????????????????????|
-???????????????????????????????????????????????????????????????+--+----+----+----+-+--+----+---+??????+-----+-----+
+???????????????????????????????????????????????????????????????+--+----+----+----+----+----+---+??????+-----+-----+
 ???????????????????????????????????????????????????????????????|???????????????????????????Switch???driver???????????????????????????|??????|????????????mgmt?????????|
 ???????????????????????????????????????????????????????????????|????????????????????????(this???document)????????????????????????|??????|?????????driver??????|
 ???????????????????????????????????????????????????????????????|?????????????????????????????????????????????????????????????????????????????????????????????|??????|?????????????????????????????????|

Hi Pavel

This is not very readable. Has the patch been mangled by your email?

Andrew

#2 lore raw
In reply to Pavel Machek
Quoted 6 lines · Pavel Machek
Documentation/networking/switchdev.txt +0 -0
index 5e40e1f..6309e90 100644

Documentation/networking/switchdev.txt with SR-IOV or soft switches, such as OVS, are possible. · line 35

Quoted 8 lines
Documentation/networking/switchdev.txt +1 -1
@@ -29,7 +29,7 @@ with SR-IOV or soft switches, such as OVS, are possible.
                       sw1p1  +  sw1p3  +  sw1p5  +          eth1
                         +    |    +    |    +    |            +
                         |    |    |    |    |    |            |
-                     +--+----+----+----+-+--+----+---+  +-----+-----+
+                     +--+----+----+----+----+----+---+  +-----+-----+
                      |         Switch driver         |  |    mgmt   |
                      |        (this document)        |  |   driver  |
                      |                               |  |           |

This is all mis-aligned. How about replacing all the thin space characters by normal spaces?

Andreas.

Signature · 3 lines
Andreas Schwab, [email protected]
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
#3 lore raw
Quoted 11 lines · Andreas Schwab
Quoted 9 lines · Pavel Machek
Documentation/networking/switchdev.txt +0 -1
index 5e40e1f..6309e90 100644
@@ -29,7 +29,7 @@ with SR-IOV or soft switches, such as OVS, are possible.
                       sw1p1  +  sw1p3  +  sw1p5  +          eth1
                         +    |    +    |    +    |            +
                         |    |    |    |    |    |            |
-                     +--+----+----+----+-+--+----+---+  +-----+-----+
Quoted 8 lines

Documentation/networking/switchdev.txt with SR-IOV or soft switches, such as OVS, are possible. · line 35

Quoted 5 lines
Documentation/networking/switchdev.txt +1 -0
+                     +--+----+----+----+----+----+---+  +-----+-----+
                      |         Switch driver         |  |    mgmt   |
                      |        (this document)        |  |   driver  |
                      |                               |  |           |

This is all mis-aligned. How about replacing all the thin space characters by normal spaces?

It looked perfectly ok to me, in emacs. If you see a problem, please submit followup patch.
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
reviewer
#4 lore raw
In reply to Andreas Schwab
Quoted 11 lines · Andreas Schwab
Quoted 9 lines · Pavel Machek
Documentation/networking/switchdev.txt +0 -1
index 5e40e1f..6309e90 100644
@@ -29,7 +29,7 @@ with SR-IOV or soft switches, such as OVS, are possible.
                       sw1p1  +  sw1p3  +  sw1p5  +          eth1
                         +    |    +    |    +    |            +
                         |    |    |    |    |    |            |
-                     +--+----+----+----+-+--+----+---+  +-----+-----+
Quoted 8 lines

Documentation/networking/switchdev.txt with SR-IOV or soft switches, such as OVS, are possible. · line 35

Quoted 5 lines
Documentation/networking/switchdev.txt +1 -0
+                     +--+----+----+----+----+----+---+  +-----+-----+
                      |         Switch driver         |  |    mgmt   |
                      |        (this document)        |  |   driver  |
                      |                               |  |           |

This is all mis-aligned. How about replacing all the thin space characters by normal spaces?

Yes, there are lots of non-ASCII "spaces" in the ASCII art. :(

Signature · 1 line
~Randy