Skip to contentSkip to conversation

cbootimage: disable on musl

PATCH New Thomas Petazzoni 2 participants 2 messages Feb 14, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cbootimage: disable on musl

cbootimage uses non-standard u_intXX_t types instead of the C99 types uintXX_t types, which prevents it from building with the musl C library.

A patch to fix this has been submitted upstream, but since there are many many occurences of such types, the patch is a bit large to carry in Buildroot, especially compared to the fact that having this package building against musl is probably not a top priority.

So for now, simply disable this package on musl, until upstream fixes the issue and releases a new version.

Fixes:

http://autobuild.buildroot.net/results/61bdfb7e0ff9628190d9eb86e40c4c90e768b8e2

---
 package/cbootimage/Config.in | 7 +++++++
 1 file changed, 7 insertions(+)
package/cbootimage/Config.in +7 -0
index 1a7fef0..b798e5d 100644
@@ -1,9 +1,16 @@
 config BR2_PACKAGE_CBOOTIMAGE
 	bool "cbootimage"
 	depends on BR2_arm || BR2_armeb
+	# uses non-standard u_intXX_t types
+	# https://github.com/NVIDIA/cbootimage/pull/7
+	depends on !BR2_TOOLCHAIN_USES_MUSL
 	help
 	  This project provides a tool which compiles BCT (Boot
 	  Configuration Table) images to place into the boot flash of
 	  a Tegra-based device.
 
 	  https://github.com/NVIDIA/cbootimage
+
+comment "cbootimage needs a glibc or uClibc toolchain"
+	depends on BR2_arm || BR2_armeb
+	depends on BR2_TOOLCHAIN_USES_MUSL
Signature · 1 line
2.7.4
#1 lore raw

PATCH 1/1 cbootimage: disable on musl

Quoted 10 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

cbootimage uses non-standard u_intXX_t types instead of the C99 types uintXX_t types, which prevents it from building with the musl C library.

A patch to fix this has been submitted upstream, but since there are many many occurences of such types, the patch is a bit large to carry in Buildroot, especially compared to the fact that having this package building against musl is probably not a top priority.

Quoted 8 lines

So for now, simply disable this package on musl, until upstream fixes the issue and releases a new version.

Fixes:

http://autobuild.buildroot.net/results/61bdfb7e0ff9628190d9eb86e40c4c90e768b8e2

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard