Skip to contentSkip to conversation

binutils: backport fix for xg_reverse_shift_count

PATCH New Max Filippov 2 participants 2 messages Feb 6, 2017

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 binutils: backport fix for xg_reverse_shift_count

binutils-2.27 gas has bug that results in the following kind of build error when assembling bb[cs]i.l on big-endian xtensa targets:

ieee754-sf.S:237: Error: invalid symbolic operand

---
 ...tensa.c-fixup-xg_reverse_shift_count-typo.patch | 33 ++++++++++++++++++++++
 1 file changed, 33 insertions(+)
 create mode 100644 package/binutils/2.27/0130-tc-xtensa.c-fixup-xg_reverse_shift_count-typo.patch
package/binutils/2.27/0130-tc-xtensa.c-fixup-xg_reverse_shift_count-typo.patch new file +33 -0
new file mode 100644
index 0000000..7973607
@@ -0,0 +1,33 @@
+From 78fb7e37eb8bb08ae537d6c487996ff17c810332 Mon Sep 17 00:00:00 2001
+From: Trevor Saunders <[email protected]>
+Date: Mon, 26 Sep 2016 12:42:11 -0400
+Subject: [PATCH] tc-xtensa.c: fixup xg_reverse_shift_count typo
+
+gas/ChangeLog:
+
+2016-09-26  Trevor Saunders  <[email protected]>
+
+	* config/tc-xtensa.c (xg_reverse_shift_count): Pass cnt_arg instead of
+	cnt_argp to concat.
+
+Signed-off-by: Max Filippov <[email protected]>
+---
+ gas/config/tc-xtensa.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/gas/config/tc-xtensa.c b/gas/config/tc-xtensa.c
+index d062044..ca261ae 100644
+--- a/gas/config/tc-xtensa.c
++++ b/gas/config/tc-xtensa.c
+@@ -2228,7 +2228,7 @@ xg_reverse_shift_count (char **cnt_argp)
+   cnt_arg = *cnt_argp;
+ 
+   /* replace the argument with "31-(argument)" */
+-  new_arg = concat ("31-(", cnt_argp, ")", (char *) NULL);
++  new_arg = concat ("31-(", cnt_arg, ")", (char *) NULL);
+ 
+   free (cnt_arg);
+   *cnt_argp = new_arg;
+-- 
+2.1.4
+
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 binutils: backport fix for xg_reverse_shift_count

Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Max" == Max Filippov <[email protected]> writes:

binutils-2.27 gas has bug that results in the following kind of build error when assembling bb[cs]i.l on big-endian xtensa targets:

ieee754-sf.S:237: Error: invalid symbolic operand

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard