usb: dwc3: Interrupt moderation
Subsystems (2)
cover usb: dwc3: Interrupt moderation
This patch series implements interrupt moderation and also uses it in implementing a workaround for STAR 9000961433.
John Youn (6):
usb: dwc3: Add a check for the DWC_usb3 core
usb: dwc3: Add a function to check properties
Documentation: devicetree: dwc3: Add interrupt moderation
usb: dwc3: gadget: Write the event count in interrupt
usb: dwc3: Implement interrupt moderation
usb: dwc3: Workaround for irq mask issue
Documentation/devicetree/bindings/usb/dwc3.txt | 1 + drivers/usb/dwc3/core.c | 89 ++++++++++++++++++-------- drivers/usb/dwc3/core.h | 21 ++++++ drivers/usb/dwc3/gadget.c | 20 +++++- 4 files changed, 103 insertions(+), 28 deletions(-)
Signature · 6 lines
2.10.0 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): cover.1477424426.git.johnyoun-HKixBCOQz3hWk0Htik3J/[email protected]
PATCH 3/6 Documentation: devicetree: dwc3: Add interrupt moderation
Add interrupt moderation interval binding for dwc3.
--- Documentation/devicetree/bindings/usb/dwc3.txt | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/usb/dwc3.txt +1 -0
@@ -53,6 +53,7 @@ Optional properties: - snps,quirk-frame-length-adjustment: Value for GFLADJ_30MHZ field of GFLADJ register for post-silicon frame length adjustment when the fladj_30mhz_sdbnd signal is invalid or incorrect. + - snps,imod_interval: the interrupt moderation interval. - <DEPRECATED> tx-fifo-resize: determines if the FIFO *has* to be reallocated.
Signature · 6 lines
2.10.0 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): e7a864e5a2af12d5a8d97f2591065f4aa85f86cb.1477424426.git.johnyoun-HKixBCOQz3hWk0Htik3J/[email protected]
Re: [PATCH 3/6] Documentation: devicetree: dwc3: Add interrupt moderation
Hello.
Quoted 12 lines · John Youn
Add interrupt moderation interval binding for dwc3.
--- Documentation/devicetree/bindings/usb/dwc3.txt | 1 + 1 file changed, 1 insertion(+)Documentation/devicetree/bindings/usb/dwc3.txt +0
-0
Documentation/devicetree/bindings/usb/dwc3.txt Optional properties: · line 56
Quoted 4 lines
Documentation/devicetree/bindings/usb/dwc3.txt +1
-0@@ -53,6 +53,7 @@ Optional properties: - snps,quirk-frame-length-adjustment: Value for GFLADJ_30MHZ field of GFLADJ register for post-silicon frame length adjustment when the fladj_30mhz_sdbnd signal is invalid or incorrect. + - snps,imod_interval: the interrupt moderation interval.
Hyphens are preferred in the DT node/prop names.
[...]
MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): 37f3eec3-b026-97ad-8b33-353a3b93f840-M4DtvfQ/[email protected]
Re: [PATCH 3/6] Documentation: devicetree: dwc3: Add interrupt moderation
Quoted 11 lines · Sergei Shtylyov
Hello.
Quoted 7 lines · John Youn
Add interrupt moderation interval binding for dwc3.
--- Documentation/devicetree/bindings/usb/dwc3.txt | 1 + 1 file changed, 1 insertion(+)
Quoted 12 lines
Documentation/devicetree/bindings/usb/dwc3.txt Optional properties: · line 56
Quoted 9 lines
Documentation/devicetree/bindings/usb/dwc3.txt +1
-0@@ -53,6 +53,7 @@ Optional properties: - snps,quirk-frame-length-adjustment: Value for GFLADJ_30MHZ field of GFLADJ register for post-silicon frame length adjustment when the fladj_30mhz_sdbnd signal is invalid or incorrect. + - snps,imod_interval: the interrupt moderation interval.Hyphens are preferred in the DT node/prop names.
Thanks will fix.
John
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/6] Documentation: devicetree: dwc3: Add interrupt moderation
In reply to a message not in the archiveQuoted 12 lines · John Youn
Add interrupt moderation interval binding for dwc3.
--- Documentation/devicetree/bindings/usb/dwc3.txt | 1 + 1 file changed, 1 insertion(+)Documentation/devicetree/bindings/usb/dwc3.txt +0
-0
Documentation/devicetree/bindings/usb/dwc3.txt Optional properties: · line 56
Quoted 4 lines
Documentation/devicetree/bindings/usb/dwc3.txt +1
-0@@ -53,6 +53,7 @@ Optional properties: - snps,quirk-frame-length-adjustment: Value for GFLADJ_30MHZ field of GFLADJ register for post-silicon frame length adjustment when the fladj_30mhz_sdbnd signal is invalid or incorrect. + - snps,imod_interval: the interrupt moderation interval.
As otherwise commented, s/_/-/
What is "interrupt moderation"? The cover mentions that this is to be used for some kind of workaround, but it's not clear to me what this is, and as such, whether it makes sense to describe it in this manner.
Thanks,
Mark.
Quoted 6 lines
Documentation/devicetree/bindings/usb/dwc3.txt +0
-0- <DEPRECATED> tx-fifo-resize: determines if the FIFO *has* to be reallocated.Signature · 1 line
2.10.0
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/6] Documentation: devicetree: dwc3: Add interrupt moderation
Quoted 8 lines · Mark Rutland
Quoted 7 lines · John Youn
Add interrupt moderation interval binding for dwc3.
--- Documentation/devicetree/bindings/usb/dwc3.txt | 1 + 1 file changed, 1 insertion(+)
Quoted 11 lines
Documentation/devicetree/bindings/usb/dwc3.txt Optional properties: · line 56
Quoted 9 lines
Documentation/devicetree/bindings/usb/dwc3.txt +1
-0@@ -53,6 +53,7 @@ Optional properties: - snps,quirk-frame-length-adjustment: Value for GFLADJ_30MHZ field of GFLADJ register for post-silicon frame length adjustment when the fladj_30mhz_sdbnd signal is invalid or incorrect. + - snps,imod_interval: the interrupt moderation interval.As otherwise commented, s/_/-/
Ok, forgot about that.
Quoted 5 lines
What is "interrupt moderation"? The cover mentions that this is to be used for some kind of workaround, but it's not clear to me what this is, and as such, whether it makes sense to describe it in this manner.
Interrupt moderation throttles the interrupt rate to be no faster than a specified interval. It's an optional feature of the controller.
This series implements the feature and enables it as a workaround for a particular version of the controller.
This binding enables and configures the feature with an interval value which is specified as a number of 250 ns increments.
I'll update the binding text to something like this:
- snps,imod-interval: the interrupt moderation interval, specified in 250 ns increments from 1 to 0xffff.
Regards,
John
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): 36413315-16eb-d690-b559-ab5ae103c5f9-HKixBCOQz3hWk0Htik3J/[email protected]
Re: [PATCH 3/6] Documentation: devicetree: dwc3: Add interrupt moderation
Quoted 6 lines · John Youn
Quoted 4 lines · Mark Rutland
Quoted 3 lines · John Youn
Add interrupt moderation interval binding for dwc3.
+ - snps,imod_interval: the interrupt moderation interval.
Quoted 7 lines
Quoted 4 lines
What is "interrupt moderation"? The cover mentions that this is to be used for some kind of workaround, but it's not clear to me what this is, and as such, whether it makes sense to describe it in this manner.
Interrupt moderation throttles the interrupt rate to be no faster than a specified interval. It's an optional feature of the controller.
Ok.
Quoted 2 lines
This series implements the feature and enables it as a workaround for a particular version of the controller.
... as a workaround for *what*? Is there a bug in that IP version, or an integration issue? Does the problem vary per-board?
Generally, if there's a problem that needs to be worked around, we describe the problem in the DT (perhaps implicitly in the compatible string), and then the kernel chooses the workaround.
Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/6] Documentation: devicetree: dwc3: Add interrupt moderation
Hi,
Quoted 15 lines · Mark Rutland
Quoted 6 lines · John Youn
Quoted 4 lines · Mark Rutland
Quoted 3 lines · John Youn
Add interrupt moderation interval binding for dwc3.
+ - snps,imod_interval: the interrupt moderation interval.
Quoted 7 lines
Quoted 4 lines
What is "interrupt moderation"? The cover mentions that this is to be used for some kind of workaround, but it's not clear to me what this is, and as such, whether it makes sense to describe it in this manner.
Interrupt moderation throttles the interrupt rate to be no faster than a specified interval. It's an optional feature of the controller.
Quoted 6 lines
Ok.
Quoted 2 lines
This series implements the feature and enables it as a workaround for a particular version of the controller.
... as a workaround for *what*? Is there a bug in that IP version, or an
you didn't receive the entire series, I guess. Here's last patch in the series:
This is a workaround for STAR 9000961433 which affects only version 3.00a of the DWC_usb3 core. This prevents the controller interrupt from being masked while handling events. Enabling interrupt moderation allows us to work around this issue because once the GEVNTCOUNT.count is written the IRQ is immediately deasserted and won't be asserted again until GEVNTCOUNT.EHB is cleared.
---
drivers/usb/dwc3/core.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index 6733838..7fa0832 100644
--- a/drivers/usb/dwc3/core.c
+++ b/drivers/usb/dwc3/core.c
@@ -1050,6 +1050,18 @@ static void dwc3_check_params(struct dwc3 *dwc)
dwc->imod_interval = 0; }
+ /*
+ * Workaround for STAR 9000961433 which affects only version
+ * 3.00a of the DWC_usb3 core. This prevents the controller
+ * interrupt from being masked while handling events. IMOD
+ * allows us to work around this issue. Enable it for the
+ * affected version.
+ */
+ if (!dwc->imod_interval &&
+ (dwc->revision == DWC3_REVISION_300A)) {
+ dwc->imod_interval = 1;
+ }
+
/* Check the maximum_speed parameter */
switch (dwc->maximum_speed) {
case USB_SPEED_LOW:Quoted 5 lines
integration issue? Does the problem vary per-board?
Generally, if there's a problem that needs to be worked around, we describe the problem in the DT (perhaps implicitly in the compatible string), and then the kernel chooses the workaround.
Regardless of the silicon erratum, interrupt moderation is a *feature* of the IP, common to all instances since revision v3.00a (IIRC). John is just using interrupt moderation in the context of implementing this workaround. But the actual feature is valid also without the erratum.
Another thing to remember is that different applications (i.e. boards) might want to moderate the interrupt for different periods. That's, again, not related to the erratum at all.
We cannot use compatible to figure this one out. dwc3 does as much runtime discovery as possible, but we cannot discover what is the desired interrupt moderation interval for $this setup. It needs to be passed in on a board-by-board basis.
Signature · 1 line
balbi
A message that is not in the archive (sent off-list or not yet received): 87mvhosr4g.fsf-VuQAYsv1563Yd54FQh9/[email protected]
Re: [PATCH 3/6] Documentation: devicetree: dwc3: Add interrupt moderation
Quoted 8 lines · Felipe Balbi
Quoted 6 lines · Mark Rutland
Quoted 5 lines · John Youn
Quoted 4 lines · Mark Rutland
Quoted 3 lines · John Youn
Add interrupt moderation interval binding for dwc3.
+ - snps,imod_interval: the interrupt moderation interval.
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
This series implements the feature and enables it as a workaround for a particular version of the controller.
... as a workaround for *what*? Is there a bug in that IP version, or an
you didn't receive the entire series, I guess. Here's last patch in the series:
No, I did not. Thanks for forwarding this.
Quoted 38 lines
This is a workaround for STAR 9000961433 which affects only version 3.00a of the
DWC_usb3core. This prevents the controller interrupt from being masked while handling events. Enabling interrupt moderation allows us to work around this issue because once the GEVNTCOUNT.count is written the IRQ is immediately deasserted and won't be asserted again until GEVNTCOUNT.EHB is cleared.---
drivers/usb/dwc3/core.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)diff --git
a/drivers/usb/dwc3/core.cb/drivers/usb/dwc3/core.cindex 6733838..7fa0832 100644
---a/drivers/usb/dwc3/core.c
+++b/drivers/usb/dwc3/core.c
@@ -1050,6 +1050,18 @@ static voiddwc3_check_params(struct dwc3 *dwc)dwc->imod_interval = 0; }+ /*
+ * Workaround for STAR 9000961433 which affects only version
+ * 3.00a of theDWC_usb3core. This prevents the controller
+ * interrupt from being masked while handling events. IMOD
+ * allows us to work around this issue. Enable it for the
+ * affected version.
+ */
+ if (!dwc->imod_interval &&
+ (dwc->revision==DWC3_REVISION_300A)) {
+dwc->imod_interval= 1;
+ }
+/* Check the maximum_speed parameter */ switch (dwc->maximum_speed) { case USB_SPEED_LOW:Quoted 2 lines
integration issue? Does the problem vary per-board?
Quoted 8 lines
Quoted 3 lines
Generally, if there's a problem that needs to be worked around, we describe the problem in the DT (perhaps implicitly in the compatible string), and then the kernel chooses the workaround.
Regardless of the silicon erratum, interrupt moderation is a *feature* of the IP, common to all instances since revision v3.00a (IIRC). John is just using interrupt moderation in the context of implementing this workaround. But the actual feature is valid also without the erratum.
Sure, I understand this.
Quoted 3 lines
Another thing to remember is that different applications (i.e. boards) might want to moderate the interrupt for different periods. That's, again, not related to the erratum at all.
... again, the question is *why*?
If this varies per use-case, then it would be better to handle this dynamically -- people can run wildly different use-cases on the same hardware.
I'm not sure that it makes sense for this to be in the DT, though I may have misunderstood.
Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 3/6] Documentation: devicetree: dwc3: Add interrupt moderation
Quoted 72 lines · Mark Rutland
Quoted 8 lines · Felipe Balbi
Quoted 6 lines · Mark Rutland
Quoted 5 lines · John Youn
Quoted 4 lines · Mark Rutland
Quoted 3 lines · John Youn
Add interrupt moderation interval binding for dwc3.
+ - snps,imod_interval: the interrupt moderation interval.
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
This series implements the feature and enables it as a workaround for a particular version of the controller.
... as a workaround for *what*? Is there a bug in that IP version, or an
you didn't receive the entire series, I guess. Here's last patch in the series:
No, I did not. Thanks for forwarding this.
Quoted 38 lines
This is a workaround for STAR 9000961433 which affects only version 3.00a of the
DWC_usb3core. This prevents the controller interrupt from being masked while handling events. Enabling interrupt moderation allows us to work around this issue because once the GEVNTCOUNT.count is written the IRQ is immediately deasserted and won't be asserted again until GEVNTCOUNT.EHB is cleared.---
drivers/usb/dwc3/core.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)diff --git
a/drivers/usb/dwc3/core.cb/drivers/usb/dwc3/core.cindex 6733838..7fa0832 100644
---a/drivers/usb/dwc3/core.c
+++b/drivers/usb/dwc3/core.c
@@ -1050,6 +1050,18 @@ static voiddwc3_check_params(struct dwc3 *dwc)dwc->imod_interval = 0; }+ /*
+ * Workaround for STAR 9000961433 which affects only version
+ * 3.00a of theDWC_usb3core. This prevents the controller
+ * interrupt from being masked while handling events. IMOD
+ * allows us to work around this issue. Enable it for the
+ * affected version.
+ */
+ if (!dwc->imod_interval &&
+ (dwc->revision==DWC3_REVISION_300A)) {
+dwc->imod_interval= 1;
+ }
+/* Check the maximum_speed parameter */ switch (dwc->maximum_speed) { case USB_SPEED_LOW:Quoted 2 lines
integration issue? Does the problem vary per-board?
Quoted 8 lines
Quoted 3 lines
Generally, if there's a problem that needs to be worked around, we describe the problem in the DT (perhaps implicitly in the compatible string), and then the kernel chooses the workaround.
Regardless of the silicon erratum, interrupt moderation is a *feature* of the IP, common to all instances since revision v3.00a (IIRC). John is just using interrupt moderation in the context of implementing this workaround. But the actual feature is valid also without the erratum.
Sure, I understand this.
Quoted 3 lines
Another thing to remember is that different applications (i.e. boards) might want to moderate the interrupt for different periods. That's, again, not related to the erratum at all.
Quoted 5 lines
... again, the question is *why*?
If this varies per use-case, then it would be better to handle this dynamically -- people can run wildly different use-cases on the same hardware.
It could make sense either per use-case or per platform.
If we add a dynamic setting, would that be through sysfs?
Quoted 3 lines
I'm not sure that it makes sense for this to be in the DT, though I may have misunderstood.
I'm ok omitting the DT binding until it is needed by someone. Since we currently only need it for the workaround, which is detected automatically.
Felipe, are you ok with this?
Regards,
John
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): 75a1dc4a-1d7e-a8e3-dd71-c0bed1927dca-HKixBCOQz3hWk0Htik3J/[email protected]
Re: [PATCH 3/6] Documentation: devicetree: dwc3: Add interrupt moderation
Hi,
Quoted 8 lines · John Youn
Quoted 2 lines
I'm not sure that it makes sense for this to be in the DT, though I may have misunderstood.
I'm ok omitting the DT binding until it is needed by someone. Since we currently only need it for the workaround, which is detected automatically.
Felipe, are you ok with this?
certainly. No problems whatsoever :-)
Signature · 1 line
balbi
Re: [PATCH 3/6] Documentation: devicetree: dwc3: Add interrupt moderation
In reply to a message not in the archiveHi,
Quoted 12 lines · John Youn
Add interrupt moderation interval binding for dwc3.
--- Documentation/devicetree/bindings/usb/dwc3.txt | 1 + 1 file changed, 1 insertion(+)Documentation/devicetree/bindings/usb/dwc3.txt +0
-0
Documentation/devicetree/bindings/usb/dwc3.txt Optional properties: · line 56
Quoted 4 lines
Documentation/devicetree/bindings/usb/dwc3.txt +1
-0@@ -53,6 +53,7 @@ Optional properties: - snps,quirk-frame-length-adjustment: Value for GFLADJ_30MHZ field of GFLADJ register for post-silicon frame length adjustment when the fladj_30mhz_sdbnd signal is invalid or incorrect. + - snps,imod_interval: the interrupt moderation interval.
on top of all other comments, what's the unit here? nanoseconds? clock cycles?
Signature · 1 line
balbi
A message that is not in the archive (sent off-list or not yet received): 87eg32t6fn.fsf-VuQAYsv1563Yd54FQh9/[email protected]
Re: [PATCH 3/6] Documentation: devicetree: dwc3: Add interrupt moderation
Quoted 11 lines · Felipe Balbi
Hi,
Quoted 7 lines · John Youn
Add interrupt moderation interval binding for dwc3.
--- Documentation/devicetree/bindings/usb/dwc3.txt | 1 + 1 file changed, 1 insertion(+)
Quoted 12 lines
Documentation/devicetree/bindings/usb/dwc3.txt Optional properties: · line 56
Quoted 9 lines
Documentation/devicetree/bindings/usb/dwc3.txt +1
-0@@ -53,6 +53,7 @@ Optional properties: - snps,quirk-frame-length-adjustment: Value for GFLADJ_30MHZ field of GFLADJ register for post-silicon frame length adjustment when the fladj_30mhz_sdbnd signal is invalid or incorrect. + - snps,imod_interval: the interrupt moderation interval.on top of all other comments, what's the unit here? nanoseconds? clock cycles?
Number of 250 ns intervals. I'll update the description to clarify.
Regards,
John
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): 911fcadd-b852-d9db-c733-2df7c106c8d1-HKixBCOQz3hWk0Htik3J/[email protected]
Re: [PATCH 3/6] Documentation: devicetree: dwc3: Add interrupt moderation
Hi,
Quoted 25 lines · John Youn
Quoted 11 lines · Felipe Balbi
Hi,
Quoted 7 lines · John Youn
Add interrupt moderation interval binding for dwc3.
--- Documentation/devicetree/bindings/usb/dwc3.txt | 1 + 1 file changed, 1 insertion(+)Quoted 12 lines
Documentation/devicetree/bindings/usb/dwc3.txt Optional properties: · line 56
Quoted 9 lines
Documentation/devicetree/bindings/usb/dwc3.txt +1
-0@@ -53,6 +53,7 @@ Optional properties: - snps,quirk-frame-length-adjustment: Value for GFLADJ_30MHZ field of GFLADJ register for post-silicon frame length adjustment when the fladj_30mhz_sdbnd signal is invalid or incorrect. + - snps,imod_interval: the interrupt moderation interval.on top of all other comments, what's the unit here? nanoseconds? clock cycles?
Quoted 1 line
Number of 250 ns intervals. I'll update the description to clarify.
it's probably better to add it in nanoseconds itself, then let driver compute register value with DIV_ROUND_UP()
Signature · 1 line
balbi
A message that is not in the archive (sent off-list or not yet received): 87shrgss3f.fsf-VuQAYsv1563Yd54FQh9/[email protected]
Re: [PATCH 3/6] Documentation: devicetree: dwc3: Add interrupt moderation
Quoted 29 lines · Felipe Balbi
Hi,
Quoted 25 lines · John Youn
Quoted 23 lines · Felipe Balbi
Hi,
Quoted 12 lines · John Youn
Add interrupt moderation interval binding for dwc3.
--- Documentation/devicetree/bindings/usb/dwc3.txt | 1 + 1 file changed, 1 insertion(+)Documentation/devicetree/bindings/usb/dwc3.txt +0
-0Documentation/devicetree/bindings/usb/dwc3.txt Optional properties: · line 56
Quoted 4 lines
Documentation/devicetree/bindings/usb/dwc3.txt +1
-0@@ -53,6 +53,7 @@ Optional properties: - snps,quirk-frame-length-adjustment: Value for GFLADJ_30MHZ field of GFLADJ register for post-silicon frame length adjustment when the fladj_30mhz_sdbnd signal is invalid or incorrect. + - snps,imod_interval: the interrupt moderation interval.on top of all other comments, what's the unit here? nanoseconds? clock cycles?
Quoted 5 lines
Quoted 1 line
Number of 250 ns intervals. I'll update the description to clarify.
it's probably better to add it in nanoseconds itself, then let driver compute register value with
DIV_ROUND_UP()
I'm fine with it either way, but I think "increments of 250 ns" is slightly cleaner in that it reflects the exact settings that are possible and documented, and also fits neatly into a u16.
I assume you'd also like the internal variable dwc3->imod_interval changed as well?
Regards,
John
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
A message that is not in the archive (sent off-list or not yet received): d2e54dd2-a400-39d4-3fc9-c41ba45bdb18-HKixBCOQz3hWk0Htik3J/[email protected]
Re: [PATCH 3/6] Documentation: devicetree: dwc3: Add interrupt moderation
Hi,
Quoted 23 lines · John Youn
Quoted 23 lines
Quoted 22 lines
Quoted 8 lines
Quoted 7 lines · John Youn
Add interrupt moderation interval binding for dwc3.
--- Documentation/devicetree/bindings/usb/dwc3.txt | 1 + 1 file changed, 1 insertion(+)Quoted 12 lines
Documentation/devicetree/bindings/usb/dwc3.txt Optional properties: · line 56
Quoted 9 lines
Documentation/devicetree/bindings/usb/dwc3.txt +1
-0@@ -53,6 +53,7 @@ Optional properties: - snps,quirk-frame-length-adjustment: Value for GFLADJ_30MHZ field of GFLADJ register for post-silicon frame length adjustment when the fladj_30mhz_sdbnd signal is invalid or incorrect. + - snps,imod_interval: the interrupt moderation interval.on top of all other comments, what's the unit here? nanoseconds? clock cycles?
Number of 250 ns intervals. I'll update the description to clarify.
Quoted 7 lines
Quoted 3 lines
it's probably better to add it in nanoseconds itself, then let driver compute register value with
DIV_ROUND_UP()I'm fine with it either way, but I think "increments of 250 ns" is slightly cleaner in that it reflects the exact settings that are possible and documented, and also fits neatly into a u16.
I don't know, I'll leave this to Mark and the other devicetree folks, but I remember there was a preference of not passing register values via devicetree. What if a following HW revision decides to change 250ns increments to 125ns increments?
Mark?
Signature · 1 line
balbi
A message that is not in the archive (sent off-list or not yet received): 87lgx3phxi.fsf-VuQAYsv1563Yd54FQh9/[email protected]
Re: [PATCH 3/6] Documentation: devicetree: dwc3: Add interrupt moderation
Quoted 35 lines · Felipe Balbi
Hi,
Quoted 23 lines · John Youn
Quoted 23 lines
Quoted 22 lines
Quoted 8 lines
Quoted 7 lines · John Youn
Add interrupt moderation interval binding for dwc3.
--- Documentation/devicetree/bindings/usb/dwc3.txt | 1 + 1 file changed, 1 insertion(+)Quoted 12 lines
Documentation/devicetree/bindings/usb/dwc3.txt Optional properties: · line 56
Quoted 9 lines
Documentation/devicetree/bindings/usb/dwc3.txt +1
-0@@ -53,6 +53,7 @@ Optional properties: - snps,quirk-frame-length-adjustment: Value for GFLADJ_30MHZ field of GFLADJ register for post-silicon frame length adjustment when the fladj_30mhz_sdbnd signal is invalid or incorrect. + - snps,imod_interval: the interrupt moderation interval.on top of all other comments, what's the unit here? nanoseconds? clock cycles?
Number of 250 ns intervals. I'll update the description to clarify.
Quoted 7 lines
Quoted 3 lines
it's probably better to add it in nanoseconds itself, then let driver compute register value with
DIV_ROUND_UP()I'm fine with it either way, but I think "increments of 250 ns" is slightly cleaner in that it reflects the exact settings that are possible and documented, and also fits neatly into a u16.
Quoted 6 lines
I don't know, I'll leave this to Mark and the other devicetree folks, but I remember there was a preference of not passing register values via devicetree. What if a following HW revision decides to change 250ns increments to 125ns increments?
Mark?
Generally, directly human-readable units are preferable, with some validation/reporting left to the driver for cases the HW cannot support. In this case, some *-interval-ns property would be better.
That said, it sounds like we're all agreed that we don't need this property for now. :)
Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 3/6 Documentation: devicetree: dwc3: Add interrupt moderation
In reply to a message not in the archiveAdd interrupt moderation interval binding for dwc3.
--- Documentation/devicetree/bindings/usb/dwc3.txt | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/usb/dwc3.txt +1 -0
@@ -53,6 +53,7 @@ Optional properties: - snps,quirk-frame-length-adjustment: Value for GFLADJ_30MHZ field of GFLADJ register for post-silicon frame length adjustment when the fladj_30mhz_sdbnd signal is invalid or incorrect. + - snps,imod_interval: the interrupt moderation interval. - <DEPRECATED> tx-fifo-resize: determines if the FIFO *has* to be reallocated.
Signature · 6 lines
2.10.0 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html