Skip to contentSkip to conversation

gstreamer: can optionally use libxml2

PATCH New gustavo.zacarias at free-electrons.com 2 participants 2 messages Nov 20, 2015 – Nov 26, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gstreamer: can optionally use libxml2

From: Gustavo Zacarias <[email protected]>

gstreamer can optionally build against libxml2, so account for it in the dependencies.
Functionality seems somewhat reduced without it, an example being misdetecting subtitle (.srt) files as subrip mime type instead of subtitle itself.

A failed scenario would be:

$ gst-typefind-0.10 some.srt
some.srt - application/x-subrip

When built with libxml2:

$ gst-typefind-0.10 some.srt
some.srt - application/x-subtitle

This doesn't affect gstreamer 1.x since it dropped any use of libxml2.

---
 package/gstreamer/gstreamer/gstreamer.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
package/gstreamer/gstreamer/gstreamer.mk +2 -1
index 3705298..74a5840 100644
@@ -30,6 +30,7 @@ GSTREAMER_CONF_OPTS = \
 	$(if $(BR2_PACKAGE_GSTREAMER_GST_DEBUG),,--disable-gst-debug) \
 	$(if $(BR2_PACKAGE_GSTREAMER_PLUGIN_REGISTRY),,--disable-registry)
 
-GSTREAMER_DEPENDENCIES = libglib2 host-pkgconf host-bison host-flex
+GSTREAMER_DEPENDENCIES = libglib2 host-pkgconf host-bison host-flex \
+	$(if $(BR2_PACKAGE_LIBXML2),libxml2)
 
 $(eval $(autotools-package))
Signature · 1 line
2.4.10
#1 lore raw

PATCH 1/1 gstreamer: can optionally use libxml2

Quoted 14 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"gustavo" == gustavo zacarias <[email protected]> writes:

From: Gustavo Zacarias <[email protected]> gstreamer can optionally build against libxml2, so account for it in the dependencies.
Functionality seems somewhat reduced without it, an example being misdetecting subtitle (.srt) files as subrip mime type instead of subtitle itself.

A failed scenario would be:

$ gst-typefind-0.10 some.srt
some.srt - application/x-subrip
Quoted 8 lines

When built with libxml2:

$ gst-typefind-0.10 some.srt
some.srt - application/x-subtitle

This doesn't affect gstreamer 1.x since it dropped any use of libxml2.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard