drm/dp_helper: don't return EPROTO for defers
Subsystems (2)
Dave Airlie
maintainerPATCH 1/1 drm/dp_helper: don't return EPROTO for defers
From: Dave Airlie <[email protected]>
If we get a msg.reply of REPLY_DEFER, we also get an err of 0 so we fail reads with 0 < size and return -EPROTO instead of trying again.
Found writing MST support.
--- drivers/gpu/drm/drm_dp_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/drm_dp_helper.c +2 -2
@@ -386,11 +386,11 @@ static int drm_dp_dpcd_access(struct drm_dp_aux *aux, u8 request,return err; } -if (err < size) -return -EPROTO ;switch (msg.reply &DP_AUX_NATIVE_REPLY_MASK ) {case DP_AUX_NATIVE_REPLY_ACK : +if (err < size) +return -EPROTO ;return err;case DP_AUX_NATIVE_REPLY_NACK :
Signature · 1 line
1.8.5.3
Quoted 8 lines · Dave Airlie
From: Dave Airlie <[email protected]>
If we get a msg.reply of
REPLY_DEFER, we also get an err of 0 so we fail reads with 0 < size and return-EPROTOinstead of trying again.Found writing MST support.
Quoted 30 lines
Signed-off-by Dave Airlie <[email protected]>--- drivers/gpu/drm/drm_dp_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/drm_dp_helper.c +2
-2@@ -386,11 +386,11 @@ static int drm_dp_dpcd_access(struct drm_dp_aux *aux, u8 request,return err; } -if (err < size) -return -EPROTO ;switch (msg.reply &DP_AUX_NATIVE_REPLY_MASK ) {case DP_AUX_NATIVE_REPLY_ACK : +if (err < size) +return -EPROTO ;return err;case DP_AUX_NATIVE_REPLY_NACK :Signature · 6 lines
1.8.5.3 _______________________________________________ dri-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 1 line
Jani Nikula, Intel Open Source Technology Center
Quoted 11 lines · Jani Nikula
Quoted 8 lines · Dave Airlie
From: Dave Airlie <[email protected]>
If we get a msg.reply of
REPLY_DEFER, we also get an err of 0 so we fail reads with 0 < size and return-EPROTOinstead of trying again.Found writing MST support.
Reviewed-by Jani Nikula <[email protected]>
On second thought, I think you'll need the same for drm_dp_i2c_do_msg() as well.
Cheers,
Jani.
Quoted 39 lines
Quoted 32 lines
Signed-off-by Dave Airlie <[email protected]>--- drivers/gpu/drm/drm_dp_helper.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/drm_dp_helper.c +2
-2@@ -386,11 +386,11 @@ static int drm_dp_dpcd_access(struct drm_dp_aux *aux, u8 request,return err; } -if (err < size) -return -EPROTO ;switch (msg.reply &DP_AUX_NATIVE_REPLY_MASK ) {case DP_AUX_NATIVE_REPLY_ACK : +if (err < size) +return -EPROTO ;return err;case DP_AUX_NATIVE_REPLY_NACK :Signature · 6 lines
1.8.5.3 _______________________________________________ dri-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/dri-develSignature · 5 lines
Jani Nikula, Intel Open Source Technology Center _______________________________________________ dri-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 1 line
Jani Nikula, Intel Open Source Technology Center
Thierry Reding
Reviewed-byQuoted 8 lines · Jani Nikula
Quoted 7 lines · Jani Nikula
Quoted 6 lines · Dave Airlie
From: Dave Airlie <[email protected]>
If we get a msg.reply of
REPLY_DEFER, we also get an err of 0 so we fail reads with 0 < size and return-EPROTOinstead of trying again.
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
Found writing MST support.
Reviewed-by Jani Nikula <[email protected]>On second thought, I think you'll need the same for
drm_dp_i2c_do_msg()as well.
I agree. drm_dp_i2c_do_msg() should have the same change. With that:
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel