Skip to contentSkip to conversation

Fix problems related to Blackfin lacking AI_ADDRCONFIG

PATCH New Thomas Petazzoni 2 participants 5 messages May 28, 2013 – May 29, 2013

lore
Share & tools
lore
#0 lore raw

cover Fix problems related to Blackfin lacking AI_ADDRCONFIG

Hello,

The Blackfin external toolchains provided by Analog Devices don't have AI_ADDRCONFIG enabled in their uClibc configuration. But since Buildroot has it enabled in its default uClibc configuration, our packages make the assumption that it is available.

This causes some build failures in the autobuilders (and possibly for users), so this set of two patches prevent the selection of packages that require AI_ADDRCONFIG when a Blackfin toolchain from ADI is used.

Long term, it would be better if the toolchains from ADI had AI_ADDRCONFIG enabled in their uClibc configuration.

Best regards,

Thomas

Thomas Petazzoni (2):
czmq: prevent selection when ADI Blackfin external toolchains are
used
libtirpc: prevent selection when ADI Blackfin external toolchains are
used

 package/czmq/Config.in     |    4 ++++
 package/filemq/Config.in   |    4 ++++
 package/libtirpc/Config.in |    7 +++++++
 package/rpcbind/Config.in  |    4 ++++
 package/zyre/Config.in     |    4 ++++
 5 files changed, 23 insertions(+)
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/2 czmq: prevent selection when ADI Blackfin external toolchains are used

czmq fails to build with the Blackfin external toolchains provided by Analog Devices, because their uClibc configuration doesn't include AI_ADDRCONFIG. In order to prevent such build failures to happen, we simply prevent the selection of czmq or one of its reverse dependencies when such toolchains are used.

This fixes:

http://autobuild.buildroot.org/results/821/82140fac4c2a2cef3f38f06cada8f17fd7f0078b/build-end.log

---
 package/czmq/Config.in   |    4 ++++
 package/filemq/Config.in |    4 ++++
 package/zyre/Config.in   |    4 ++++
 3 files changed, 12 insertions(+)
package/czmq/Config.in +4 -0
index 7e4205e..0f16c2e 100644
@@ -6,6 +6,10 @@ config BR2_PACKAGE_CZMQ
 	depends on BR2_LARGEFILE # util-linux
 	depends on BR2_USE_WCHAR # util-linux
 	depends on BR2_TOOLCHAIN_HAS_THREADS # zeromq
+	# uClibc toolchains provided by ADI don't have AI_ADDRCONFIG
+	# support
+	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2 && \
+		!BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R1
 	help
 	  High-level C Binding for 0MQ
 
package/filemq/Config.in +4 -0
index d25f03f..6f9fdb0 100644
@@ -8,6 +8,10 @@ config BR2_PACKAGE_FILEMQ
 	depends on BR2_LARGEFILE # util-linux
 	depends on BR2_USE_WCHAR # util-linux
 	depends on BR2_TOOLCHAIN_HAS_THREADS # zeromq
+	# uClibc toolchains provided by ADI don't have AI_ADDRCONFIG
+	# support, which is needed by czmq
+	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2 && \
+		!BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R1
 	help
 	  FileMQ is a publish-subscribe file service based on 0MQ.
 
package/zyre/Config.in +4 -0
index f181ac8..0ae0eec 100644
@@ -5,6 +5,10 @@ config BR2_PACKAGE_ZYRE
 	depends on BR2_LARGEFILE # filemq
 	depends on BR2_USE_WCHAR # filemq
 	depends on BR2_TOOLCHAIN_HAS_THREADS # filemq
+	# uClibc toolchains provided by ADI don't have AI_ADDRCONFIG
+	# support, needed by filemq -> czmq
+	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2 && \
+		!BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R1
 	select BR2_PACKAGE_FILEMQ
 	help
 	  An open-source framework for proximity-based peer-to-peer
Signature · 1 line
1.7.9.5
#2 lore raw

PATCH 1/2 czmq: prevent selection when ADI Blackfin external toolchains are used

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Thomas> czmq fails to build with the Blackfin external toolchains provided by Thomas> Analog Devices, because their uClibc configuration doesn't include Thomas> AI_ADDRCONFIG. In order to prevent such build failures to happen, we Thomas> simply prevent the selection of czmq or one of its reverse Thomas> dependencies when such toolchains are used.

Thomas> This fixes:

Thomas> http://autobuild.buildroot.org/results/821/82140fac4c2a2cef3f38f06cada8f17fd7f0078b/build-end.log

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard
#3 lore raw

PATCH 2/2 libtirpc: prevent selection when ADI Blackfin external toolchains are used

In reply to Thomas Petazzoni

libtirpc fails to build with the Blackfin external toolchains provided by Analog Devices, because their uClibc configuration doesn't include AI_ADDRCONFIG. In order to prevent such build failures to happen, we simply prevent libtirpc from being selected when such toolchains are used. This is not a big problem, since they provide native RPC support.

Also, since they provide native RPC, we don't have to propagate this new dependency to the reverse dependencies of libtirpc, because they all use native RPC when available. The exception to this rule is the rpcbind package, which can only use the libtirpc implementation of RPCs, and not the native one of C libraries. Therefore, the dependency is propagated to the rpcbind package.

Fixes:

http://autobuild.buildroot.org/results/58b/58b16449065c16afce11ba120db56839efb2b1ea/build-end.log

---
 package/libtirpc/Config.in |    7 +++++++
 package/rpcbind/Config.in  |    4 ++++
 2 files changed, 11 insertions(+)
package/libtirpc/Config.in +7 -0
index 7e891b4..b9db5aa 100644
@@ -1,5 +1,12 @@
 config BR2_PACKAGE_LIBTIRPC
 	bool "libtirpc"
+	# uClibc toolchains provided by ADI don't have AI_ADDRCONFIG
+	# support. Note that since they provide native RPC support, we
+	# don't need to propagate this dependency to reverse
+	# dependencies of libtirpc for which native RPC support can be
+	# used instead of libtirpc.
+	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2 && \
+		!BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R1
 	help
 	  Libtirpc is a port of Sun's Transport-Independent RPC
 	  library to Linux.
package/rpcbind/Config.in +4 -0
index 1bdcd9e..cbe53af 100644
@@ -3,6 +3,10 @@ config BR2_PACKAGE_RPCBIND
 	# We really need libtirpc and can't work with the native RPC
 	# implementation of toolchains.
 	select BR2_PACKAGE_LIBTIRPC
+	# uClibc toolchains provided by ADI don't have AI_ADDRCONFIG
+	# support, needed for libtirpc
+	depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R2 && \
+		!BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX_2012R1
 	help
 	  The rpcbind utility is a server that converts RPC program numbers
 	  into universal addresses.
Signature · 1 line
1.7.9.5
#4 lore raw

PATCH 2/2 libtirpc: prevent selection when ADI Blackfin external toolchains are used

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Thomas" == Thomas Petazzoni <[email protected]> writes:

Thomas> libtirpc fails to build with the Blackfin external toolchains provided Thomas> by Analog Devices, because their uClibc configuration doesn't include Thomas> AI_ADDRCONFIG. In order to prevent such build failures to happen, we Thomas> simply prevent libtirpc from being selected when such toolchains are Thomas> used. This is not a big problem, since they provide native RPC Thomas> support.

Thomas> Also, since they provide native RPC, we don't have to propagate this Thomas> new dependency to the reverse dependencies of libtirpc, because they Thomas> all use native RPC when available. The exception to this rule is the Thomas> rpcbind package, which can only use the libtirpc implementation of Thomas> RPCs, and not the native one of C libraries. Therefore, the dependency Thomas> is propagated to the rpcbind package.

Thomas> Fixes:

Thomas> http://autobuild.buildroot.org/results/58b/58b16449065c16afce11ba120db56839efb2b1ea/build-end.log

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard