Skip to contentSkip to conversation

ath10k: remove static mac address mask

PATCH New Michal Kazior 2 participants 2 messages May 16, 2013 – May 21, 2013 Qualcomm Atheros ATH10K wireless driver

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ath10k: remove static mac address mask

FW can dynamically adjust to multiple mac
addresses. It reports it's preferred base mac
address, but we can freely create derivative
addresses for vdevs.

---
 drivers/net/wireless/ath/ath10k/wmi.c |    8 --------
 1 file changed, 8 deletions(-)
drivers/net/wireless/ath/ath10k/wmi.c +0 -8
index 0d5070d..895567b 100644
@@ -907,14 +907,6 @@ static int ath10k_wmi_ready_event_rx(struct ath10k *ar, struct sk_buff *skb)
 
 	memcpy(ar->mac_addr, ev->mac_addr.addr, ETH_ALEN);
 
-	/* FIXME: FW should report possible addresses we can use. This is a
-	 *        development workaround. wpa_supplicant generates addresses
-	 *        that do not work with the FW without this. Once this is
-	 *        submitted upstream we should either get rid of this either by
-	 *        reducing functionality or forcing FW team to take action. */
-	memcpy(ar->hw->wiphy->perm_addr, ev->mac_addr.addr, ETH_ALEN);
-	memcpy(ar->hw->wiphy->addr_mask, "\x00\x00\x00\xFF\xFF\xFF", ETH_ALEN);
-
 	ath10k_dbg(ATH10K_DBG_WMI,
 		   "wmi event ready sw_version %u abi_version %u mac_addr %pM status %d\n",
 		   __le32_to_cpu(ev->sw_version),
Signature · 1 line
1.7.9.5
Applied
#1 lore raw

PATCH 1/1 ath10k: remove static mac address mask

Quoted 6 lines · Michal Kazior

FW can dynamically adjust to multiple mac
addresses. It reports it's preferred base mac
address, but we can freely create derivative
addresses for vdevs.

Thanks, applied.

Signature · 1 line
Kalle Valo