Skip to contentSkip to conversation

inotify-tools: Add new package

PATCH New Mike Williams 2 participants 3 messages Jul 25, 2011 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 inotify-tools: Add new package

Adds support for inotify-tools, which are useful for scripting the Linux inotify API.

---
 package/Config.in                      |    1 +
 package/inotify-tools/Config.in        |   10 ++++++++++
 package/inotify-tools/inotify-tools.mk |   10 ++++++++++
 3 files changed, 21 insertions(+), 0 deletions(-)
 create mode 100644 package/inotify-tools/Config.in
 create mode 100644 package/inotify-tools/inotify-tools.mk
package/Config.in +1 -0
index 40f523d..b3b93b0 100644
@@ -474,6 +474,7 @@ source "package/dash/Config.in"
 endif
 source "package/dialog/Config.in"
 source "package/file/Config.in"
+source "package/inotify-tools/Config.in"
 source "package/lockfile-progs/Config.in"
 source "package/logrotate/Config.in"
 source "package/screen/Config.in"
package/inotify-tools/Config.in new file +10 -0
new file mode 100644
index 0000000..1e6589d
@@ -0,0 +1,10 @@
+config BR2_PACKAGE_INOTIFY_TOOLS
+	bool "inotify-tools"
+	help
+	 inotify-tools is a C library and a set of command-line 
+	 programs for Linux providing a simple interface to inotify. 
+	 These programs can be used to monitor and act upon filesystem 
+	 events.
+
+		inotifywait  - wait for changes to files using inotify
+		inotifywatch - gather filesystem access statistics using inotify
package/inotify-tools/inotify-tools.mk new file +10 -0
new file mode 100644
index 0000000..4ff652c
@@ -0,0 +1,10 @@
+#############################################################
+#
+# inotify-utils
+# https://github.com/rvoicilas/inotify-tools
+#############################################################
+INOTIFY_TOOLS_VERSION = 3.14
+INOTIFY_TOOLS_SOURCE = inotify-tools-$(INOTIFY_TOOLS_VERSION).tar.gz
+INOTIFY_TOOLS_SITE = http://github.com/downloads/rvoicilas/inotify-tools/
+INOTIFY_TOOLS_INSTALL_TARGET = YES
+$(eval $(call AUTOTARGETS,package,inotify-tools))
Signature · 1 line
1.7.3.4
#1 lore raw

PATCH 1/1 inotify-tools: Add new package

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Mike" == Mike Williams <[email protected]> writes:

Mike> Adds support for inotify-tools, which are useful for scripting the Mike> Linux inotify API.

Thanks, see below for a few comments.

First of all, are you aware of busybox's inotifyd? From a quick look it seems to do more-or-less the same as these.

Mike> Signed-off-by: Mike Williams <[email protected]> Mike> ---

 Mike>  package/Config.in                      |    1 +
 Mike>  package/inotify-tools/Config.in        |   10 ++++++++++
 Mike>  package/inotify-tools/inotify-tools.mk |   10 ++++++++++
 Mike>  3 files changed, 21 insertions(+), 0 deletions(-)
 Mike>  create mode 100644 package/inotify-tools/Config.in
 Mike>  create mode 100644 package/inotify-tools/inotify-tools.mk

Mike> diff --git a/package/Config.in b/package/Config.in Mike> index 40f523d..b3b93b0 100644
Mike> --- a/package/Config.in
Mike> +++ b/package/Config.in
Mike> @@ -474,6 +474,7 @@ source "package/dash/Config.in"

 Mike>  endif
 Mike>  source "package/dialog/Config.in"
 Mike>  source "package/file/Config.in"
 Mike> +source "package/inotify-tools/Config.in"
 Mike>  source "package/lockfile-progs/Config.in"
 Mike>  source "package/logrotate/Config.in"
 Mike>  source "package/screen/Config.in"

Mike> diff --git a/package/inotify-tools/Config.in b/package/inotify-tools/Config.in Mike> new file mode 100644
Mike> index 0000000..1e6589d
Mike> --- /dev/null
Mike> +++ b/package/inotify-tools/Config.in
Mike> @@ -0,0 +1,10 @@
Mike> +config BR2_PACKAGE_INOTIFY_TOOLS
Mike> + bool "inotify-tools"
Mike> + help
Mike> + inotify-tools is a C library and a set of command-line
Mike> + programs for Linux providing a simple interface to inotify.
Mike> + These programs can be used to monitor and act upon filesystem
Mike> + events.

You're missing a space - Help text should be indented with <tab><space><space>. You also have a trailing space at the end of each of the help lines.

Mike> +
Mike> + inotifywait - wait for changes to files using inotify
Mike> + inotifywatch - gather filesystem access statistics using inotify

Please keep help lines <70 chars so they display ok in menuconfig in a normal 80x24 window - Perhaps skip the extra indentation for these 2 lines?

Please also add an upstream URL here.

Mike> diff --git a/package/inotify-tools/inotify-tools.mk b/package/inotify-tools/inotify-tools.mk Mike> new file mode 100644
Mike> index 0000000..4ff652c
Mike> --- /dev/null
Mike> +++ b/package/inotify-tools/inotify-tools.mk
Mike> @@ -0,0 +1,10 @@
Mike> +#############################################################
Mike> +#
Mike> +# inotify-utils
Mike> +# https://github.com/rvoicilas/inotify-tools

Put the url at the end of the help text in Config.in instead.

Mike> +############################################################# Mike> +INOTIFY_TOOLS_VERSION = 3.14
Mike> +INOTIFY_TOOLS_SOURCE = inotify-tools-$(INOTIFY_TOOLS_VERSION).tar.gz Mike> +INOTIFY_TOOLS_SITE = http://github.com/downloads/rvoicilas/inotify-tools/
Mike> +INOTIFY_TOOLS_INSTALL_TARGET = YES

INSTALL_TARGET is default, so you can drop that - same for _SOURCE as well.

Mike> +$(eval $(call AUTOTARGETS,package,inotify-tools))

Otherwise it looks good, thanks. Care to fix and resend?

Signature · 1 line
Bye, Peter Korsgaard

A message that is not in the archive (sent off-list or not yet received): CANPyyuOjm8U6osYRJWZKwWpRFJFQ1GXGjMJEA4TgG3oYH9MZGg@mail.gmail.com

#3 lore raw

PATCH 1/1 inotify-tools: Add new package

Peter,

Thanks for taking the time to review this so quickly.

Quoted 7 lines

?Mike> Adds support for inotify-tools, which are useful for scripting the ?Mike> Linux inotify API.

Thanks, see below for a few comments.

First of all, are you aware of busybox's inotifyd? From a quick look it seems to do more-or-less the same as these.

I was not (I did the lazy thing and searched through the buildroot package menus only). However, it doesn't mention automatically monitoring subdirectories that are created, which I need, so these tools appear to still be necessary.

Quoted 1 line

Otherwise it looks good, thanks. Care to fix and resend?

Sure, I'll try to get it done ASAP.

Thanks,
Mike