LVM2: fix t-000-basic.sh
PATCH 1/1 LVM2: fix t-000-basic.sh
Hi,
The testcase t-000-basic.sh doesn't work for me.
- It executes 'lvm' and sees the return code.
However, when readline support is enabled, it waits for user input. So 'make check' stalls.
- It expects return code '3'.
However, with the current CVS head, any of the followings return '0':
o 'lvm' without readline support
o 'lvm version'
o 'lvm < /dev/null'
The purpose of the test is to check if lvm is built. I think the test can be achieved with 'lvm version'.
Thanks,
Signature · 8 lines
Jun'ichi Nomura, NEC Corporation of America -------------- next part -------------- A non-text attachment was scrubbed... Name: lvm2-fix-t-000-basic.patch Type: text/x-patch Size: 606 bytes Desc: not available URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20071204/4aba7479/attachment.bin>
PATCH 1/1 LVM2: fix t-000-basic.sh
Quoted 12 lines · Jun'ichi Nomura
Hi,
The testcase
t-000-basic.shdoesn't work for me.
- It executes 'lvm' and sees the return code.
However, when readline support is enabled, it waits for user input. So 'make check' stalls.
- It expects return code '3'.
However, with the current CVS head, any of the followings return '0':
o 'lvm' without readline support
o 'lvm version'
o 'lvm </dev/null'
Quoted 4 lines
The purpose of the test is to check if lvm is built. I think the test can be achieved with 'lvm version'.
Thanks,
Thank you.
I committed it with the following log entry:
(FYI, the last two lines are added automatically when I run git-cvsexportcommit to export the commit from my git-based tree to the mast cvs-based one)
Avoid spurious test failure when compiled with readline support.
* test/t-000-basic.sh: Invoke initial test of lvm with its "version" argument, so that the behavior of the tool doesn't depend on whether readline was enabled at configure time.
Author: Jun'ichi Nomura <[email protected]>
Committer: Jim Meyering <[email protected]>