thread coredump oops fix
Subsystems (2)
PATCH 1/1 thread coredump oops fix
Hi,
If ->group_leader of current thread already was exiting, group_leader's ->mm is NULL in fill_psinfo(). Then I got Oops.
This uses current->mm instead of ->group_leader->mm to dump args.
fs/binfmt_elf.c | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-)
fs/binfmt_elf.c renamed from fs/binfmt_elf.c~thread_coredump-fix +5 -4
@@ -1084,18 +1084,19 @@ static void fill_prstatus(struct elf_prsjiffies_to_timeval (p->cstime, &prstatus->pr_cstime); } -static void fill_psinfo (struct elf_prpsinfo *psinfo,struct task_struct *p) +static void fill_psinfo (struct elf_prpsinfo *psinfo,struct task_struct *p, +struct mm_struct *mm) {int i, len;/* first copy the parameters from user space */ memset (psinfo,0 ,sizeof (struct elf_prpsinfo )); - len = p->mm->arg_end - p->mm->arg_start; + len = mm->arg_end - mm->arg_start;if (len >=ELF_PRARGSZ ) len =ELF_PRARGSZ -1 ;copy_from_user (&psinfo->pr_psargs, - (const char *)p->mm->arg_start, len); + (const char *)mm->arg_start, len);for (i =0 ; i < len; i++)if (psinfo->pr_psargs[i] ==0 ) psinfo->pr_psargs[i] =' ' ;
@@ -1280,7 +1281,7 @@ static int elf_core_dump(long signr, strfill_note (notes +0 ,"CORE" ,NT_PRSTATUS ,sizeof (*prstatus), prstatus); -fill_psinfo (psinfo, current->group_leader); +fill_psinfo (psinfo, current->group_leader, current->mm);fill_note (notes +1 ,"CORE" ,NT_PRPSINFO ,sizeof (*psinfo), psinfo);fill_note (notes +2 ,"CORE" ,NT_TASKSTRUCT ,sizeof (*current), current);
_
Signature · 1 line
OGAWA Hirofumi <[email protected]>