Skip to contentSkip to conversation

selftests/net/openvswitch: add SCTP flow key test

PATCH Superseded Minxi Hou 2 participants 3 messages Jul 7 – Jul 14 2 messages not in the archive

Subsystems (4)

v2 of 10 Superseded Latest is v10 →

lore
Share & tools
lore

Minxi Hou

author
#0 lore raw

PATCH v2 1/1 selftests/net/openvswitch: add SCTP flow key test

Register OVS_KEY_ATTR_SCTP in the flow key parser so that sctp() can be used in flow specifications. The ovs_key_sctp class already exists (with src/dst fields matching the TCP/UDP siblings) but was not wired into the parser, so the token was silently dropped and the kernel rejected the flow.

Add test_sctp_connect_v4 exercising the SCTP flow key with port-specific matching: sctp(dst=4443) for client-to-server and sctp(src=4443) for server-to-client.

Wait for ncat readiness with ovs_wait instead of a fixed sleep so the test does not race against ncat startup. Use grep -c on the listening message to distinguish between successive ncat instances that share the same stderr log. Kill the previous server before respawning to avoid EADDRINUSE on the SCTP port.

---
v1 -> v2: replace sleep with ovs_wait on ncat listening output,
kill previous ncat server before respawning to avoid port conflict (Aaron review feedback)

 .../selftests/net/openvswitch/openvswitch.sh  | 102 ++++++++++++++++++
 .../selftests/net/openvswitch/ovs-dpctl.py    |   5 +
 2 files changed, 107 insertions(+)
tools/testing/selftests/net/openvswitch/openvswitch.sh +102 -0
index 2954245129a2..9c364eeb2ec2 100755
@@ -32,6 +32,7 @@ tests="
 	dec_ttl					ttl: dec_ttl decrements IP TTL
 	flow_set				flow-set: Flow modify
 	action_set				set: SET action rewrites fields
+	sctp_connect_v4				sctp: SCTP flow key matching
 	psample					psample: Sampling packets with psample"
 
 info() {
@@ -443,6 +444,107 @@ test_action_set() {
 	return 0
 }
 
+# sctp_connect_v4 test
+# - sctp(dst=4443) matches client-to-server INIT
+# - sctp(src=4443) matches server-to-client INIT-ACK
+# - remove flows and verify connection fails, reinstall and recover
+test_sctp_connect_v4() {
+	local t="test_sctp_connect_v4"
+
+	which ncat >/dev/null 2>&1 || return $ksft_skip
+	modprobe -q sctp 2>/dev/null || return $ksft_skip
+
+	sbx_add "$t" || return $?
+	ovs_add_dp "$t" sctp4 || return 1
+
+	info "create namespaces"
+	for ns in client server; do
+		ovs_add_netns_and_veths "$t" "sctp4" "$ns" \
+		    "${ns:0:1}0" "${ns:0:1}1" || return 1
+	done
+
+	ip netns exec client ip addr add 172.31.110.10/24 dev c1
+	ip netns exec client ip link set c1 up
+	ip netns exec server ip addr add 172.31.110.20/24 dev s1
+	ip netns exec server ip link set s1 up
+
+	# ARP forwarding
+	ovs_add_flow "$t" sctp4 \
+	    'in_port(1),eth(),eth_type(0x0806),arp()' \
+	    '2' || return 1
+	ovs_add_flow "$t" sctp4 \
+	    'in_port(2),eth(),eth_type(0x0806),arp()' \
+	    '1' || return 1
+
+	# SCTP port matching: dst for request, src for reply
+	ovs_add_flow "$t" sctp4 \
+	    'in_port(1),eth(),eth_type(0x0800),ipv4(proto=132),sctp(dst=4443)' \
+	    '2' || return 1
+	ovs_add_flow "$t" sctp4 \
+	    'in_port(2),eth(),eth_type(0x0800),ipv4(proto=132),sctp(src=4443)' \
+	    '1' || return 1
+
+	echo "server" | \
+		ovs_netns_spawn_daemon "$t" "server" \
+				ncat --sctp -l 172.31.110.20 -vn 4443
+	local server_pid=$pid
+	ovs_wait sh -c \
+	    "[ \$(grep -c 'Ncat: Listening' ${ovs_dir}/stderr) -ge 1 ]" \
+	    || return 1
+
+	info "verify SCTP association with port-keyed flows"
+	ovs_sbx "$t" ip netns exec client \
+	    ncat --sctp -i 1 -zv 172.31.110.20 4443 \
+	    || return 1
+
+	ovs_del_flows "$t" sctp4
+
+	info "verify connection fails without flows"
+	ovs_add_flow "$t" sctp4 \
+	    'in_port(1),eth(),eth_type(0x0806),arp()' \
+	    '2' || return 1
+	ovs_add_flow "$t" sctp4 \
+	    'in_port(2),eth(),eth_type(0x0806),arp()' \
+	    '1' || return 1
+
+	kill -TERM $server_pid 2>/dev/null
+	echo "server2" | \
+		ovs_netns_spawn_daemon "$t" "server" \
+				ncat --sctp -l 172.31.110.20 -vn 4443
+	server_pid=$pid
+	ovs_wait sh -c \
+	    "[ \$(grep -c 'Ncat: Listening' ${ovs_dir}/stderr) -ge 2 ]" \
+	    || return 1
+
+	ovs_sbx "$t" ip netns exec client \
+	    ncat --sctp -w 2 -zv 172.31.110.20 4443 \
+	    >/dev/null 2>&1 \
+	    && { info "FAIL: connection should fail without flows"
+	         return 1; }
+
+	info "reinstall flows and verify recovery"
+	ovs_add_flow "$t" sctp4 \
+	    'in_port(1),eth(),eth_type(0x0800),ipv4(proto=132),sctp(dst=4443)' \
+	    '2' || return 1
+	ovs_add_flow "$t" sctp4 \
+	    'in_port(2),eth(),eth_type(0x0800),ipv4(proto=132),sctp(src=4443)' \
+	    '1' || return 1
+
+	kill -TERM $server_pid 2>/dev/null
+	echo "server3" | \
+		ovs_netns_spawn_daemon "$t" "server" \
+				ncat --sctp -l 172.31.110.20 -vn 4443
+	ovs_wait sh -c \
+	    "[ \$(grep -c 'Ncat: Listening' ${ovs_dir}/stderr) -ge 3 ]" \
+	    || return 1
+
+	ovs_sbx "$t" ip netns exec client \
+	    ncat --sctp -i 1 -zv 172.31.110.20 4443 \
+	    || return 1
+
+	return 0
+}
+
 # psample test
 # - use psample to observe packets
 test_psample() {
tools/testing/selftests/net/openvswitch/ovs-dpctl.py +5 -0
index e1ecfad2c03e..7cfc29ec7e59 100644
@@ -1982,6 +1982,11 @@ class ovskey(nla):
                 "icmp",
                 ovskey.ovs_key_icmp,
             ),
+            (
+                "OVS_KEY_ATTR_SCTP",
+                "sctp",
+                ovskey.ovs_key_sctp,
+            ),
             (
                 "OVS_KEY_ATTR_TCP_FLAGS",
                 "tcp_flags",
Signature · 1 line
2.55.0
maintainer
#1 lore raw
Quoted 40 lines · Minxi Hou

Register OVS_KEY_ATTR_SCTP in the flow key parser so that sctp() can be used in flow specifications. The ovs_key_sctp class already exists (with src/dst fields matching the TCP/UDP siblings) but was not wired into the parser, so the token was silently dropped and the kernel rejected the flow.

Add test_sctp_connect_v4 exercising the SCTP flow key with port-specific matching: sctp(dst=4443) for client-to-server and sctp(src=4443) for server-to-client.

Wait for ncat readiness with ovs_wait instead of a fixed sleep so the test does not race against ncat startup. Use grep -c on the listening message to distinguish between successive ncat instances that share the same stderr log. Kill the previous server before respawning to avoid EADDRINUSE on the SCTP port.

---
v1 -> v2: replace sleep with ovs_wait on ncat listening output,
kill previous ncat server before respawning to avoid port conflict (Aaron review feedback)

 .../selftests/net/openvswitch/openvswitch.sh  | 102 ++++++++++++++++++
 .../selftests/net/openvswitch/ovs-dpctl.py    |   5 +
 2 files changed, 107 insertions(+)
tools/testing/selftests/net/openvswitch/openvswitch.sh +1 -0
index 2954245129a2..9c364eeb2ec2 100755
@@ -32,6 +32,7 @@ tests="
 	dec_ttl					ttl: dec_ttl decrements IP TTL
 	flow_set				flow-set: Flow modify
 	action_set				set: SET action rewrites fields
+	sctp_connect_v4				sctp: SCTP flow key matching
 	psample					psample: Sampling packets with psample"
 
 info() {
@@ -443,6 +444,107 @@ test_action_set() {
 	return 0

tools/testing/selftests/net/openvswitch/openvswitch.sh test_action_set() { · line 454

Quoted 10 lines
tools/testing/selftests/net/openvswitch/openvswitch.sh +8 -0
 }
 
+# sctp_connect_v4 test
+# - sctp(dst=4443) matches client-to-server INIT
+# - sctp(src=4443) matches server-to-client INIT-ACK
+# - remove flows and verify connection fails, reinstall and recover
+test_sctp_connect_v4() {
+	local t="test_sctp_connect_v4"
+
+	which ncat >/dev/null 2>&1 || return $ksft_skip

Not a full review, but can we avoid ncat? We already use nc in other tests, using different implementations of the same thing in different tests doesn't sound like a good idea. On mnay systems nc and ncat will be different implementations with different options and behavior.

Best regards, Ilya Maximets.

A message that is not in the archive (sent off-list or not yet received): CAJ0BgHeDpvS1-stvrDp0HpUgQY8ZSdJZvAiw7fLpL2EHPeRwHg@mail.gmail.com

A message that is not in the archive (sent off-list or not yet received): CAJ0BgHc_3fRLFpaUkb2P2jY4avtB3XJQmk0jE-4UC=1abtKLaQ@mail.gmail.com

maintainer
#4 lore raw
Quoted 6 lines · 侯敏熙

Hi Ilya,

Thanks for pointing this out. I looked into this and found that nc (netcat-openbsd) on Debian/Ubuntu does not have SCTP support at all. The upstream OpenBSD nc only handles TCP, UDP, and Unix-domain sockets, and the Debian patches don't add SCTP either.

AFAICT, 'nc' in netdev CI is the nmap version of netcat, it's not the openbsd one. Does nmap version support sctp? Google seems to think so at least. The test should be skipped though if sctp is not supported.

Note: sashiko had some comments on the daemon pid handling in v2.

Best regards, Ilya Maximets.

Quoted 96 lines

I see two cleaner alternatives that already have precedent in the kernel selftests:

1. socat: net/netfilter/nft_queue.sh already uses
"socat -u SCTP-LISTEN:PORT STDOUT" for SCTP data-plane testing. Many drivers/net/ selftests already gate on require_cmd("socat").

2. A small C helper: similar to sctp_hello.c used by sctp_vrf.sh and conntrack_sctp_collision.sh. The shell test would call "./sctp_test server/client IP PORT" instead of ncat.

Which approach would you prefer for v3?

Best regards,
Minxi

Quoted 72 lines · 侯敏熙 <[email protected]> 于2026年7月13日周一 11:02写道:

Ah so many thanks for your suggestions, Please forgive me, I've always used ncat to write test cases.

I will re-spin this patch.

Quoted 64 lines · Ilya Maximets <[email protected]> 于2026年7月13日周一 10:39写道:
Quoted 22 lines · Minxi Hou

Register OVS_KEY_ATTR_SCTP in the flow key parser so that sctp() can be used in flow specifications. The ovs_key_sctp class already exists (with src/dst fields matching the TCP/UDP siblings) but was not wired into the parser, so the token was silently dropped and the kernel rejected the flow.

Add test_sctp_connect_v4 exercising the SCTP flow key with port-specific matching: sctp(dst=4443) for client-to-server and sctp(src=4443) for server-to-client.

Wait for ncat readiness with ovs_wait instead of a fixed sleep so the test does not race against ncat startup. Use grep -c on the listening message to distinguish between successive ncat instances that share the same stderr log. Kill the previous server before respawning to avoid EADDRINUSE on the SCTP port.

---
v1 -> v2: replace sleep with ovs_wait on ncat listening output,
kill previous ncat server before respawning to avoid port conflict (Aaron review feedback)

Review

Quoted 5 lines
 .../selftests/net/openvswitch/openvswitch.sh  | 102 ++++++++++++++++++
 .../selftests/net/openvswitch/ovs-dpctl.py    |   5 +
 2 files changed, 107 insertions(+)
(quoted diff) +0 -0

b/tools/testing/selftests/net/openvswitch/openvswitch.sh

tools/testing/selftests/net/openvswitch/openvswitch.sh tests=" · line 32

Quoted 5 lines

index 2954245129a2..9c364eeb2ec2 100755

tools/testing/selftests/net/openvswitch/openvswitch.sh +0 -0
@@ -32,6 +32,7 @@ tests="
      dec_ttl                                 ttl: dec_ttl decrements

IP TTL

tools/testing/selftests/net/openvswitch/openvswitch.sh tests=" · line 34

Quoted 2 lines
tools/testing/selftests/net/openvswitch/openvswitch.sh +0 -0
      flow_set                                flow-set: Flow modify
      action_set                              set: SET action rewrites

fields

tools/testing/selftests/net/openvswitch/openvswitch.sh tests=" · line 35

Quoted 1 line
tools/testing/selftests/net/openvswitch/openvswitch.sh +1 -0
+     sctp_connect_v4                         sctp: SCTP flow key

matching

tools/testing/selftests/net/openvswitch/openvswitch.sh tests=" · line 36

Quoted 1 line
tools/testing/selftests/net/openvswitch/openvswitch.sh +0 -0
      psample                                 psample: Sampling packets

with psample"

Quoted 4 lines
tools/testing/selftests/net/openvswitch/openvswitch.sh +0 -0
 info() {
@@ -443,6 +444,107 @@ test_action_set() {
      return 0

tools/testing/selftests/net/openvswitch/openvswitch.sh test_action_set() { · line 454

Quoted 10 lines
tools/testing/selftests/net/openvswitch/openvswitch.sh +8 -0
 }
 
+# sctp_connect_v4 test
+# - sctp(dst=4443) matches client-to-server INIT
+# - sctp(src=4443) matches server-to-client INIT-ACK
+# - remove flows and verify connection fails, reinstall and recover
+test_sctp_connect_v4() {
+     local t="test_sctp_connect_v4"
+
+     which ncat >/dev/null 2>&1 || return $ksft_skip

Not a full review, but can we avoid ncat? We already use nc in other tests, using different implementations of the same thing in different tests doesn't sound like a good idea. On mnay systems nc and ncat will be different implementations with different options and behavior.

Best regards, Ilya Maximets.

_______________________________________________
dev mailing list
[email protected]
https://mail.openvswitch.org/mailman/listinfo/ovs-dev